From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PowerCap: Fix an error code in powercap_register_zone()
Date: Thu, 11 May 2017 01:41:30 +0000 [thread overview]
Message-ID: <1494466890.440.3.camel@linux.intel.com> (raw)
In-Reply-To: <20170510194006.vsr5r5eyvjry4cka@mwanda>
On Wed, 2017-05-10 at 22:40 +0300, Dan Carpenter wrote:
> In the current code we accidentally return the successful result from
> idr_alloc() instead of a negative error pointer. The caller is
> looking
> for an error pointer and so it treats the returned value as a valid
> pointer.
>
> This one might be a bit serious because if it lets people get around
> the
> kernel's protection for remapping NULL. I'm not sure.
>
> Fixes: 75d2364ea0ca ("PowerCap: Add class driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> diff --git a/drivers/powercap/powercap_sys.c
> b/drivers/powercap/powercap_sys.c
> index 14bde0db8c24..5b10b50f8686 100644
> --- a/drivers/powercap/powercap_sys.c
> +++ b/drivers/powercap/powercap_sys.c
> @@ -538,6 +538,7 @@ struct powercap_zone *powercap_register_zone(
>
> power_zone->id = result;
> idr_init(&power_zone->idr);
> + result = -ENOMEM;
> power_zone->name = kstrdup(name, GFP_KERNEL);
> if (!power_zone->name)
> goto err_name_alloc;
WARNING: multiple messages have this Message-ID (diff)
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PowerCap: Fix an error code in powercap_register_zone()
Date: Wed, 10 May 2017 18:41:30 -0700 [thread overview]
Message-ID: <1494466890.440.3.camel@linux.intel.com> (raw)
In-Reply-To: <20170510194006.vsr5r5eyvjry4cka@mwanda>
On Wed, 2017-05-10 at 22:40 +0300, Dan Carpenter wrote:
> In the current code we accidentally return the successful result from
> idr_alloc() instead of a negative error pointer. The caller is
> looking
> for an error pointer and so it treats the returned value as a valid
> pointer.
>
> This one might be a bit serious because if it lets people get around
> the
> kernel's protection for remapping NULL. I'm not sure.
>
> Fixes: 75d2364ea0ca ("PowerCap: Add class driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>
> diff --git a/drivers/powercap/powercap_sys.c
> b/drivers/powercap/powercap_sys.c
> index 14bde0db8c24..5b10b50f8686 100644
> --- a/drivers/powercap/powercap_sys.c
> +++ b/drivers/powercap/powercap_sys.c
> @@ -538,6 +538,7 @@ struct powercap_zone *powercap_register_zone(
>
> power_zone->id = result;
> idr_init(&power_zone->idr);
> + result = -ENOMEM;
> power_zone->name = kstrdup(name, GFP_KERNEL);
> if (!power_zone->name)
> goto err_name_alloc;
next prev parent reply other threads:[~2017-05-11 1:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 19:40 [PATCH] PowerCap: Fix an error code in powercap_register_zone() Dan Carpenter
2017-05-10 19:40 ` Dan Carpenter
2017-05-11 1:41 ` Srinivas Pandruvada [this message]
2017-05-11 1:41 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494466890.440.3.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.