From: Trond Myklebust <trondmy@primarydata.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"n.borisov.lkml@gmail.com" <n.borisov.lkml@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"mhocko@suse.com" <mhocko@suse.com>
Subject: Re: [GIT PULL] Please pull NFS client fixes for 4.12
Date: Thu, 11 May 2017 13:41:12 +0000 [thread overview]
Message-ID: <1494510068.6968.0.camel@primarydata.com> (raw)
In-Reply-To: <be16be57-235c-fdf9-f708-3898aeeeb5aa@gmail.com>
T24gVGh1LCAyMDE3LTA1LTExIGF0IDEwOjUzICswMzAwLCBOaWtvbGF5IEJvcmlzb3Ygd3JvdGU6
DQo+IA0KPiBPbiAxMC4wNS4yMDE3IDE5OjQ3LCBUcm9uZCBNeWtsZWJ1c3Qgd3JvdGU6DQo+ID4g
SGkgTGludXMsDQo+ID4gDQo+ID4gVGhlIGZvbGxvd2luZyBjaGFuZ2VzIHNpbmNlIGNvbW1pdA0K
PiA+IDRmN2QwMjliOWJmMDA5ZmJlZTc2YmIxMGMwYzQzNTFhMTg3MGQyZjM6DQo+ID4gDQo+ID4g
wqAgTGludXggNC4xMS1yYzcgKDIwMTctMDQtMTYgMTM6MDA6MTggLTA3MDApDQo+ID4gDQo+ID4g
YXJlIGF2YWlsYWJsZSBpbiB0aGUgZ2l0IHJlcG9zaXRvcnkgYXQ6DQo+ID4gDQo+ID4gwqAgZ2l0
Oi8vZ2l0LmxpbnV4LW5mcy5vcmcvcHJvamVjdHMvdHJvbmRteS9saW51eC1uZnMuZ2l0IHRhZ3Mv
bmZzLQ0KPiA+IGZvci00LjEyLTENCj4gPiANCj4gPiBmb3IgeW91IHRvIGZldGNoIGNoYW5nZXMg
dXAgdG8NCj4gPiA3NmIyYTMwMzM4NGUxZDYyOTljM2EwMjQ5ZjBmMGNlMmY4Zjk2MDE3Og0KPiA+
IA0KPiA+IMKgIHBORlMvZmxleGZpbGVzOiBBbHdheXMgYXR0ZW1wdCB0byBjYWxsIGxheW91dHN0
YXRzIHdoZW4gZmxleGZpbGVzDQo+ID4gaXMgZW5hYmxlZCAoMjAxNy0wNS0wOSAxNjowMjo1NyAt
MDQwMCkNCj4gPiANCj4gPiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQo+ID4gTkZTIGNsaWVudCB1cGRhdGVzIGZvciBMaW51
eCA0LjEyDQo+ID4gDQo+ID4gSGlnaGxpZ2h0cyBpbmNsdWRlOg0KPiA+IA0KPiA+IFN0YWJsZSBi
dWdmaXhlczoNCj4gPiAtIEZpeCB1c2UgYWZ0ZXIgZnJlZSBpbiB3cml0ZSBlcnJvciBwYXRoDQo+
ID4gLSBVc2UgR0ZQX05PSU8gZm9yIHR3byBhbGxvY2F0aW9ucyBpbiB3cml0ZWJhY2sNCj4gPiAt
IEZpeCBhIGhhbmcgaW4gT1BFTiByZWxhdGVkIHRvIHNlcnZlciByZWJvb3QNCj4gPiAtIENoZWNr
IHRoZSByZXN1bHQgb2YgbmZzNF9wbmZzX2RzX2Nvbm5lY3QNCj4gPiAtIEZpeCBhbiByY3UgbG9j
ayBsZWFrDQo+ID4gDQo+ID4gRmVhdHVyZXM6DQo+ID4gLSBSZW1vdmFsIG9mIHRoZSB1bm1haW50
YWluZWQgYW5kIHVudXNlZCBPU0QgcE5GUyBsYXlvdXQNCj4gPiAtIENsZWFudXAgYW5kIHJlbW92
YWwgb2YgbG90cyBvZiB1bm5lY2Vzc2FyeSBkcHJpbnRrKClzDQo+ID4gLSBDbGVhbnVwIGFuZCBy
ZW1vdmFsIG9mIHNvbWUgbWVtb3J5IGZhaWx1cmUgcGF0aHMgbm93IHRoYXQNCj4gPiDCoCBHRlBf
Tk9GUyBpcyBndWFyYW50ZWVkIHRvIG5ldmVyIGZhaWwuDQo+IA0KPiBXaGF0IGd1YXJhbnRlZXMg
dGhhdD8gU2luY2UgaWYgdGhpcyBpcyB0aGUgY2FzZSB0aGVuIHRoaXMgY2FuIHJlc3VsdA0KPiBp
bg0KPiBhIGxvdCBvZiBvcHBvcnR1bml0aWVzIGZvciBjbGVhbnVwIGFjcm9zcyB0aGUgd2hvbGUg
a2VybmVsIHRyZWUuDQo+IEFmdGVyDQo+IGRpc2N1c3Npbmcgd2l0aCBtaG9ja28gKGNjJ2VkKSBp
dCBzZWVtcyB0aGF0IGluIHByYWN0aWNlIGV2ZXJ5dGhpbmcNCj4gYmVsb3cgQ09TVExZX09SREVS
IHdoaWNoIGFyZSBub3QgR0ZQX05PUkVUUlkgd2lsbCBuZXZlciBmYWlsLiBCdXQNCj4gdGhpcw0K
PiBzZW1hbnRpYyBpcyBub3QgdGhlIHNhbWUgYXMgR0ZQX05PRkFJTC4gRS5nLiBub3RoaW5nIGd1
YXJhbnRlZXMgdGhhdA0KPiB0aGlzIHdpbGwgc3RheSBsaWtlIHRoYXQgaW4gdGhlIGZ1dHVyZT8N
Cj4gDQoNCkFjdHVhbGx5LCBnb2luZyBiYWNrIHRvIHRoZSBjb2RlIHdpdGggY29mZmVlOiBpdCdz
IHRoZSBmYWN0IHdlIGhhdmUNCm1lbXBvb2xzLCB3aXRoIGRpcmVjdCByZWNsYWltIHRoYXQgZ3Vh
cmFudGVlIHRoaXMuDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1h
aW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo=
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@primarydata.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"n.borisov.lkml@gmail.com" <n.borisov.lkml@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"mhocko@suse.com" <mhocko@suse.com>
Subject: Re: [GIT PULL] Please pull NFS client fixes for 4.12
Date: Thu, 11 May 2017 13:41:12 +0000 [thread overview]
Message-ID: <1494510068.6968.0.camel@primarydata.com> (raw)
In-Reply-To: <be16be57-235c-fdf9-f708-3898aeeeb5aa@gmail.com>
On Thu, 2017-05-11 at 10:53 +0300, Nikolay Borisov wrote:
>
> On 10.05.2017 19:47, Trond Myklebust wrote:
> > Hi Linus,
> >
> > The following changes since commit
> > 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3:
> >
> > Linux 4.11-rc7 (2017-04-16 13:00:18 -0700)
> >
> > are available in the git repository at:
> >
> > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-
> > for-4.12-1
> >
> > for you to fetch changes up to
> > 76b2a303384e1d6299c3a0249f0f0ce2f8f96017:
> >
> > pNFS/flexfiles: Always attempt to call layoutstats when flexfiles
> > is enabled (2017-05-09 16:02:57 -0400)
> >
> > ----------------------------------------------------------------
> > NFS client updates for Linux 4.12
> >
> > Highlights include:
> >
> > Stable bugfixes:
> > - Fix use after free in write error path
> > - Use GFP_NOIO for two allocations in writeback
> > - Fix a hang in OPEN related to server reboot
> > - Check the result of nfs4_pnfs_ds_connect
> > - Fix an rcu lock leak
> >
> > Features:
> > - Removal of the unmaintained and unused OSD pNFS layout
> > - Cleanup and removal of lots of unnecessary dprintk()s
> > - Cleanup and removal of some memory failure paths now that
> > GFP_NOFS is guaranteed to never fail.
>
> What guarantees that? Since if this is the case then this can result
> in
> a lot of opportunities for cleanup across the whole kernel tree.
> After
> discussing with mhocko (cc'ed) it seems that in practice everything
> below COSTLY_ORDER which are not GFP_NORETRY will never fail. But
> this
> semantic is not the same as GFP_NOFAIL. E.g. nothing guarantees that
> this will stay like that in the future?
>
Actually, going back to the code with coffee: it's the fact we have
mempools, with direct reclaim that guarantee this.
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2017-05-11 13:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 16:47 [GIT PULL] Please pull NFS client fixes for 4.12 Trond Myklebust
2017-05-10 16:47 ` Trond Myklebust
2017-05-10 20:06 ` Linus Torvalds
2017-05-11 7:53 ` Nikolay Borisov
2017-05-11 7:59 ` Michal Hocko
2017-05-11 12:16 ` Trond Myklebust
2017-05-11 12:16 ` Trond Myklebust
2017-05-11 12:26 ` Michal Hocko
2017-05-11 12:45 ` Trond Myklebust
2017-05-11 12:45 ` Trond Myklebust
2017-05-11 12:56 ` Michal Hocko
2017-05-11 13:10 ` Trond Myklebust
2017-05-11 13:10 ` Trond Myklebust
2017-05-11 13:27 ` Michal Hocko
2017-05-16 15:15 ` Jonathan Corbet
2017-05-11 13:41 ` Trond Myklebust [this message]
2017-05-11 13:41 ` Trond Myklebust
2017-05-11 13:54 ` Michal Hocko
-- strict thread matches above, loose matches on Subject: below --
2017-06-28 14:19 Trond Myklebust
2017-06-28 14:19 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494510068.6968.0.camel@primarydata.com \
--to=trondmy@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=n.borisov.lkml@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.