From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] e1000e: Don't return uninitialized stats
Date: Fri, 19 May 2017 01:16:51 -0700 [thread overview]
Message-ID: <1495181811.2376.0.camel@intel.com> (raw)
In-Reply-To: <20170518.104614.1739169308591707817.davem@davemloft.net>
On Thu, 2017-05-18 at 10:46 -0400, David Miller wrote:
> From: Benjamin Poirier <bpoirier@suse.com>
> Date: Wed, 17 May 2017 16:24:13 -0400
>
> > Some statistics passed to ethtool are garbage because
> > e1000e_get_stats64()
> > doesn't write them, for example: tx_heartbeat_errors. This leaks kernel
> > memory to userspace and confuses users.
> >
> > Do like ixgbe and use dev_get_stats() which first zeroes out
> > rtnl_link_stats64.
> >
> > Fixes: 5944701df90d ("net: remove useless memset's in drivers
> > get_stats64")
> > Reported-by: Stefan Priebe <s.priebe@profihost.ag>
> > Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
>
> Jeff, please be sure to pick this up, thanks.
Yep, I have it in my tree, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170519/af01001c/attachment.asc>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>, bpoirier@suse.com
Cc: s.priebe@profihost.ag, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, pmenzel@molgen.mpg.de,
sasha.neftin@intel.com, aaron.f.brown@intel.com,
stephen@networkplumber.org
Subject: Re: [PATCH v2] e1000e: Don't return uninitialized stats
Date: Fri, 19 May 2017 01:16:51 -0700 [thread overview]
Message-ID: <1495181811.2376.0.camel@intel.com> (raw)
In-Reply-To: <20170518.104614.1739169308591707817.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
On Thu, 2017-05-18 at 10:46 -0400, David Miller wrote:
> From: Benjamin Poirier <bpoirier@suse.com>
> Date: Wed, 17 May 2017 16:24:13 -0400
>
> > Some statistics passed to ethtool are garbage because
> > e1000e_get_stats64()
> > doesn't write them, for example: tx_heartbeat_errors. This leaks kernel
> > memory to userspace and confuses users.
> >
> > Do like ixgbe and use dev_get_stats() which first zeroes out
> > rtnl_link_stats64.
> >
> > Fixes: 5944701df90d ("net: remove useless memset's in drivers
> > get_stats64")
> > Reported-by: Stefan Priebe <s.priebe@profihost.ag>
> > Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
>
> Jeff, please be sure to pick this up, thanks.
Yep, I have it in my tree, thanks.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-05-19 8:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:20 [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats Benjamin Poirier
2017-04-21 21:20 ` Benjamin Poirier
2017-04-21 21:20 ` [Intel-wired-lan] [PATCH 2/2] igb: Remove useless argument Benjamin Poirier
2017-04-21 21:20 ` Benjamin Poirier
[not found] ` <630A6B92B7EDEB45A87E20D3D286660171182EED@hasmsx109.ger.corp.intel.com>
2017-04-24 8:17 ` [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats Neftin, Sasha
2017-04-24 8:17 ` Neftin, Sasha
2017-04-24 19:10 ` Benjamin Poirier
2017-04-24 19:10 ` Benjamin Poirier
2017-04-25 7:10 ` Brown, Aaron F
2017-04-25 7:10 ` Brown, Aaron F
2017-04-25 9:07 ` Jeff Kirsher
2017-04-25 9:07 ` Jeff Kirsher
2017-04-25 17:54 ` Stephen Hemminger
2017-04-25 18:44 ` Benjamin Poirier
2017-04-25 18:44 ` Benjamin Poirier
2017-04-25 17:54 ` Benjamin Poirier
2017-04-25 17:54 ` Benjamin Poirier
2017-05-17 20:24 ` [Intel-wired-lan] [PATCH v2] " Benjamin Poirier
2017-05-17 20:24 ` Benjamin Poirier
2017-05-18 14:46 ` [Intel-wired-lan] " David Miller
2017-05-18 14:46 ` David Miller
2017-05-19 8:16 ` Jeff Kirsher [this message]
2017-05-19 8:16 ` Jeff Kirsher
2017-05-19 21:12 ` [Intel-wired-lan] " Brown, Aaron F
2017-05-19 21:12 ` Brown, Aaron F
2017-04-24 8:23 ` [Intel-wired-lan] [PATCH 1/2] " Paul Menzel
2017-04-24 8:23 ` Paul Menzel
2017-04-24 19:01 ` Benjamin Poirier
2017-04-24 19:01 ` Benjamin Poirier
2017-04-24 19:15 ` David Miller
2017-04-24 19:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495181811.2376.0.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.