Re: [PATCH v2 4/5] drm/i915/gvt: Dmabuf support for GVT-g

[Gerd Hoffmann <kraxel@redhat.com>]

> +/**
> + * Ioctl to query plane info or create dma-buf
> + */
> +#define INTEL_VGPU_QUERY_DMABUF		0
> +#define INTEL_VGPU_GENERATE_DMABUF	1

This should use _IO* #defines.

> +struct intel_vgpu_dmabuf {
> +	__u32 plane_id;
> +	/* out */
> +	__u32 fd;
> +	__u32 drm_format;
> +	__u32 width;
> +	__u32 height;
> +	__u32 stride;
> +	__u32 start;
> +	__u32 x_pos;
> +	__u32 y_pos;
> +	__u32 size;
> +	__u32 tiled;

I'd suggest to drop tiled, and add drm_format_mod (for
fourcc_mod_code()) instead.

You can also move intel_vgpu_plane_info to this place and just use it as
sub-struct for intel_vgpu_dmabuf.

cheers,
  Gerd