[PATCH] libmultipath: add comment about resuming

* [PATCH] libmultipath: add comment about resuming
@ 2017-05-18 21:37 Benjamin Marzinski
  2017-05-22 11:13 ` Martin Wilck
  0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Marzinski @ 2017-05-18 21:37 UTC (permalink / raw)
  To: device-mapper development; +Cc: Martin Wilck

The reason for the second resume in my commit "libmultipath: fix
suspended devs from failed reloads" is not obvious from the multipath
code, so add a comment.

Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
 libmultipath/devmapper.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
index 69b634b..ee83e0f 100644
--- a/libmultipath/devmapper.c
+++ b/libmultipath/devmapper.c
@@ -399,6 +399,9 @@ int dm_addmap_reload(struct multipath *mpp, char *params, int flush)
 	if (r)
 		return r;
 
+	/* If the resume failed, dm will leave the device suspended, and
+ 	 * drop the new table, so doing a second resume will try using
+ 	 * the original table */
 	if (dm_is_suspended(mpp->alias))
 		dm_simplecmd(DM_DEVICE_RESUME, mpp->alias, !flush, 1,
 			     udev_flags, 0);
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread