All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Colin Walters <walters-gPq2gbYjIk8dnm+yROfE0A@public.gmane.org>,
	Djalal Harouni <tixxdz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Cc: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	trondmy-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org,
	Miklos Szeredi <mszeredi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Alexander Viro
	<viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
	Linux FS Devel
	<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"open list:CONTROL GROUP (CGROUP)"
	<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC][PATCH 0/9] Make containers kernel objects
Date: Tue, 23 May 2017 11:31:31 -0400	[thread overview]
Message-ID: <1495553491.2946.16.camel@redhat.com> (raw)
In-Reply-To: <1495551292.2742620.985957224.3FCF254A-2RFepEojUI2N1INw9kWLP6GC3tUn3ZHUQQ4Iyu8u01E@public.gmane.org>

On Tue, 2017-05-23 at 10:54 -0400, Colin Walters wrote:
> On Tue, May 23, 2017, at 10:30 AM, Djalal Harouni wrote:
> > 
> > Maybe it depends on the cases, a general approach can be too difficult
> > to handle especially from the security point. Maybe it is better to
> > identify what operations need what context, and a userspace
> > service/proxy can act using kthreadd with the right context... at
> > least the shift to this model has been done for years now in the
> > mobile industry.
> 
> Why not drop the upcall model in favor of having userspace
> monitor events via a (more efficient) protocol and react to them on its own?
> It's just generally more flexible and avoids all of those issues like
> replicating the seccomp configuration, etc.
> 
> Something like inotify/signalfd could be a precedent around having a read()/poll()able
> fd.  /proc/keys-requests ?
> 
> Then if you create a new user namespace, and open /proc/keys-requests, the
> kernel will always write to that instead of calling /sbin/request-key.

Case in point:

nfsdcltrack was originally nfsdcld, a long running daemon that used
rpc_pipefs to talk to the kernel. That meant that you had to make sure
it gets enabled by systemd (or sysvinit, etc). If it dies, then you also
want to ensure that it gets restarted lest the kernel server hang,
etc...

It was pretty universally hated, as it was just one more daemon that you
needed to run to work a proper nfs server. So, I was encouraged to
switch it to a call_usermodehelper upcall and since then it has just
worked, as long as the binary is installed.

It's quite easy to say:

"You're doing it wrong. You just need to run all of these services as
long-running daemons."

But, that ignores the fact that handling long-running daemons for
infrequently used upcalls is actually quite painful to manage in
practice.

-- 
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@redhat.com>
To: Colin Walters <walters@verbum.org>,
	Djalal Harouni <tixxdz@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Cc: David Howells <dhowells@redhat.com>,
	trondmy@primarydata.com, Miklos Szeredi <mszeredi@redhat.com>,
	linux-nfs@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>
Subject: Re: [RFC][PATCH 0/9] Make containers kernel objects
Date: Tue, 23 May 2017 11:31:31 -0400	[thread overview]
Message-ID: <1495553491.2946.16.camel@redhat.com> (raw)
In-Reply-To: <1495551292.2742620.985957224.3FCF254A@webmail.messagingengine.com>

On Tue, 2017-05-23 at 10:54 -0400, Colin Walters wrote:
> On Tue, May 23, 2017, at 10:30 AM, Djalal Harouni wrote:
> > 
> > Maybe it depends on the cases, a general approach can be too difficult
> > to handle especially from the security point. Maybe it is better to
> > identify what operations need what context, and a userspace
> > service/proxy can act using kthreadd with the right context... at
> > least the shift to this model has been done for years now in the
> > mobile industry.
> 
> Why not drop the upcall model in favor of having userspace
> monitor events via a (more efficient) protocol and react to them on its own?
> It's just generally more flexible and avoids all of those issues like
> replicating the seccomp configuration, etc.
> 
> Something like inotify/signalfd could be a precedent around having a read()/poll()able
> fd.  /proc/keys-requests ?
> 
> Then if you create a new user namespace, and open /proc/keys-requests, the
> kernel will always write to that instead of calling /sbin/request-key.

Case in point:

nfsdcltrack was originally nfsdcld, a long running daemon that used
rpc_pipefs to talk to the kernel. That meant that you had to make sure
it gets enabled by systemd (or sysvinit, etc). If it dies, then you also
want to ensure that it gets restarted lest the kernel server hang,
etc...

It was pretty universally hated, as it was just one more daemon that you
needed to run to work a proper nfs server. So, I was encouraged to
switch it to a call_usermodehelper upcall and since then it has just
worked, as long as the binary is installed.

It's quite easy to say:

"You're doing it wrong. You just need to run all of these services as
long-running daemons."

But, that ignores the fact that handling long-running daemons for
infrequently used upcalls is actually quite painful to manage in
practice.

-- 
Jeff Layton <jlayton@redhat.com>

  parent reply	other threads:[~2017-05-23 15:31 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22 16:22 [RFC][PATCH 0/9] Make containers kernel objects David Howells
2017-05-22 16:22 ` David Howells
2017-05-22 16:22 ` [PATCH 1/9] containers: Rename linux/container.h to linux/container_dev.h David Howells
2017-05-22 16:22 ` [PATCH 2/9] Implement containers as kernel objects David Howells
     [not found]   ` <149547016213.10599.1969443294414531853.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-08-14  5:47     ` Richard Guy Briggs
2017-08-14  5:47     ` Richard Guy Briggs
2017-08-14  5:47       ` Richard Guy Briggs
     [not found]       ` <20170814054711.GB29957-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org>
2017-08-16 22:21         ` Paul Moore
2017-08-16 22:21       ` Paul Moore
2017-08-16 22:21         ` Paul Moore
2017-08-16 22:21         ` Paul Moore
     [not found]         ` <CAHC9VhRgPRa7KeMt8G700aeFvqVYc0gMx__82K31TYY6oQQqTw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-18  8:03           ` Richard Guy Briggs
2017-08-18  8:03           ` Richard Guy Briggs
2017-08-18  8:03             ` Richard Guy Briggs
     [not found]             ` <20170818080300.GQ7187-bcJWsdo4jJjeVoXN4CMphl7TgLCtbB0G@public.gmane.org>
2017-09-06 14:03               ` Serge E. Hallyn
2017-09-06 14:03               ` Serge E. Hallyn
2017-09-06 14:03                 ` Serge E. Hallyn
     [not found]                 ` <20170906140341.GA8729-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2017-09-14  5:47                   ` Richard Guy Briggs
2017-09-14  5:47                     ` Richard Guy Briggs
2017-09-14  5:47                   ` Richard Guy Briggs
2017-09-08 20:02               ` Paul Moore
2017-09-08 20:02             ` Paul Moore
2017-05-22 16:23 ` [PATCH 5/9] Open a socket inside a container David Howells
2017-05-22 16:23 ` [PATCH 6/9] Allow fs syscall dfd arguments to take a container fd David Howells
2017-05-22 16:23 ` [PATCH 7/9] Make fsopen() able to initiate mounting into a container David Howells
2017-05-22 16:23 ` [PATCH 9/9] Sample program for driving container objects David Howells
     [not found] ` <149547014649.10599.12025037906646164347.stgit-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-22 16:22   ` [PATCH 3/9] Provide /proc/containers David Howells
2017-05-22 16:22     ` David Howells
2017-05-22 16:22   ` [PATCH 4/9] Allow processes to be forked and upcalled into a container David Howells
2017-05-22 16:22     ` David Howells
2017-05-22 16:23   ` [PATCH 8/9] Honour CONTAINER_NEW_EMPTY_FS_NS David Howells
2017-05-22 16:23     ` David Howells
2017-05-22 16:53   ` [RFC][PATCH 0/9] Make containers kernel objects James Bottomley
2017-05-22 16:53     ` James Bottomley
     [not found]     ` <1495472039.2757.19.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-05-22 17:14       ` Aleksa Sarai
2017-05-22 17:14       ` Aleksa Sarai
2017-05-22 17:14         ` Aleksa Sarai
2017-05-23 14:53         ` David Howells
     [not found]           ` <2446.1495551216-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-23 14:56             ` Eric W. Biederman
2017-05-23 14:56               ` Eric W. Biederman
2017-05-23 14:56             ` Eric W. Biederman
     [not found]           ` <87zie3mxkc.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-23 15:14             ` David Howells
2017-05-23 15:14             ` David Howells
2017-05-23 15:14               ` David Howells
     [not found]               ` <2961.1495552481-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-23 15:17                 ` Eric W. Biederman
2017-05-23 15:17                   ` Eric W. Biederman
     [not found]                   ` <87bmqjmwl5.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-23 15:44                     ` James Bottomley
2017-05-23 15:44                       ` James Bottomley
2017-05-23 15:44                     ` James Bottomley
     [not found]                   ` <1495554267.27369.9.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-05-23 16:36                     ` David Howells
2017-05-23 16:36                       ` David Howells
     [not found]                       ` <3860.1495557363-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-24  8:26                         ` Eric W. Biederman
2017-05-24  8:26                           ` Eric W. Biederman
     [not found]                           ` <87k256ek3e.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-24  9:16                             ` Ian Kent
2017-05-24  9:16                             ` Ian Kent
2017-05-24  9:16                               ` Ian Kent
2017-05-22 17:27       ` Jessica Frazelle
2017-05-22 17:27       ` Jessica Frazelle
2017-05-22 17:27         ` Jessica Frazelle
2017-05-22 18:34       ` Jeff Layton
2017-05-22 18:34         ` Jeff Layton
     [not found]         ` <1495478092.2816.17.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-22 19:21           ` James Bottomley
2017-05-22 19:21             ` James Bottomley
     [not found]             ` <1495480860.9050.18.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2017-05-22 22:14               ` Jeff Layton
2017-05-23 10:35               ` Ian Kent
2017-05-23 10:35               ` Ian Kent
2017-05-23 10:35                 ` Ian Kent
2017-05-22 22:14             ` Jeff Layton
2017-05-22 19:21           ` James Bottomley
2017-05-22 18:34       ` Jeff Layton
2017-05-23  9:38       ` Ian Kent
2017-05-23  9:38         ` Ian Kent
2017-05-23  9:38         ` Ian Kent
2017-05-23  9:38       ` Ian Kent
2017-05-23 13:52       ` David Howells
2017-05-23 13:52       ` David Howells
2017-05-23 13:52         ` David Howells
     [not found]         ` <32556.1495547529-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-23 15:02           ` James Bottomley
2017-05-23 15:02             ` James Bottomley
2017-05-23 15:02           ` James Bottomley
2017-05-23 15:23           ` Eric W. Biederman
2017-05-23 15:23         ` Eric W. Biederman
     [not found]     ` <f167feeb-e653-12e3-eec8-24162f7f7c07-l3A5Bk7waGM@public.gmane.org>
2017-05-23 14:53       ` David Howells
2017-05-22 17:11   ` Jessica Frazelle
2017-05-22 17:11     ` Jessica Frazelle
2017-05-22 19:04   ` Eric W. Biederman
2017-05-22 19:04     ` Eric W. Biederman
     [not found]     ` <87lgpoww67.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-22 22:22       ` Jeff Layton
2017-05-22 22:22         ` Jeff Layton
     [not found]         ` <1495491733.25946.3.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-23 12:54           ` Eric W. Biederman
2017-05-23 12:54             ` Eric W. Biederman
     [not found]             ` <874lwbraxh.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2017-05-23 14:27               ` Jeff Layton
2017-05-23 14:27                 ` Jeff Layton
2017-05-23 14:30               ` Djalal Harouni
2017-05-23 14:30                 ` Djalal Harouni
     [not found]                 ` <CAEiveUcbmm5m4=11ZppxAWppeoFWUBFpLC7dAZRuBCTFHR548g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-23 14:54                   ` Colin Walters
2017-05-23 14:54                     ` Colin Walters
2017-05-23 15:30                     ` David Howells
     [not found]                     ` <1495551292.2742620.985957224.3FCF254A-2RFepEojUI2N1INw9kWLP6GC3tUn3ZHUQQ4Iyu8u01E@public.gmane.org>
2017-05-23 15:31                       ` Jeff Layton [this message]
2017-05-23 15:31                         ` Jeff Layton
     [not found]                         ` <1495553491.2946.16.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-23 15:35                           ` Colin Walters
2017-05-23 15:35                             ` Colin Walters
2017-05-23 14:23           ` Djalal Harouni
2017-05-23 14:23             ` Djalal Harouni
2017-05-23 16:13     ` David Howells
2017-05-23 16:13       ` David Howells
2017-05-27 17:45     ` Trond Myklebust
2017-05-27 17:45       ` Trond Myklebust
     [not found]       ` <1495907132.4591.3.camel-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
2017-05-27 19:10         ` James Bottomley
2017-05-27 19:10           ` James Bottomley
2017-05-30  1:03         ` Ian Kent
2017-05-30  1:03           ` Ian Kent
2017-05-23 10:09   ` Ian Kent
2017-05-23 10:09     ` Ian Kent
2017-05-23 15:33   ` Eric W. Biederman
2017-05-23 15:33     ` Eric W. Biederman
     [not found] ` <CAEk6tEyjk4=rHfsJUZ7dYPpdSa-=QX6QAm8ni8-ySpHmjUMwTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-23 15:12   ` David Howells
2017-05-23 15:12     ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495553491.2946.16.camel@redhat.com \
    --to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mszeredi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=tixxdz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=trondmy-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    --cc=walters-gPq2gbYjIk8dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.