All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug
Date: Mon, 29 May 2017 15:15:15 +0000	[thread overview]
Message-ID: <1496070914.7990.19.camel@synopsys.com> (raw)
In-Reply-To: <1495954328-28736-8-git-send-email-noamca@mellanox.com>

Hi Noam,

On Sun, 2017-05-28@09:52 +0300, Noam Camus wrote:
> From: Noam Camus <noamca at mellanox.com>
> 
> This counter represents threshold for consecutive stall that which
> trigger HW threads scheduling.
> When this feature is enabled low values of this counter cause
> downgrade in performance and in the worst case even a livelock.
> 
> Remove those couple of lines and resort to HW reset value i.e.
> this feature is disabled (.sten field equals 0).

Looks like you made a change I was asking for here.
But there's no mention of the change so it's easy to not note
that change. Not critical but please add a changelog next time?
even if it's only a comment message that was modified since
the previous revision.

Otherwise...

Reviewed-by: Alexey Brodkin <abrodkin at synopsys.com>

> Signed-off-by: Noam Camus <noamca at mellanox.com>
> ---
> ?arch/arc/plat-eznps/mtm.c |????2 --
> ?1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arc/plat-eznps/mtm.c b/arch/arc/plat-eznps/mtm.c
> index aaaaffd..e0cb36b 100644
> --- a/arch/arc/plat-eznps/mtm.c
> +++ b/arch/arc/plat-eznps/mtm.c
> @@ -119,8 +119,6 @@ void mtm_enable_core(unsigned int cpu)
> ?	mt_ctrl.value = 0;
> ?	mt_ctrl.hsen = 1;
> ?	mt_ctrl.hs_cnt = MT_CTRL_HS_CNT;
> -	mt_ctrl.sten = 1;
> -	mt_ctrl.st_cnt = MT_CTRL_ST_CNT;
> ?	mt_ctrl.mten = 1;
> ?	write_aux_reg(CTOP_AUX_MT_CTRL, mt_ctrl.value);
> ?

WARNING: multiple messages have this Message-ID (diff)
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "noamca@mellanox.com" <noamca@mellanox.com>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug
Date: Mon, 29 May 2017 15:15:15 +0000	[thread overview]
Message-ID: <1496070914.7990.19.camel@synopsys.com> (raw)
In-Reply-To: <1495954328-28736-8-git-send-email-noamca@mellanox.com>

Hi Noam,

On Sun, 2017-05-28 at 09:52 +0300, Noam Camus wrote:
> From: Noam Camus <noamca@mellanox.com>
> 
> This counter represents threshold for consecutive stall that which
> trigger HW threads scheduling.
> When this feature is enabled low values of this counter cause
> downgrade in performance and in the worst case even a livelock.
> 
> Remove those couple of lines and resort to HW reset value i.e.
> this feature is disabled (.sten field equals 0).

Looks like you made a change I was asking for here.
But there's no mention of the change so it's easy to not note
that change. Not critical but please add a changelog next time 
even if it's only a comment message that was modified since
the previous revision.

Otherwise...

Reviewed-by: Alexey Brodkin <abrodkin@synopsys.com>

> Signed-off-by: Noam Camus <noamca@mellanox.com>
> ---
>  arch/arc/plat-eznps/mtm.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arc/plat-eznps/mtm.c b/arch/arc/plat-eznps/mtm.c
> index aaaaffd..e0cb36b 100644
> --- a/arch/arc/plat-eznps/mtm.c
> +++ b/arch/arc/plat-eznps/mtm.c
> @@ -119,8 +119,6 @@ void mtm_enable_core(unsigned int cpu)
>  	mt_ctrl.value = 0;
>  	mt_ctrl.hsen = 1;
>  	mt_ctrl.hs_cnt = MT_CTRL_HS_CNT;
> -	mt_ctrl.sten = 1;
> -	mt_ctrl.st_cnt = MT_CTRL_ST_CNT;
>  	mt_ctrl.mten = 1;
>  	write_aux_reg(CTOP_AUX_MT_CTRL, mt_ctrl.value);
>  

  reply	other threads:[~2017-05-29 15:15 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28  6:51 [PATCH v2 00/11] ARC plat-eznps upstream cont Noam Camus
2017-05-28  6:51 ` Noam Camus
2017-05-28  6:51 ` [PATCH v2 01/11] ARC: set level of log per CPU during boot to be debug level Noam Camus
2017-05-28  6:51   ` Noam Camus
2017-05-28  6:51 ` [PATCH v2 02/11] ARC: send ipi to all cpus sharing task mm in case of page fault Noam Camus
2017-05-28  6:51   ` Noam Camus
2017-05-30 16:40   ` Vineet Gupta
2017-05-30 16:40     ` Vineet Gupta
2017-05-28  6:52 ` [PATCH v2 03/11] ARC: typo fix in mm/fault.c Noam Camus
2017-05-28  6:52   ` Noam Camus
2017-05-28  6:52 ` [PATCH v2 04/11] ARC: typos fix in kernel/entry-compact.S Noam Camus
2017-05-28  6:52   ` Noam Camus
2017-05-28  6:52 ` [PATCH v2 05/11] ARC: [plat-eznps] typo fix at Kconfig Noam Camus
2017-05-28  6:52   ` Noam Camus
2017-05-28  6:52 ` [PATCH v2 06/11] ARC: [plat-eznps] Fix TLB Errata Noam Camus
2017-05-28  6:52   ` Noam Camus
2017-05-28  6:52 ` [PATCH v2 07/11] ARC: [plat-eznps] disabled stall counter due to a HW bug Noam Camus
2017-05-28  6:52   ` Noam Camus
2017-05-29 15:15   ` Alexey Brodkin [this message]
2017-05-29 15:15     ` Alexey Brodkin
2017-05-28  6:52 ` [PATCH v2 08/11] ARC: [plat-eznps] spinlock aware for MTM Noam Camus
2017-05-28  6:52   ` Noam Camus
2017-06-02 18:36   ` Vineet Gupta
2017-06-02 18:36     ` Vineet Gupta
2017-06-04  6:11     ` Noam Camus
2017-06-04  6:11       ` Noam Camus
2017-05-28  6:52 ` [PATCH v2 09/11] ARC: [plat-eznps] use schd.wft instruction instead of sleep at idle task Noam Camus
2017-05-28  6:52   ` Noam Camus
2017-05-28  6:52 ` [PATCH v2 10/11] ARC: enable platform specific mem_service implementation Noam Camus
2017-05-28  6:52   ` Noam Camus
2017-05-28  6:52 ` [PATCH v2 11/11] ARC: [plat-eznps] Handle memory error as an exception Noam Camus
2017-05-28  6:52   ` Noam Camus
2017-06-02 19:04   ` Vineet Gupta
2017-06-02 19:04     ` Vineet Gupta
2017-06-04  6:10     ` Noam Camus
2017-06-04  6:10       ` Noam Camus
2017-06-06 22:10   ` Vineet Gupta
2017-06-06 22:10     ` Vineet Gupta
2017-06-07  6:07     ` Noam Camus
2017-06-07  6:07       ` Noam Camus
2017-06-07 11:14     ` Noam Camus
2017-06-07 11:14       ` Noam Camus
2017-06-07 16:15       ` Vineet Gupta
2017-06-07 16:15         ` Vineet Gupta
     [not found]         ` <AM5PR0502MB2996A1F4CFE1FE6AEB433A7DAAC80@AM5PR0502MB2996.eurprd05.prod.outlook.com>
     [not found]           ` <AM5PR0502MB2996FBD57D8591A42ED4A84CAAC90@AM5PR0502MB2996.eurprd05.prod.outlook.com>
2017-06-08 16:38             ` Vineet Gupta
2017-06-08 16:38               ` Vineet Gupta
     [not found]               ` <AM5PR0502MB299646D52F2A0AF3764CEC4BAAC90@AM5PR0502MB2996.eurprd05.prod.outlook.com>
2017-06-08 19:00                 ` Vineet Gupta
2017-06-08 19:00                   ` Vineet Gupta
     [not found]                   ` <AM5PR0502MB2996B6DA5530C4B37A7B1AF0AACE0@AM5PR0502MB2996.eurprd05.prod.outlook.com>
2017-06-12 17:40                     ` Vineet Gupta
2017-06-12 17:40                       ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496070914.7990.19.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.