From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Tina Zhang <tina.zhang@intel.com>, intel-gfx@lists.freedesktop.org
Cc: intel-gvt-dev@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Enable guest i915 full ppgtt functionality
Date: Tue, 30 May 2017 11:37:50 +0300 [thread overview]
Message-ID: <1496133470.3977.10.camel@linux.intel.com> (raw)
In-Reply-To: <1495441177-12451-1-git-send-email-tina.zhang@intel.com>
On ma, 2017-05-22 at 16:19 +0800, Tina Zhang wrote:
> Enable the guest i915 full ppgtt functionality when host can provide this
> capability. vgt_caps is introduced to guest i915 driver to get the vgpu
> capabilities from the device model. VGT_CPAS_FULL_PPGTT is one of the
> capabilities type to let guest i915 dirver know that the guest i915 full
> ppgtt is supported by device model.
>
> Changes since v1:
> - Use u32 instead of uint32_t (Joonas)
> - Move VGT_CAPS_FULL_PPGTT introduction to this patch and use #define
> instead of enum (Joonas)
> - Rewrite the vgpu full ppgtt capability checking logic. (Joonas)
> - Some coding style refine. (Joonas)
>
> Changes since v2:
> - Divide the whole patch set into two separate patch series, with one
> patch in i915 side to check guest i915 full ppgtt capability and enable
> it when this capability is supported by the device model, and the other
> one in gvt side which fixs the blocking issue and enables the device
> model to provide the capability to guest. And this patch focuses on guest
> i915 side. (Joonas)
> - Change the title from "introduce vgt_caps to pvinfo" to
> "Enable guest i915 full ppgtt functionality". (Tina)
>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Tina Zhang <tina.zhang@intel.com>
I just noticed there is INTEL_VGT_IF_VERSION when I was looking to make
sure that vgt_if is zeroed. Neither the version is incremented nor do I
see VGT_PVINFO_PAGE getting zeroed.
What measures are in place to make sure running a new i915 under older
DOM0 won't result in corruption?
The dependencies between i915 and gvt are rather tricky, so we'd need
INTEL_VGT_IF_VERSION minor increment and also a one line change
(zeroing of the new caps register) from gvt code to the same patch,
otherwise bisecting will break.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-30 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 8:19 [PATCH v3] drm/i915: Enable guest i915 full ppgtt functionality Tina Zhang
2017-05-22 8:42 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-05-30 8:37 ` Joonas Lahtinen [this message]
2017-05-31 1:10 ` [PATCH v3] " Zhang, Tina
2017-05-31 2:49 ` Zhenyu Wang
2017-06-02 10:30 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496133470.3977.10.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=tina.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.