From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/i915: Enable guest i915 full ppgtt functionality
Date: Fri, 02 Jun 2017 13:30:41 +0300 [thread overview]
Message-ID: <1496399441.3795.7.camel@linux.intel.com> (raw)
In-Reply-To: <20170531024932.d225rdlz6cavejfj@zhen-hp.sh.intel.com>
On ke, 2017-05-31 at 10:49 +0800, Zhenyu Wang wrote:
> On 2017.05.30 11:37:50 +0300, Joonas Lahtinen wrote:
> >
> > I just noticed there is INTEL_VGT_IF_VERSION when I was looking to make
> > sure that vgt_if is zeroed. Neither the version is incremented nor do I
> > see VGT_PVINFO_PAGE getting zeroed.
> >
> > What measures are in place to make sure running a new i915 under older
> > DOM0 won't result in corruption?
> >
> > The dependencies between i915 and gvt are rather tricky, so we'd need
> > INTEL_VGT_IF_VERSION minor increment and also a one line change
> > (zeroing of the new caps register) from gvt code to the same patch,
> > otherwise bisecting will break.
> >
>
> That's unfortunate...We can't increment minor now as it would break
> older guest, need to fix guest pvinfo version compat check, and new caps
> field is kept as zero if not used, so now depend on that for compatibility.
Point of minor versions is to indicate no breaking, but to detect new
features.
But the damage has already been done, so it'd be worthwhile to document
this via a comment.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-06-02 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 8:19 [PATCH v3] drm/i915: Enable guest i915 full ppgtt functionality Tina Zhang
2017-05-22 8:42 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-05-30 8:37 ` [PATCH v3] " Joonas Lahtinen
2017-05-31 1:10 ` Zhang, Tina
2017-05-31 2:49 ` Zhenyu Wang
2017-06-02 10:30 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496399441.3795.7.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.