From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [Linux-ima-devel] [PATCH v2 4/5] keys, trusted: modify arguments of tpm_pcr_extend()
Date: Tue, 30 May 2017 12:06:01 +0000 [thread overview]
Message-ID: <1496145961.3841.537.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <d124bdbc-6a64-7761-47f5-1580979009bd@huawei.com>
On Tue, 2017-05-30 at 09:36 +0200, Roberto Sassu wrote:
> On 5/30/2017 5:35 AM, Mimi Zohar wrote:
> > On Fri, 2017-05-05 at 16:21 +0200, Roberto Sassu wrote:
> >> pcrlock() has been modified to pass the correct arguments
> >> to tpm_pcr_extend(): the pointer of a tpm2_digest structure containing
> >> a random value generated by tpm_get_random() and the size of the array (1).
> >
> > If the number of arguments is wrong, that means the patch that
> > introduced the change is not bi-sect safe. (This comment is
> > applicable to patch 5/5 too.)
>
> Jarkko (the TPM driver maintainer) asked me to not introduce
> a new function to pass multiple digests, but to modify
> the parameters of tpm_pcr_extend().
Since struct tpm2_digest is a static size, shouldn't we be able to
compute the number of digests?
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: zohar@linux.vnet.ibm.com (Mimi Zohar)
To: linux-security-module@vger.kernel.org
Subject: [Linux-ima-devel] [PATCH v2 4/5] keys, trusted: modify arguments of tpm_pcr_extend()
Date: Tue, 30 May 2017 08:06:01 -0400 [thread overview]
Message-ID: <1496145961.3841.537.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <d124bdbc-6a64-7761-47f5-1580979009bd@huawei.com>
On Tue, 2017-05-30 at 09:36 +0200, Roberto Sassu wrote:
> On 5/30/2017 5:35 AM, Mimi Zohar wrote:
> > On Fri, 2017-05-05 at 16:21 +0200, Roberto Sassu wrote:
> >> pcrlock() has been modified to pass the correct arguments
> >> to tpm_pcr_extend(): the pointer of a tpm2_digest structure containing
> >> a random value generated by tpm_get_random() and the size of the array (1).
> >
> > If the number of arguments is wrong, that means the patch that
> > introduced the change is not bi-sect safe. (This comment is
> > applicable to patch 5/5 too.)
>
> Jarkko (the TPM driver maintainer) asked me to not introduce
> a new function to pass multiple digests, but to modify
> the parameters of tpm_pcr_extend().
Since struct tpm2_digest is a static size, shouldn't we be able to
compute the number of digests?
Mimi
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Roberto Sassu <roberto.sassu@huawei.com>,
tpmdd-devel@lists.sourceforge.net
Cc: linux-ima-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-ima-devel] [PATCH v2 4/5] keys, trusted: modify arguments of tpm_pcr_extend()
Date: Tue, 30 May 2017 08:06:01 -0400 [thread overview]
Message-ID: <1496145961.3841.537.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <d124bdbc-6a64-7761-47f5-1580979009bd@huawei.com>
On Tue, 2017-05-30 at 09:36 +0200, Roberto Sassu wrote:
> On 5/30/2017 5:35 AM, Mimi Zohar wrote:
> > On Fri, 2017-05-05 at 16:21 +0200, Roberto Sassu wrote:
> >> pcrlock() has been modified to pass the correct arguments
> >> to tpm_pcr_extend(): the pointer of a tpm2_digest structure containing
> >> a random value generated by tpm_get_random() and the size of the array (1).
> >
> > If the number of arguments is wrong, that means the patch that
> > introduced the change is not bi-sect safe. (This comment is
> > applicable to patch 5/5 too.)
>
> Jarkko (the TPM driver maintainer) asked me to not introduce
> a new function to pass multiple digests, but to modify
> the parameters of tpm_pcr_extend().
Since struct tpm2_digest is a static size, shouldn't we be able to
compute the number of digests?
Mimi
next prev parent reply other threads:[~2017-05-30 12:06 UTC|newest]
Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 14:21 [PATCH v2 0/5] Updated API for TPM 2.0 PCR extend Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-05 14:21 ` [PATCH v2 1/5] tpm: introduce tpm_pcr_algorithms() Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-15 10:36 ` Jarkko Sakkinen
2017-05-15 10:36 ` Jarkko Sakkinen
2017-05-15 10:36 ` Jarkko Sakkinen
2017-05-15 13:18 ` Roberto Sassu
2017-05-15 13:18 ` Roberto Sassu
2017-05-15 13:18 ` Roberto Sassu
2017-05-15 13:18 ` Roberto Sassu
2017-05-17 8:42 ` Roberto Sassu
2017-05-17 8:42 ` Roberto Sassu
2017-05-17 8:42 ` Roberto Sassu
2017-05-17 8:42 ` Roberto Sassu
2017-05-20 13:18 ` Jarkko Sakkinen
2017-05-20 13:18 ` Jarkko Sakkinen
2017-05-20 13:18 ` Jarkko Sakkinen
2017-05-22 9:07 ` Roberto Sassu
2017-05-22 9:07 ` Roberto Sassu
2017-05-22 9:07 ` Roberto Sassu
2017-05-22 9:07 ` Roberto Sassu
2017-05-24 17:35 ` Jarkko Sakkinen
2017-05-24 17:35 ` Jarkko Sakkinen
2017-05-24 17:35 ` Jarkko Sakkinen
2017-05-30 8:44 ` Roberto Sassu
2017-05-30 8:44 ` Roberto Sassu
2017-05-30 8:44 ` Roberto Sassu
2017-05-30 8:44 ` Roberto Sassu
2017-05-31 11:39 ` Jarkko Sakkinen
2017-05-31 11:39 ` Jarkko Sakkinen
2017-05-31 11:39 ` Jarkko Sakkinen
2017-05-31 11:39 ` Jarkko Sakkinen
2017-05-20 13:00 ` Jarkko Sakkinen
2017-05-20 13:00 ` Jarkko Sakkinen
2017-05-20 13:00 ` Jarkko Sakkinen
2017-05-05 14:21 ` [PATCH v2 2/5] tpm: introduce tpm_pcr_algo_to_crypto() and tpm_pcr_algo_from_crypto() Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-15 11:16 ` Jarkko Sakkinen
2017-05-15 11:16 ` Jarkko Sakkinen
2017-05-15 11:16 ` Jarkko Sakkinen
2017-05-15 11:16 ` Jarkko Sakkinen
2017-05-15 14:22 ` Roberto Sassu
2017-05-15 14:22 ` Roberto Sassu
2017-05-15 14:22 ` Roberto Sassu
2017-05-15 14:22 ` Roberto Sassu
2017-05-20 13:22 ` Jarkko Sakkinen
2017-05-20 13:22 ` Jarkko Sakkinen
2017-05-20 13:22 ` Jarkko Sakkinen
2017-05-22 7:21 ` Roberto Sassu
2017-05-22 7:21 ` Roberto Sassu
2017-05-22 7:21 ` Roberto Sassu
2017-05-22 7:21 ` Roberto Sassu
2017-05-24 17:33 ` Jarkko Sakkinen
2017-05-24 17:33 ` Jarkko Sakkinen
2017-05-24 17:33 ` Jarkko Sakkinen
2017-05-24 20:25 ` Jarkko Sakkinen
2017-05-24 20:25 ` Jarkko Sakkinen
2017-05-24 20:25 ` Jarkko Sakkinen
2017-05-30 10:24 ` Roberto Sassu
2017-05-30 10:24 ` Roberto Sassu
2017-05-30 10:24 ` Roberto Sassu
2017-05-30 10:24 ` Roberto Sassu
2017-05-31 11:40 ` Jarkko Sakkinen
2017-05-31 11:40 ` Jarkko Sakkinen
2017-05-31 11:40 ` Jarkko Sakkinen
2017-05-05 14:21 ` [PATCH v2 3/5] tpm: pass multiple digests to tpm_pcr_extend() Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-30 3:29 ` [Linux-ima-devel] " Mimi Zohar
2017-05-30 3:29 ` Mimi Zohar
2017-05-30 3:29 ` Mimi Zohar
2017-05-30 3:29 ` Mimi Zohar
2017-05-30 7:28 ` Roberto Sassu
2017-05-30 7:28 ` Roberto Sassu
2017-05-30 7:28 ` Roberto Sassu
2017-05-30 7:28 ` Roberto Sassu
2017-05-30 11:25 ` Mimi Zohar
2017-05-30 11:25 ` Mimi Zohar
2017-05-30 11:25 ` Mimi Zohar
2017-05-30 13:25 ` Roberto Sassu
2017-05-30 13:25 ` Roberto Sassu
2017-05-30 13:25 ` Roberto Sassu
2017-05-30 13:25 ` Roberto Sassu
2017-05-05 14:21 ` [PATCH v2 4/5] keys, trusted: modify arguments of tpm_pcr_extend() Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-30 3:35 ` [Linux-ima-devel] " Mimi Zohar
2017-05-30 3:35 ` Mimi Zohar
2017-05-30 3:35 ` Mimi Zohar
2017-05-30 7:36 ` Roberto Sassu
2017-05-30 7:36 ` Roberto Sassu
2017-05-30 7:36 ` Roberto Sassu
2017-05-30 7:36 ` Roberto Sassu
2017-05-30 12:06 ` Mimi Zohar [this message]
2017-05-30 12:06 ` Mimi Zohar
2017-05-30 12:06 ` Mimi Zohar
2017-05-30 13:41 ` Roberto Sassu
2017-05-30 13:41 ` Roberto Sassu
2017-05-30 13:41 ` Roberto Sassu
2017-05-30 13:41 ` Roberto Sassu
2017-05-05 14:21 ` [PATCH v2 5/5] ima: " Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
2017-05-05 14:21 ` Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496145961.3841.537.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.