From: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Yanjun Zhu <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Honggang LI <honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings
Date: Thu, 01 Jun 2017 18:26:09 -0400 [thread overview]
Message-ID: <1496355969.7171.65.camel@redhat.com> (raw)
In-Reply-To: <92da39f0-2c7a-5039-234e-94da89d5eacb-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Fri, 2017-05-19 at 11:15 +0800, Yanjun Zhu wrote:
> >> Suggesting to remove kernel oops from commit log message, fix is
> trivial.
> > Please don't, they are useful.
> Can we explain this in commit log message?
>
> The patch "IB/IPoIB: Support acceleration options callbacks" makes
> ipoib_pirv different from netdev_priv.
I reworked the commit message considerably to resolve this issue, and
then applied the patch.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Doug Ledford <dledford@redhat.com>
To: Yanjun Zhu <yanjun.zhu@oracle.com>,
Leon Romanovsky <leon@kernel.org>,
Yuval Shaia <yuval.shaia@oracle.com>
Cc: Honggang LI <honli@redhat.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings
Date: Thu, 01 Jun 2017 18:26:09 -0400 [thread overview]
Message-ID: <1496355969.7171.65.camel@redhat.com> (raw)
In-Reply-To: <92da39f0-2c7a-5039-234e-94da89d5eacb@oracle.com>
On Fri, 2017-05-19 at 11:15 +0800, Yanjun Zhu wrote:
> >> Suggesting to remove kernel oops from commit log message, fix is
> trivial.
> > Please don't, they are useful.
> Can we explain this in commit log message?
>
> The patch "IB/IPoIB: Support acceleration options callbacks" makes
> ipoib_pirv different from netdev_priv.
I reworked the commit message considerably to resolve this issue, and
then applied the patch.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
next prev parent reply other threads:[~2017-06-01 22:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 12:14 [PATCH] IB/IPoIB: Replace netdev_priv with ipoib_priv for ipoib_get_link_ksettings Honggang LI
2017-05-11 12:14 ` Honggang LI
[not found] ` <1494504868-17204-1-git-send-email-honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-11 12:31 ` Yuval Shaia
2017-05-11 12:31 ` Yuval Shaia
2017-05-11 12:40 ` Leon Romanovsky
2017-05-11 12:40 ` Leon Romanovsky
[not found] ` <20170511124020.GH3616-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-19 3:15 ` Yanjun Zhu
2017-05-19 3:15 ` Yanjun Zhu
[not found] ` <92da39f0-2c7a-5039-234e-94da89d5eacb-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-05-19 3:58 ` Leon Romanovsky
2017-05-19 3:58 ` Leon Romanovsky
2017-06-01 22:26 ` Doug Ledford [this message]
2017-06-01 22:26 ` Doug Ledford
2017-05-19 2:42 ` Yanjun Zhu
2017-05-19 2:42 ` Yanjun Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496355969.7171.65.camel@redhat.com \
--to=dledford-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.