From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: backports@vger.kernel.org
Subject: Re: [PATCH] backport: handle change in netdevice destructor usage
Date: Mon, 12 Jun 2017 11:22:18 +0200 [thread overview]
Message-ID: <1497259338.18110.2.camel@sipsolutions.net> (raw)
In-Reply-To: <f5b49f6d-7a18-ddec-9d51-6a3194168fa2@broadcom.com> (sfid-20170612_111529_660251_6BD900C2)
On Mon, 2017-06-12 at 11:15 +0200, Arend van Spriel wrote:
> On 6/12/2017 11:11 AM, Johannes Berg wrote:
> > On Mon, 2017-06-12 at 10:06 +0100, Arend van Spriel wrote:
> > > This patch deals with changes made in struct net_device by commit
> > > cf124db566e6 ("net: Fix inconsistent teardown and release of
> > > private
> > > netdev state."). This only looks for instances that need
> > > free_netdev() call, ie. struct net_device::needs_free_netdev ==
> > > true.
> >
> > I think we may need to worry about more kernel versions than just
> > 4.12
> > here, since this stuff is getting backported, and then it would
> > cause
> > double-frees.
> >
> > I'm also considering simply removing the priv_destructor entirely
> > from
> > mac80211, but I guess this would still apply to other drivers.
>
> For current backports the only other driver is brcmfmac.
Right.
> So you don't
> need it in mac80211? Does that mean you move stuff to .ndo_uninit()?
No, just call more things explicitly and remove destructor usage
entirely. See the thread with davem?
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
next prev parent reply other threads:[~2017-06-12 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 9:06 [PATCH] backport: handle change in netdevice destructor usage Arend van Spriel
2017-06-12 9:11 ` Johannes Berg
2017-06-12 9:15 ` Arend van Spriel
2017-06-12 9:22 ` Johannes Berg [this message]
2017-06-13 20:59 ` Johannes Berg
2017-06-14 13:25 ` Arend van Spriel
2017-06-14 13:26 ` Johannes Berg
2017-06-14 17:28 ` Arend van Spriel
2017-06-14 20:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497259338.18110.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=backports@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.