Re: [PATCH] backport: handle change in netdevice destructor usage

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2017-06-14 at 15:25 +0200, Arend van Spriel wrote:
> On 13-06-17 22:59, Johannes Berg wrote:
> > On Mon, 2017-06-12 at 10:06 +0100, Arend van Spriel wrote:
> > > This patch deals with changes made in struct net_device by commit
> > > cf124db566e6 ("net: Fix inconsistent teardown and release of
> > > private
> > > netdev state."). This only looks for instances that need
> > > free_netdev() call, ie. struct net_device::needs_free_netdev ==
> > > true.
> > 
> > Come to think of it, isn't this missing the part where we now call
> > priv_destructor when registering fails or something?
> 
> Ah. I should have studied the patch better to see what behavioral
> changes the commit imposed. 

Not sure, tbh. I just think there are issues there.

> So are you still considering the patch
> despite the likely backport of commit cf124db566e6. I can do my
> homework better and resubmit if needed.

Yeah I still think this backports patch makes sense, since I'm not sure
I want to fix mac80211 that way (the bits in unregistering multiple
netdevs are awkward) and brcmfmac would still need it.

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in