From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rick Altherr <raltherr@google.com>, Arnd Bergmann <arnd@arndb.de>
Cc: Greg KH <gregkh@linuxfoundation.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Robert Lippert <roblip@gmail.com>
Subject: Re: [PATCH] drivers/misc: add Aspeed LPC snoop driver
Date: Tue, 13 Jun 2017 09:05:56 +1000 [thread overview]
Message-ID: <1497308756.2897.4.camel@kernel.crashing.org> (raw)
In-Reply-To: <1497308676.2897.3.camel@kernel.crashing.org>
On Tue, 2017-06-13 at 09:04 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2017-06-09 at 15:16 -0700, Rick Altherr wrote:
> > I've only seen the Aspeed eSPI hardware. It implements demux of the
> > eSPI channels in the hardware and provides separate DMA descriptors
> > for each. It looks nothing like LPC at any level.
>
> Sort of... it does have a kind of memory mapped IO channel which
> *could* be aliased to the LPC IO space though afaik, Aspeed just
> aliases it to their internal bus which is a recipe for disaster when it
> comes to security, so one should just disable it.
>
> It's unfortunate, I don't see how you can access things like the legacy
> UART, RTC etc... via eSPI. It looks like yet another crackpot invented
> for SMM BIOS to get in the way and emulate everything. Yuck.
That said I may just not be understanding the spec completely ... I
noticed in the SuperIO bits in the aspeed doc that there are fixed
addresses for some devices on eSPI so ... including the UART.
Ben.
prev parent reply other threads:[~2017-06-12 23:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 21:53 [PATCH] drivers/misc: add Aspeed LPC snoop driver Robert Lippert
2017-06-05 3:25 ` Joel Stanley
2017-06-05 19:46 ` Rob Lippert
2017-06-06 2:16 ` Joel Stanley
2017-06-06 5:35 ` Greg KH
2017-06-06 8:07 ` Arnd Bergmann
2017-06-06 16:51 ` Rick Altherr
2017-06-09 19:00 ` Arnd Bergmann
2017-06-09 22:16 ` Rick Altherr
2017-06-12 23:04 ` Benjamin Herrenschmidt
2017-06-12 23:05 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497308756.2897.4.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=openbmc@lists.ozlabs.org \
--cc=raltherr@google.com \
--cc=roblip@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.