All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Rob Lippert <rlippert@google.com>,
	Robert Lippert <roblip@gmail.com>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] drivers/misc: add Aspeed LPC snoop driver
Date: Tue, 6 Jun 2017 07:35:31 +0200	[thread overview]
Message-ID: <20170606053531.GA21809@kroah.com> (raw)
In-Reply-To: <CACPK8XfKmm9ZUesgNJsL=MeruOfLzi-j6Dfjb2Be1zfdYn7XcQ@mail.gmail.com>

On Tue, Jun 06, 2017 at 11:46:56AM +0930, Joel Stanley wrote:
> On Tue, Jun 6, 2017 at 5:16 AM, Rob Lippert <rlippert@google.com> wrote:
> > On Sun, Jun 4, 2017 at 8:25 PM, Joel Stanley <joel@jms.id.au> wrote:
> >> Hello Rob,
> >>
> >> On Sat, Jun 3, 2017 at 7:23 AM, Robert Lippert <roblip@gmail.com> wrote:
> >>> This driver enables the LPC snoop hardware on the ASPEED BMC
> >>> which generates an interrupt upon every write to an I/O port
> >>> by the host.
> >>>
> >>> This is typically used to monitor BIOS boot progress by listening
> >>> to well-known debug port 80h.
> >>>
> >>> The functionality in this commit just saves all snooped values
> >>> to a circular 2K buffer in the kernel, subsequent commits can
> >>> act on the values to do things with them.
> >>
> >> Reviewed-by: Joel Stanley <joel@jms.id.au>
> >>
> >> The driver looks okay to me. I can stage it in the OpenBMC kernel tree
> >> while we get it reviewed upstream.
> >>
> >> Can you re-send to the upstream mailing lists so it gets reviewed
> >> there. You will need to include a device tree binding document too
> >> (something to put in Documentation/devicetree/bindings/).
> >
> > What is the proper upstream mailing list for this?  patman didn't list
> > any mailing lists...
> 
> Yeah, get_maintainers.pl only suggested lkml. cc lkml I think.
> 
> I'm not sure if we want to put these drivers in misc, or if we want to
> use something like drivers/soc/aspeed.
> 
> Arnd, Greg, do you have any suggestions here?

It's up to you :)

  reply	other threads:[~2017-06-06  5:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 21:53 [PATCH] drivers/misc: add Aspeed LPC snoop driver Robert Lippert
2017-06-05  3:25 ` Joel Stanley
2017-06-05 19:46   ` Rob Lippert
2017-06-06  2:16     ` Joel Stanley
2017-06-06  5:35       ` Greg KH [this message]
2017-06-06  8:07       ` Arnd Bergmann
2017-06-06 16:51         ` Rick Altherr
2017-06-09 19:00           ` Arnd Bergmann
2017-06-09 22:16             ` Rick Altherr
2017-06-12 23:04               ` Benjamin Herrenschmidt
2017-06-12 23:05                 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170606053531.GA21809@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=joel@jms.id.au \
    --cc=openbmc@lists.ozlabs.org \
    --cc=rlippert@google.com \
    --cc=roblip@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.