From: Hoeun Ryu <hoeun.ryu@gmail.com>
To: Tony Lindgren <tony@atomide.com>, Russell King <linux@armlinux.org.uk>
Cc: linux-omap@vger.kernel.org, Hoeun Ryu <hoeun.ryu@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Date: Tue, 13 Jun 2017 10:09:48 +0900 [thread overview]
Message-ID: <1497316206-11110-1-git-send-email-hoeun.ryu@gmail.com> (raw)
omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section
and it's right implementation. But because of this, we cannot enable
CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools
for debugging early boot stage when something goes wrong if you don't have
any hardware based debugging tools like a JTAG debugger.
This patch is to put the variables into .text section instead only when the
DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only
when ZIMAGE is defined.
This patch does not change anything when DEBUG_LL_INCLUDE is included in
the other kernel parts like arch/arm/kernel/*
Signed-off-by: Hoeun Ryu <hoeun.ryu@gmail.com>
---
* to mail to relevant recipients, no respond yet from them
- TO=Tony Lindgren <tony@atomide.com>
- CC=linux-omap@vger.kernel.org
* indentical to previous patch
arch/arm/include/debug/omap2plus.S | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S
index 6d867ae..6ce6ef9 100644
--- a/arch/arm/include/debug/omap2plus.S
+++ b/arch/arm/include/debug/omap2plus.S
@@ -58,11 +58,22 @@
#define UART_OFFSET(addr) ((addr) & 0x00ffffff)
+/*
+ * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile.
+ * Place the following block in .text section only when this file is
+ * included by arch/arm/boot/compressed/* to make it possible to
+ * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in arch/arm/boot/compressed/head.S
+ * on OMAP2+ SoCs.
+ */
+#ifndef ZIMAGE
.pushsection .data
+#endif
omap_uart_phys: .word 0
omap_uart_virt: .word 0
omap_uart_lsr: .word 0
+#ifndef ZIMAGE
.popsection
+#endif
.macro addruart, rp, rv, tmp
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: hoeun.ryu@gmail.com (Hoeun Ryu)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true
Date: Tue, 13 Jun 2017 10:09:48 +0900 [thread overview]
Message-ID: <1497316206-11110-1-git-send-email-hoeun.ryu@gmail.com> (raw)
omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section
and it's right implementation. But because of this, we cannot enable
CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools
for debugging early boot stage when something goes wrong if you don't have
any hardware based debugging tools like a JTAG debugger.
This patch is to put the variables into .text section instead only when the
DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only
when ZIMAGE is defined.
This patch does not change anything when DEBUG_LL_INCLUDE is included in
the other kernel parts like arch/arm/kernel/*
Signed-off-by: Hoeun Ryu <hoeun.ryu@gmail.com>
---
* to mail to relevant recipients, no respond yet from them
- TO=Tony Lindgren <tony@atomide.com>
- CC=linux-omap at vger.kernel.org
* indentical to previous patch
arch/arm/include/debug/omap2plus.S | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/arch/arm/include/debug/omap2plus.S b/arch/arm/include/debug/omap2plus.S
index 6d867ae..6ce6ef9 100644
--- a/arch/arm/include/debug/omap2plus.S
+++ b/arch/arm/include/debug/omap2plus.S
@@ -58,11 +58,22 @@
#define UART_OFFSET(addr) ((addr) & 0x00ffffff)
+/*
+ * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile.
+ * Place the following block in .text section only when this file is
+ * included by arch/arm/boot/compressed/* to make it possible to
+ * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in arch/arm/boot/compressed/head.S
+ * on OMAP2+ SoCs.
+ */
+#ifndef ZIMAGE
.pushsection .data
+#endif
omap_uart_phys: .word 0
omap_uart_virt: .word 0
omap_uart_lsr: .word 0
+#ifndef ZIMAGE
.popsection
+#endif
.macro addruart, rp, rv, tmp
--
2.7.4
next reply other threads:[~2017-06-13 1:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 1:09 Hoeun Ryu [this message]
2017-06-13 1:09 ` [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true Hoeun Ryu
2017-06-13 1:09 ` [RESEND PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for DEBUG_UNCOMPRESS Hoeun Ryu
2017-06-13 1:09 ` Hoeun Ryu
2017-06-14 5:27 ` [RESEND PATCH 1/2] arm:omap2+: put omap_uart_phys/virt/lsr in .text section when ZIMAGE is true Tony Lindgren
2017-06-14 5:27 ` Tony Lindgren
2017-06-14 6:48 ` Hoeun Ryu
2017-06-14 6:48 ` Hoeun Ryu
2017-06-14 7:24 ` Tony Lindgren
2017-06-14 7:24 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497316206-11110-1-git-send-email-hoeun.ryu@gmail.com \
--to=hoeun.ryu@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.