From: Joe Perches <joe@perches.com>
To: Colin Ian King <colin.king@canonical.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Srikanth Jampala <Jampala.Srikanth@cavium.com>,
linux-crypto@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"
Date: Tue, 13 Jun 2017 10:44:22 +0000 [thread overview]
Message-ID: <1497350662.18751.13.camel@perches.com> (raw)
In-Reply-To: <accc9c81-7f3c-6ebf-ff73-969cffc4b575@canonical.com>
On Tue, 2017-06-13 at 11:40 +0100, Colin Ian King wrote:
> On 13/06/17 11:36, Joe Perches wrote:
> > On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Trivial fix to spelling mistake in seq_printf message
> > Fixing spelling typos is a good thing, but is it a
> > good thing to change possibly API dependent output
> > in seq_ calls?
> Considering it's in -next and has not landed in upstream I supposed it
> was better to fix it now before it landed in Linus' repo.
Good call, thanks.
> > > diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
> >
> > []
> > > @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v)
> > > struct nitrox_device *ndev = s->private;
> > >
> > > seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx);
> > > - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id);
> > > + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id);
> > > seq_printf(s, " Cores [AE: %u SE: %u]\n",
> > > ndev->hw.ae_cores, ndev->hw.se_cores);
> > > seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Colin Ian King <colin.king@canonical.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Srikanth Jampala <Jampala.Srikanth@cavium.com>,
linux-crypto@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"
Date: Tue, 13 Jun 2017 03:44:22 -0700 [thread overview]
Message-ID: <1497350662.18751.13.camel@perches.com> (raw)
In-Reply-To: <accc9c81-7f3c-6ebf-ff73-969cffc4b575@canonical.com>
On Tue, 2017-06-13 at 11:40 +0100, Colin Ian King wrote:
> On 13/06/17 11:36, Joe Perches wrote:
> > On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Trivial fix to spelling mistake in seq_printf message
> > Fixing spelling typos is a good thing, but is it a
> > good thing to change possibly API dependent output
> > in seq_ calls?
> Considering it's in -next and has not landed in upstream I supposed it
> was better to fix it now before it landed in Linus' repo.
Good call, thanks.
> > > diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
> >
> > []
> > > @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v)
> > > struct nitrox_device *ndev = s->private;
> > >
> > > seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx);
> > > - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id);
> > > + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id);
> > > seq_printf(s, " Cores [AE: %u SE: %u]\n",
> > > ndev->hw.ae_cores, ndev->hw.se_cores);
> > > seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
next prev parent reply other threads:[~2017-06-13 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 8:52 [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Colin King
2017-06-13 8:52 ` Colin King
2017-06-13 10:36 ` Joe Perches
2017-06-13 10:36 ` Joe Perches
2017-06-13 10:40 ` Colin Ian King
2017-06-13 10:40 ` Colin Ian King
2017-06-13 10:44 ` Joe Perches [this message]
2017-06-13 10:44 ` Joe Perches
2017-06-20 3:41 ` Herbert Xu
2017-06-20 3:41 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497350662.18751.13.camel@perches.com \
--to=joe@perches.com \
--cc=Jampala.Srikanth@cavium.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.