* [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition
@ 2017-06-12 17:09 ` Jérémy Lefaure
0 siblings, 0 replies; 6+ messages in thread
From: Jérémy Lefaure @ 2017-06-12 17:09 UTC (permalink / raw)
To: linux-arm-kernel
I didn't find any use of this macro in the current kernel tree (with git
grep). KTHREAD_SIZE is no longer used for a very very long time. So
let's remove this definition.
Signed-off-by: J?r?my Lefaure <jeremy.lefaure@lse.epita.fr>
---
arch/arm/include/asm/page-nommu.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h
index 503f488053de..8f2c47bec375 100644
--- a/arch/arm/include/asm/page-nommu.h
+++ b/arch/arm/include/asm/page-nommu.h
@@ -11,12 +11,6 @@
#ifndef _ASMARM_PAGE_NOMMU_H
#define _ASMARM_PAGE_NOMMU_H
-#if !defined(CONFIG_SMALL_TASKS) && PAGE_SHIFT < 13
-#define KTHREAD_SIZE (8192)
-#else
-#define KTHREAD_SIZE PAGE_SIZE
-#endif
-
#define clear_page(page) memset((page), 0, PAGE_SIZE)
#define copy_page(to,from) memcpy((to), (from), PAGE_SIZE)
--
2.13.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition
@ 2017-06-12 17:09 ` Jérémy Lefaure
0 siblings, 0 replies; 6+ messages in thread
From: Jérémy Lefaure @ 2017-06-12 17:09 UTC (permalink / raw)
To: Russell King, Jérémy Lefaure; +Cc: linux-arm-kernel, linux-kernel
I didn't find any use of this macro in the current kernel tree (with git
grep). KTHREAD_SIZE is no longer used for a very very long time. So
let's remove this definition.
Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
arch/arm/include/asm/page-nommu.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h
index 503f488053de..8f2c47bec375 100644
--- a/arch/arm/include/asm/page-nommu.h
+++ b/arch/arm/include/asm/page-nommu.h
@@ -11,12 +11,6 @@
#ifndef _ASMARM_PAGE_NOMMU_H
#define _ASMARM_PAGE_NOMMU_H
-#if !defined(CONFIG_SMALL_TASKS) && PAGE_SHIFT < 13
-#define KTHREAD_SIZE (8192)
-#else
-#define KTHREAD_SIZE PAGE_SIZE
-#endif
-
#define clear_page(page) memset((page), 0, PAGE_SIZE)
#define copy_page(to,from) memcpy((to), (from), PAGE_SIZE)
--
2.13.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] c6x: remove unused KTHREAD_SIZE definition
2017-06-12 17:09 ` Jérémy Lefaure
(?)
@ 2017-06-12 17:09 ` Jérémy Lefaure
2017-06-15 20:53 ` Mark Salter
-1 siblings, 1 reply; 6+ messages in thread
From: Jérémy Lefaure @ 2017-06-12 17:09 UTC (permalink / raw)
To: Mark Salter, Aurelien Jacquiot, Jérémy Lefaure
Cc: linux-c6x-dev, linux-kernel
KTHREAD_SIZE has never been used since it has been defined for c6x arch.
Let's remove this useless definition.
Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
arch/c6x/kernel/asm-offsets.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/c6x/kernel/asm-offsets.c b/arch/c6x/kernel/asm-offsets.c
index 60f1e437745d..f8ededbfb63f 100644
--- a/arch/c6x/kernel/asm-offsets.c
+++ b/arch/c6x/kernel/asm-offsets.c
@@ -106,7 +106,6 @@ void foo(void)
/* These would be unneccessary if we ran asm files
* through the preprocessor.
*/
- DEFINE(KTHREAD_SIZE, THREAD_SIZE);
DEFINE(KTHREAD_SHIFT, THREAD_SHIFT);
DEFINE(KTHREAD_START_SP, THREAD_START_SP);
DEFINE(ENOSYS_, ENOSYS);
--
2.13.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] c6x: remove unused KTHREAD_SIZE definition
2017-06-12 17:09 ` [PATCH 2/2] c6x: " Jérémy Lefaure
@ 2017-06-15 20:53 ` Mark Salter
0 siblings, 0 replies; 6+ messages in thread
From: Mark Salter @ 2017-06-15 20:53 UTC (permalink / raw)
To: Jérémy Lefaure, Aurelien Jacquiot; +Cc: linux-c6x-dev, linux-kernel
On Mon, 2017-06-12 at 13:09 -0400, Jérémy Lefaure wrote:
> KTHREAD_SIZE has never been used since it has been defined for c6x arch.
> Let's remove this useless definition.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> arch/c6x/kernel/asm-offsets.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/c6x/kernel/asm-offsets.c b/arch/c6x/kernel/asm-offsets.c
> index 60f1e437745d..f8ededbfb63f 100644
> --- a/arch/c6x/kernel/asm-offsets.c
> +++ b/arch/c6x/kernel/asm-offsets.c
> @@ -106,7 +106,6 @@ void foo(void)
> /* These would be unneccessary if we ran asm files
> * through the preprocessor.
> */
> - DEFINE(KTHREAD_SIZE, THREAD_SIZE);
> DEFINE(KTHREAD_SHIFT, THREAD_SHIFT);
> DEFINE(KTHREAD_START_SP, THREAD_START_SP);
> DEFINE(ENOSYS_, ENOSYS);
Acked-by: Mark Salter <msalter@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition
2017-06-12 17:09 ` Jérémy Lefaure
@ 2017-06-13 7:37 ` Vladimir Murzin
-1 siblings, 0 replies; 6+ messages in thread
From: Vladimir Murzin @ 2017-06-13 7:37 UTC (permalink / raw)
To: linux-arm-kernel
On 12/06/17 18:09, J?r?my Lefaure wrote:
> I didn't find any use of this macro in the current kernel tree (with git
> grep). KTHREAD_SIZE is no longer used for a very very long time. So
> let's remove this definition.
>
> Signed-off-by: J?r?my Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> arch/arm/include/asm/page-nommu.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h
> index 503f488053de..8f2c47bec375 100644
> --- a/arch/arm/include/asm/page-nommu.h
> +++ b/arch/arm/include/asm/page-nommu.h
> @@ -11,12 +11,6 @@
> #ifndef _ASMARM_PAGE_NOMMU_H
> #define _ASMARM_PAGE_NOMMU_H
>
> -#if !defined(CONFIG_SMALL_TASKS) && PAGE_SHIFT < 13
> -#define KTHREAD_SIZE (8192)
> -#else
> -#define KTHREAD_SIZE PAGE_SIZE
> -#endif
> -
> #define clear_page(page) memset((page), 0, PAGE_SIZE)
> #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE)
>
>
Even more, CONFIG_SMALL_TASKS has gone and only page size we support is 4K.
It looks like that similar patch has been submitted several times by different
people but never got merged, so if it helps:
Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
Cheers
Vladimir
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition
@ 2017-06-13 7:37 ` Vladimir Murzin
0 siblings, 0 replies; 6+ messages in thread
From: Vladimir Murzin @ 2017-06-13 7:37 UTC (permalink / raw)
To: Jérémy Lefaure, Russell King; +Cc: linux-kernel, linux-arm-kernel
On 12/06/17 18:09, Jérémy Lefaure wrote:
> I didn't find any use of this macro in the current kernel tree (with git
> grep). KTHREAD_SIZE is no longer used for a very very long time. So
> let's remove this definition.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> arch/arm/include/asm/page-nommu.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h
> index 503f488053de..8f2c47bec375 100644
> --- a/arch/arm/include/asm/page-nommu.h
> +++ b/arch/arm/include/asm/page-nommu.h
> @@ -11,12 +11,6 @@
> #ifndef _ASMARM_PAGE_NOMMU_H
> #define _ASMARM_PAGE_NOMMU_H
>
> -#if !defined(CONFIG_SMALL_TASKS) && PAGE_SHIFT < 13
> -#define KTHREAD_SIZE (8192)
> -#else
> -#define KTHREAD_SIZE PAGE_SIZE
> -#endif
> -
> #define clear_page(page) memset((page), 0, PAGE_SIZE)
> #define copy_page(to,from) memcpy((to), (from), PAGE_SIZE)
>
>
Even more, CONFIG_SMALL_TASKS has gone and only page size we support is 4K.
It looks like that similar patch has been submitted several times by different
people but never got merged, so if it helps:
Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
Cheers
Vladimir
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-06-15 20:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-12 17:09 [PATCH 1/2] arm: nommu: remove unused KTHREAD_SIZE definition Jérémy Lefaure
2017-06-12 17:09 ` Jérémy Lefaure
2017-06-12 17:09 ` [PATCH 2/2] c6x: " Jérémy Lefaure
2017-06-15 20:53 ` Mark Salter
2017-06-13 7:37 ` [PATCH 1/2] arm: nommu: " Vladimir Murzin
2017-06-13 7:37 ` Vladimir Murzin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.