* Patch "serial: 8250_lpss: Unconditionally set PCI master for Quark" has been added to the 4.11-stable tree
@ 2017-06-18 1:03 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-06-18 1:03 UTC (permalink / raw)
To: jan.kiszka, andy.shevchenko, gregkh; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
serial: 8250_lpss: Unconditionally set PCI master for Quark
to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
serial-8250_lpss-unconditionally-set-pci-master-for-quark.patch
and it can be found in the queue-4.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 7cd3e9dbdd4c0025d0e37c8c73a2ac8641fc55bc Mon Sep 17 00:00:00 2001
From: Jan Kiszka <jan.kiszka@siemens.com>
Date: Thu, 23 Mar 2017 09:26:42 +0100
Subject: serial: 8250_lpss: Unconditionally set PCI master for Quark
From: Jan Kiszka <jan.kiszka@siemens.com>
commit 7cd3e9dbdd4c0025d0e37c8c73a2ac8641fc55bc upstream.
MSI needs it as well.
Should have no practical impact, though, as DMA is always available on
the Quark. But given the few users of pci_alloc_irq_vectors so far, this
incorrect pattern may spread otherwise.
Fixes: 3f3a46951e02 ("serial: 8250_lpss: set PCI master only for private DMA")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/tty/serial/8250/8250_lpss.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/tty/serial/8250/8250_lpss.c
+++ b/drivers/tty/serial/8250/8250_lpss.c
@@ -183,7 +183,6 @@ static void qrk_serial_setup_dma(struct
if (ret)
return;
- pci_set_master(pdev);
pci_try_set_mwi(pdev);
/* Special DMA address for UART */
@@ -216,6 +215,8 @@ static int qrk_serial_setup(struct lpss8
struct pci_dev *pdev = to_pci_dev(port->dev);
int ret;
+ pci_set_master(pdev);
+
ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
if (ret < 0)
return ret;
Patches currently in stable-queue which might be from jan.kiszka@siemens.com are
queue-4.11/serial-8250_lpss-unconditionally-set-pci-master-for-quark.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-06-18 1:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-18 1:03 Patch "serial: 8250_lpss: Unconditionally set PCI master for Quark" has been added to the 4.11-stable tree gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.