From: Jeff Layton <jlayton@redhat.com>
To: Colin King <colin.king@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@techsingularity.net>, Jan Kara <jack@suse.cz>,
Michal Hocko <mhocko@suse.com>,
Dave Chinner <dchinner@redhat.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-mm@kvack.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][mm-next] mm: clean up build warning with unused variable ret2
Date: Wed, 21 Jun 2017 10:22:19 +0000 [thread overview]
Message-ID: <1498040539.4735.3.camel@redhat.com> (raw)
In-Reply-To: <20170621101433.9847-1-colin.king@canonical.com>
On Wed, 2017-06-21 at 11:14 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable ret2 is unused and should be removed. Cleans up
> build warning:
>
> warning: unused variable 'ret2' [-Wunused-variable]
>
> Fixes: 4118ba44fa2cd040e ("mm: clean up error handling in write_one_page")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 64b75bd996a4..0b60cc7ddac2 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2377,7 +2377,7 @@ int do_writepages(struct address_space *mapping, struct writeback_control *wbc)
> int write_one_page(struct page *page)
> {
> struct address_space *mapping = page->mapping;
> - int ret = 0, ret2;
> + int ret = 0;
> struct writeback_control wbc = {
> .sync_mode = WB_SYNC_ALL,
> .nr_to_write = 1,
Thanks. I just squashed the same fix into the original patch this
morning after seeing the mail from Stephen. Tomorrow's linux-next pull
should pick up the corrected version.
--
Jeff Layton <jlayton@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@redhat.com>
To: Colin King <colin.king@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@techsingularity.net>, Jan Kara <jack@suse.cz>,
Michal Hocko <mhocko@suse.com>,
Dave Chinner <dchinner@redhat.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-mm@kvack.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][mm-next] mm: clean up build warning with unused variable ret2
Date: Wed, 21 Jun 2017 06:22:19 -0400 [thread overview]
Message-ID: <1498040539.4735.3.camel@redhat.com> (raw)
In-Reply-To: <20170621101433.9847-1-colin.king@canonical.com>
On Wed, 2017-06-21 at 11:14 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable ret2 is unused and should be removed. Cleans up
> build warning:
>
> warning: unused variable 'ret2' [-Wunused-variable]
>
> Fixes: 4118ba44fa2cd040e ("mm: clean up error handling in write_one_page")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 64b75bd996a4..0b60cc7ddac2 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2377,7 +2377,7 @@ int do_writepages(struct address_space *mapping, struct writeback_control *wbc)
> int write_one_page(struct page *page)
> {
> struct address_space *mapping = page->mapping;
> - int ret = 0, ret2;
> + int ret = 0;
> struct writeback_control wbc = {
> .sync_mode = WB_SYNC_ALL,
> .nr_to_write = 1,
Thanks. I just squashed the same fix into the original patch this
morning after seeing the mail from Stephen. Tomorrow's linux-next pull
should pick up the corrected version.
--
Jeff Layton <jlayton@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@redhat.com>
To: Colin King <colin.king@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@techsingularity.net>, Jan Kara <jack@suse.cz>,
Michal Hocko <mhocko@suse.com>,
Dave Chinner <dchinner@redhat.com>,
Matthew Wilcox <mawilcox@microsoft.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-mm@kvack.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][mm-next] mm: clean up build warning with unused variable ret2
Date: Wed, 21 Jun 2017 06:22:19 -0400 [thread overview]
Message-ID: <1498040539.4735.3.camel@redhat.com> (raw)
In-Reply-To: <20170621101433.9847-1-colin.king@canonical.com>
On Wed, 2017-06-21 at 11:14 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable ret2 is unused and should be removed. Cleans up
> build warning:
>
> warning: unused variable 'ret2' [-Wunused-variable]
>
> Fixes: 4118ba44fa2cd040e ("mm: clean up error handling in write_one_page")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 64b75bd996a4..0b60cc7ddac2 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2377,7 +2377,7 @@ int do_writepages(struct address_space *mapping, struct writeback_control *wbc)
> int write_one_page(struct page *page)
> {
> struct address_space *mapping = page->mapping;
> - int ret = 0, ret2;
> + int ret = 0;
> struct writeback_control wbc = {
> .sync_mode = WB_SYNC_ALL,
> .nr_to_write = 1,
Thanks. I just squashed the same fix into the original patch this
morning after seeing the mail from Stephen. Tomorrow's linux-next pull
should pick up the corrected version.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2017-06-21 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 10:14 [PATCH][mm-next] mm: clean up build warning with unused variable ret2 Colin King
2017-06-21 10:14 ` Colin King
2017-06-21 10:14 ` Colin King
2017-06-21 10:22 ` Jeff Layton [this message]
2017-06-21 10:22 ` Jeff Layton
2017-06-21 10:22 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498040539.4735.3.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=colin.king@canonical.com \
--cc=dchinner@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.