* [PATCH] staging: iio: ad7280a: add spaces around '-'
@ 2017-06-25 19:15 Reno Farnesi
2017-06-26 16:48 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Reno Farnesi @ 2017-06-25 19:15 UTC (permalink / raw)
To: jic23; +Cc: gregkh, linux-iio
Fixes the following checkpatch check to improve readability.
CHECK: spaces preferred around that '-' (ctx:VxV)
Signed-off-by: Reno Farnesi <nfarnesi4@gmail.com>
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index d5ab83f0236d..d79e7746d351 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq,
void *private)
}
static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
- in_voltage-voltage_thresh_low_value,
+ in_voltage - voltage_thresh_low_value,
0644,
ad7280_read_channel_config,
ad7280_write_channel_config,
AD7280A_CELL_UNDERVOLTAGE);
static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
- in_voltage-voltage_thresh_high_value,
+ in_voltage - voltage_thresh_high_value,
0644,
ad7280_read_channel_config,
ad7280_write_channel_config,
--
2.13.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: ad7280a: add spaces around '-'
2017-06-25 19:15 [PATCH] staging: iio: ad7280a: add spaces around '-' Reno Farnesi
@ 2017-06-26 16:48 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2017-06-26 16:48 UTC (permalink / raw)
To: Reno Farnesi; +Cc: gregkh, linux-iio
On Sun, 25 Jun 2017 15:15:47 -0400
Reno Farnesi <nfarnesi4@gmail.com> wrote:
> Fixes the following checkpatch check to improve readability.
>
> CHECK: spaces preferred around that '-' (ctx:VxV)
>
> Signed-off-by: Reno Farnesi <nfarnesi4@gmail.com>
False positive. Not everything is what it seems ;)
Check what the macro does with that parameter...
Jonathan
> ---
> drivers/staging/iio/adc/ad7280a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7280a.c
> b/drivers/staging/iio/adc/ad7280a.c
> index d5ab83f0236d..d79e7746d351 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq,
> void *private)
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> - in_voltage-voltage_thresh_low_value,
> + in_voltage - voltage_thresh_low_value,
> 0644,
> ad7280_read_channel_config,
> ad7280_write_channel_config,
> AD7280A_CELL_UNDERVOLTAGE);
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> - in_voltage-voltage_thresh_high_value,
> + in_voltage - voltage_thresh_high_value,
> 0644,
> ad7280_read_channel_config,
> ad7280_write_channel_config,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-26 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-25 19:15 [PATCH] staging: iio: ad7280a: add spaces around '-' Reno Farnesi
2017-06-26 16:48 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.