* [Intel-wired-lan] [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver
@ 2017-06-22 13:23 ` Michael Moese
0 siblings, 0 replies; 4+ messages in thread
From: Michael Moese @ 2017-06-22 13:23 UTC (permalink / raw)
To: intel-wired-lan
From: Andreas Werner <andreas.werner@men.de>
Signed-off-by: Andreas Werner <andreas.werner@men.de>
---
drivers/net/ethernet/intel/igb/igb_main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 1cf74aa4ebd9..87e496eeefb1 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7716,6 +7716,10 @@ static int igb_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
return -EIO;
break;
case SIOCSMIIREG:
+ if (igb_write_phy_reg(&adapter->hw, data->reg_num & 0x1F,
+ data->val_in))
+ return -EIO;
+ break;
default:
return -EOPNOTSUPP;
}
--
2.12.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver
@ 2017-06-22 13:23 ` Michael Moese
0 siblings, 0 replies; 4+ messages in thread
From: Michael Moese @ 2017-06-22 13:23 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: intel-wired-lan, netdev, linux-kernel, Andreas Werner
From: Andreas Werner <andreas.werner@men.de>
Signed-off-by: Andreas Werner <andreas.werner@men.de>
---
drivers/net/ethernet/intel/igb/igb_main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 1cf74aa4ebd9..87e496eeefb1 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -7716,6 +7716,10 @@ static int igb_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
return -EIO;
break;
case SIOCSMIIREG:
+ if (igb_write_phy_reg(&adapter->hw, data->reg_num & 0x1F,
+ data->val_in))
+ return -EIO;
+ break;
default:
return -EOPNOTSUPP;
}
--
2.12.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver
2017-06-22 13:23 ` Michael Moese
@ 2017-06-26 21:11 ` Jeff Kirsher
-1 siblings, 0 replies; 4+ messages in thread
From: Jeff Kirsher @ 2017-06-26 21:11 UTC (permalink / raw)
To: intel-wired-lan
On Thu, 2017-06-22 at 15:23 +0200, Michael Moese wrote:
> From: Andreas Werner <andreas.werner@men.de>
>
> Signed-off-by: Andreas Werner <andreas.werner@men.de>
> ---
> ?drivers/net/ethernet/intel/igb/igb_main.c | 4 ++++
> ?1 file changed, 4 insertions(+)
NACK
Why? Your lack of patch description does not provide a reasoning on why we
need this change. I need a patch description that provides justification
on why we need this change, before I add this to my queue for testing and
acceptance upstream.
Please resubmit with the requested information/change.
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
> b/drivers/net/ethernet/intel/igb/igb_main.c
> index 1cf74aa4ebd9..87e496eeefb1 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -7716,6 +7716,10 @@ static int igb_mii_ioctl(struct net_device
> *netdev, struct ifreq *ifr, int cmd)
> ? return -EIO;
> ? break;
> ? case SIOCSMIIREG:
> + if (igb_write_phy_reg(&adapter->hw, data->reg_num &
> 0x1F,
> + ??????data->val_in))
> + return -EIO;
> + break;
> ? default:
> ? return -EOPNOTSUPP;
> ? }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170626/1ff7d9df/attachment-0001.asc>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver
@ 2017-06-26 21:11 ` Jeff Kirsher
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Kirsher @ 2017-06-26 21:11 UTC (permalink / raw)
To: Michael Moese; +Cc: intel-wired-lan, netdev, linux-kernel, Andreas Werner
[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]
On Thu, 2017-06-22 at 15:23 +0200, Michael Moese wrote:
> From: Andreas Werner <andreas.werner@men.de>
>
> Signed-off-by: Andreas Werner <andreas.werner@men.de>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 4 ++++
> 1 file changed, 4 insertions(+)
NACK
Why? Your lack of patch description does not provide a reasoning on why we
need this change. I need a patch description that provides justification
on why we need this change, before I add this to my queue for testing and
acceptance upstream.
Please resubmit with the requested information/change.
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
> b/drivers/net/ethernet/intel/igb/igb_main.c
> index 1cf74aa4ebd9..87e496eeefb1 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -7716,6 +7716,10 @@ static int igb_mii_ioctl(struct net_device
> *netdev, struct ifreq *ifr, int cmd)
> return -EIO;
> break;
> case SIOCSMIIREG:
> + if (igb_write_phy_reg(&adapter->hw, data->reg_num &
> 0x1F,
> + data->val_in))
> + return -EIO;
> + break;
> default:
> return -EOPNOTSUPP;
> }
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-26 21:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-22 13:23 [Intel-wired-lan] [PATCH] Added SIOCSMIIREG (mii write) support to intel igb driver Michael Moese
2017-06-22 13:23 ` Michael Moese
2017-06-26 21:11 ` [Intel-wired-lan] " Jeff Kirsher
2017-06-26 21:11 ` Jeff Kirsher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.