Re: [PATCH i-g-t 2/7] tests/chamelium: Check all connectors state for basic hotplug

[Lyude Paul <lyude@redhat.com>]

rb'd and pushed, thanks!

On Mon, 2017-06-26 at 16:59 +0300, Paul Kocialkowski wrote:
> Without doing a full reprobe, hpd toggles are sent without much delay
> between them. With a VGA connector attached, the reset occurring
> before
> the test will toggle its state, with a delay (inherent to hpd
> detection
> on VGA).
> 
> It often occurs that this VGA state toggle is detected in the middle
> of
> the current connector test, triggering a hotplug event unrelated to
> the
> current connector and thus causing the test to fail.
> 
> Thus, the state of all connectors is checked (and waited for) before
> running the basic hotplug test.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
>  tests/chamelium.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/chamelium.c b/tests/chamelium.c
> index e1f21fb8..5075a52f 100644
> --- a/tests/chamelium.c
> +++ b/tests/chamelium.c
> @@ -165,7 +165,7 @@ test_basic_hotplug(data_t *data, struct
> chamelium_port *port)
>  	struct udev_monitor *mon = igt_watch_hotplug();
>  	int i;
>  
> -	reset_state(data, port);
> +	reset_state(data, NULL);
>  	igt_hpd_storm_set_threshold(data->drm_fd, 0);
>  
>  	for (i = 0; i < 15; i++) {
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx