Re: [PATCH i-g-t 3/7] tests/chamelium: Use 50 ms delay to wait for connector change

From: Lyude Paul <lyude@redhat.com>
To: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 3/7] tests/chamelium: Use 50 ms delay to wait for connector change
Date: Mon, 26 Jun 2017 17:36:57 -0400	[thread overview]
Message-ID: <1498513017.4147.9.camel@redhat.com> (raw)
In-Reply-To: <20170626135906.32708-3-paul.kocialkowski@linux.intel.com>

rb'd and pushed, thanks!

On Mon, 2017-06-26 at 16:59 +0300, Paul Kocialkowski wrote:
> Using a 1 s delay seems too large for detecting a connector change,
> that
> may happen faster than this. Since the constraints on execution time
> are
> high, it is preferable to use a much smaller sleep time.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@linux.intel.com>
> ---
>  tests/chamelium.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/chamelium.c b/tests/chamelium.c
> index 5075a52f..15ed0f28 100644
> --- a/tests/chamelium.c
> +++ b/tests/chamelium.c
> @@ -135,7 +135,7 @@ wait_for_connector(data_t *data, struct
> chamelium_port *port,
>  			return;
>  		}
>  
> -		sleep(1);
> +		usleep(50000);
>  	}
>  
>  	igt_assert(finished);
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx