All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Michal Hocko <mhocko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm, vmscan: do not loop on too_many_isolated for ever
Date: Mon, 10 Jul 2017 09:58:03 -0400	[thread overview]
Message-ID: <1499695083.6130.38.camel@redhat.com> (raw)
In-Reply-To: <20170710074842.23175-1-mhocko@kernel.org>

On Mon, 2017-07-10 at 09:48 +0200, Michal Hocko wrote:

> Johannes and Rik had some concerns that this could lead to premature
> OOM kills. I agree with them that we need a better throttling
> mechanism. Until now we didn't give the issue described above a high
> priority because it usually required a really insane workload to
> trigger. But it seems that the issue can be reproduced also without
> having an insane number of competing threads [3].

My worries stand, but lets fix the real observed bug, and not worry
too much about the theoretical bug for now.

Acked-by: Rik van Riel <riel@redhat.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Michal Hocko <mhocko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@suse.de>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH] mm, vmscan: do not loop on too_many_isolated for ever
Date: Mon, 10 Jul 2017 09:58:03 -0400	[thread overview]
Message-ID: <1499695083.6130.38.camel@redhat.com> (raw)
In-Reply-To: <20170710074842.23175-1-mhocko@kernel.org>

On Mon, 2017-07-10 at 09:48 +0200, Michal Hocko wrote:

> Johannes and Rik had some concerns that this could lead to premature
> OOM kills. I agree with them that we need a better throttling
> mechanism. Until now we didn't give the issue described above a high
> priority because it usually required a really insane workload to
> trigger. But it seems that the issue can be reproduced also without
> having an insane number of competing threads [3].

My worries stand, but lets fix the real observed bug, and not worry
too much about the theoretical bug for now.

Acked-by: Rik van Riel <riel@redhat.com>

  parent reply	other threads:[~2017-07-10 13:58 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10  7:48 [PATCH] mm, vmscan: do not loop on too_many_isolated for ever Michal Hocko
2017-07-10  7:48 ` Michal Hocko
2017-07-10 13:16 ` Vlastimil Babka
2017-07-10 13:16   ` Vlastimil Babka
2017-07-10 13:58 ` Rik van Riel [this message]
2017-07-10 13:58   ` Rik van Riel
2017-07-10 16:58   ` Johannes Weiner
2017-07-10 16:58     ` Johannes Weiner
2017-07-10 17:09     ` Michal Hocko
2017-07-10 17:09       ` Michal Hocko
2017-07-19 22:20 ` Andrew Morton
2017-07-19 22:20   ` Andrew Morton
2017-07-20  6:56   ` Michal Hocko
2017-07-20  6:56     ` Michal Hocko
2017-07-21 23:01     ` Andrew Morton
2017-07-21 23:01       ` Andrew Morton
2017-07-24  6:50       ` Michal Hocko
2017-07-24  6:50         ` Michal Hocko
2017-07-20  1:54 ` Hugh Dickins
2017-07-20  1:54   ` Hugh Dickins
2017-07-20 10:44   ` Tetsuo Handa
2017-07-20 10:44     ` Tetsuo Handa
2017-07-24  7:01     ` Hugh Dickins
2017-07-24  7:01       ` Hugh Dickins
2017-07-24 11:12       ` Tetsuo Handa
2017-07-24 11:12         ` Tetsuo Handa
2017-07-20 13:22   ` Michal Hocko
2017-07-20 13:22     ` Michal Hocko
2017-07-24  7:03     ` Hugh Dickins
2017-07-24  7:03       ` Hugh Dickins
  -- strict thread matches above, loose matches on Subject: below --
2017-03-07 13:30 Michal Hocko
2017-03-07 13:30 ` Michal Hocko
2017-03-07 19:52 ` Rik van Riel
2017-03-08  9:21   ` Michal Hocko
2017-03-08  9:21     ` Michal Hocko
2017-03-08 15:54     ` Rik van Riel
2017-03-08 15:54       ` Rik van Riel
2017-03-09  9:12       ` Michal Hocko
2017-03-09  9:12         ` Michal Hocko
2017-03-09 14:16         ` Rik van Riel
2017-03-09 14:59           ` Michal Hocko
2017-03-09 14:59             ` Michal Hocko
2017-03-09 18:05   ` Johannes Weiner
2017-03-09 18:05     ` Johannes Weiner
2017-03-09 22:18     ` Rik van Riel
2017-03-10 10:27       ` Michal Hocko
2017-03-10 10:27         ` Michal Hocko
2017-03-10 10:20     ` Michal Hocko
2017-03-10 10:20       ` Michal Hocko
2017-03-10 11:44       ` Tetsuo Handa
2017-03-10 11:44         ` Tetsuo Handa
2017-03-21 10:37         ` Tetsuo Handa
2017-03-21 10:37           ` Tetsuo Handa
2017-04-23 10:24         ` Tetsuo Handa
2017-04-23 10:24           ` Tetsuo Handa
2017-04-24 12:39           ` Stanislaw Gruszka
2017-04-24 12:39             ` Stanislaw Gruszka
2017-04-24 13:06             ` Tetsuo Handa
2017-04-24 13:06               ` Tetsuo Handa
2017-04-25  6:33               ` Stanislaw Gruszka
2017-04-25  6:33                 ` Stanislaw Gruszka
2017-06-30  0:14         ` Tetsuo Handa
2017-06-30  0:14           ` Tetsuo Handa
2017-06-30 13:32           ` Michal Hocko
2017-06-30 13:32             ` Michal Hocko
2017-06-30 15:59             ` Tetsuo Handa
2017-06-30 15:59               ` Tetsuo Handa
2017-06-30 16:19               ` Michal Hocko
2017-06-30 16:19                 ` Michal Hocko
2017-07-01 11:43                 ` Tetsuo Handa
2017-07-01 11:43                   ` Tetsuo Handa
2017-07-05  8:19                   ` Michal Hocko
2017-07-05  8:19                     ` Michal Hocko
2017-07-05  8:20                   ` Michal Hocko
2017-07-05  8:20                     ` Michal Hocko
2017-07-06 10:48                     ` Tetsuo Handa
2017-07-06 10:48                       ` Tetsuo Handa
2017-03-09 14:31 ` Mel Gorman
2017-03-09 14:31   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499695083.6130.38.camel@redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@kernel.org \
    --cc=mhocko@suse.com \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.