All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>,
	Tina Zhang <tina.zhang@intel.com>,
	alex.williamson@redhat.com, chris@chris-wilson.co.uk,
	zhenyuw@linux.intel.com, zhiyuan.lv@intel.com,
	zhi.a.wang@intel.com, kevin.tian@intel.com, daniel@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation
Date: Tue, 11 Jul 2017 08:14:08 +0200	[thread overview]
Message-ID: <1499753648.8257.3.camel@redhat.com> (raw)
In-Reply-To: <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com>

  Hi,

> > +struct vfio_device_query_gfx_plane {
> > +	__u32 argsz;
> > +	__u32 flags;
> > +	struct vfio_device_gfx_plane_info plane_info;
> > +	__u32 plane_type;
> > +	__s32 fd; /* dma-buf fd */
> > +	__u32 plane_id;
> > +};
> > +
> 
> It would be better to have comment here about what are expected
> values
> for plane_type and plane_id.

plane_type is DRM_PLANE_TYPE_*.

yes, a comment saying so would be good, same for drm_format which is
DRM_FORMAT_*.  While looking at these two: renaming plane_type to
drm_plane_type (for consistency) is probably a good idea too.

plane_id needs a specification.

cheers,
  Gerd

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>,
	Tina Zhang <tina.zhang@intel.com>,
	alex.williamson@redhat.com, chris@chris-wilson.co.uk,
	zhenyuw@linux.intel.com, zhiyuan.lv@intel.com,
	zhi.a.wang@intel.com, kevin.tian@intel.com, daniel@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation
Date: Tue, 11 Jul 2017 08:14:08 +0200	[thread overview]
Message-ID: <1499753648.8257.3.camel@redhat.com> (raw)
In-Reply-To: <980a5c09-fa8a-255d-19ad-acf4bb29d271@nvidia.com>

  Hi,

> > +struct vfio_device_query_gfx_plane {
> > +	__u32 argsz;
> > +	__u32 flags;
> > +	struct vfio_device_gfx_plane_info plane_info;
> > +	__u32 plane_type;
> > +	__s32 fd; /* dma-buf fd */
> > +	__u32 plane_id;
> > +};
> > +
> 
> It would be better to have comment here about what are expected
> values
> for plane_type and plane_id.

plane_type is DRM_PLANE_TYPE_*.

yes, a comment saying so would be good, same for drm_format which is
DRM_FORMAT_*.  While looking at these two: renaming plane_type to
drm_plane_type (for consistency) is probably a good idea too.

plane_id needs a specification.

cheers,
  Gerd

  reply	other threads:[~2017-07-11  6:14 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05 22:29 [PATCH v10] vfio: ABI for mdev display dma-buf operation Tina Zhang
2017-07-05 22:52 ` ✓ Fi.CI.BAT: success for vfio: ABI for mdev display dma-buf operation (rev2) Patchwork
2017-07-06 14:01 ` [PATCH v10] vfio: ABI for mdev display dma-buf operation Kirti Wankhede
2017-07-06 14:01   ` Kirti Wankhede
2017-07-11  6:14   ` Gerd Hoffmann [this message]
2017-07-11  6:14     ` Gerd Hoffmann
2017-07-11  9:12     ` Daniel Vetter
2017-07-11  9:12       ` Daniel Vetter
2017-07-12  2:31       ` Zhang, Tina
2017-07-12  2:31         ` Zhang, Tina
2017-07-12  7:40         ` Daniel Vetter
2017-07-12  7:40           ` Daniel Vetter
2017-07-12 12:45           ` Kirti Wankhede
2017-07-14  1:30             ` Zhang, Tina
2017-07-14  1:30               ` Zhang, Tina
2017-07-14 10:12               ` Kirti Wankhede
2017-07-14 10:12                 ` Kirti Wankhede
2017-07-14 12:05                 ` Gerd Hoffmann
2017-07-14 12:05                   ` Gerd Hoffmann
2017-07-14 12:15                   ` Kirti Wankhede
2017-07-14 12:15                     ` Kirti Wankhede
2017-07-17 11:03                     ` Gerd Hoffmann
2017-07-17 11:03                       ` Gerd Hoffmann
2017-07-19  0:16                       ` Zhang, Tina
2017-07-19  0:16                         ` Zhang, Tina
2017-07-19  6:25                         ` Gerd Hoffmann
2017-07-19 11:52                           ` Kirti Wankhede
2017-07-19 11:52                             ` Kirti Wankhede
2017-07-14 10:01             ` Gerd Hoffmann
2017-07-14 10:01               ` Gerd Hoffmann
2017-07-14 10:15               ` Kirti Wankhede
2017-07-14 10:15                 ` Kirti Wankhede
2017-07-14 12:01                 ` Gerd Hoffmann
2017-07-14 12:01                   ` Gerd Hoffmann
2017-07-12  3:17       ` Zhenyu Wang
2017-07-12  2:20   ` Zhang, Tina
2017-07-12  2:20     ` Zhang, Tina
2017-07-11  6:07 ` Gerd Hoffmann
2017-07-11  6:07   ` Gerd Hoffmann
2017-07-12  2:43   ` Zhang, Tina
2017-07-12  2:43     ` Zhang, Tina
2017-07-11  9:15 ` Daniel Vetter
2017-07-11  9:15   ` Daniel Vetter
2017-07-12  3:12   ` Zhang, Tina
2017-07-12  3:12     ` Zhang, Tina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499753648.8257.3.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=kevin.tian@intel.com \
    --cc=kwankhede@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tina.zhang@intel.com \
    --cc=zhenyuw@linux.intel.com \
    --cc=zhi.a.wang@intel.com \
    --cc=zhiyuan.lv@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.