[PATCH] gettext: Enable generation of libasprintf in gettext 0.19

[PATCH] gettext: Enable generation of libasprintf in gettext 0.19

[Lev Iserovich]

Libasprintf was included in gettext 0.16 recipe, but omitted for some reason
in 0.19. This turns it back on.

Signed-off-by: Lev Iserovich <lev.iserovich@deshawresearch.com>
---
  meta/recipes-core/gettext/gettext_0.19.8.1.bb | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-core/gettext/gettext_0.19.8.1.bb 
b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
index c2059e6..c7c81ee 100644
--- a/meta/recipes-core/gettext/gettext_0.19.8.1.bb
+++ b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
@@ -28,7 +28,6 @@ inherit autotools texinfo

  EXTRA_OECONF += "--without-lispdir \
                   --disable-csharp \
-                 --disable-libasprintf \
                   --disable-java \
                   --disable-native-java \
                   --disable-openmp \
@@ -81,7 +80,7 @@ FILES_gettext-runtime = "${bindir}/gettext \
                           ${bindir}/ngettext \
                           ${bindir}/envsubst \
                           ${bindir}/gettext.sh \
-                         ${libdir}/libasprintf.so* \
+                         ${libdir}/libasprintf${SODEV} \
                           ${libdir}/GNU.Gettext.dll \
                          "
  FILES_gettext-runtime-dev += "${libdir}/libasprintf.a \
-- 
2.7.1

✗ patchtest: failure for gettext: Enable generation of libasprintf in gettext 0.19

[Patchwork]

== Series Details ==

Series: gettext: Enable generation of libasprintf in gettext 0.19
Revision: 1
URL   : https://patchwork.openembedded.org/series/7657/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 7dd5dfc4d5)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: ✗ patchtest: failure for gettext: Enable generation of libasprintf in gettext 0.19

[Lev Iserovich]

Can anyone help me with undestanding this - I'm confused by this 
patchwork failure.
The patch applies just fine on top of master - my patch was based on top 
of the commit with the hash referenced by patchwork below.

Thanks,

Lev Iserovich

On 07/10/2017 05:31 PM, Patchwork wrote:
> == Series Details ==
>
> Series: gettext: Enable generation of libasprintf in gettext 0.19
> Revision: 1
> URL   : https://patchwork.openembedded.org/series/7657/
> State : failure
>
> == Summary ==
>
>
> Thank you for submitting this patch series to OpenEmbedded Core. This is
> an automated response. Several tests have been executed on the proposed
> series by patchtest resulting in the following failures:
>
>
>
> * Issue             Series does not apply on top of target branch [test_series_merge_on_head]
>    Suggested fix    Rebase your series on top of targeted branch
>    Targeted branch  master (currently at 7dd5dfc4d5)
>
>
>
> If you believe any of these test results are incorrect, please reply to the
> mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
> Otherwise we would appreciate you correcting the issues and submitting a new
> version of the patchset if applicable. Please ensure you add/increment the
> version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
> [PATCH v3] -> ...).
>
> ---
> Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
>

Re: ✗ patchtest: failure for gettext: Enable generation of libasprintf in gettext 0.19

[Denys Dmytriyenko]

Your patch is simply corrupted - please use git to send it, not a regular MUA.


On Tue, Jul 11, 2017 at 11:10:11AM -0400, Lev Iserovich wrote:
> Can anyone help me with undestanding this - I'm confused by this
> patchwork failure.
> The patch applies just fine on top of master - my patch was based on
> top of the commit with the hash referenced by patchwork below.
> 
> Thanks,
> 
> Lev Iserovich
> 
> On 07/10/2017 05:31 PM, Patchwork wrote:
> >== Series Details ==
> >
> >Series: gettext: Enable generation of libasprintf in gettext 0.19
> >Revision: 1
> >URL   : https://patchwork.openembedded.org/series/7657/
> >State : failure
> >
> >== Summary ==
> >
> >
> >Thank you for submitting this patch series to OpenEmbedded Core. This is
> >an automated response. Several tests have been executed on the proposed
> >series by patchtest resulting in the following failures:
> >
> >
> >
> >* Issue             Series does not apply on top of target branch [test_series_merge_on_head]
> >   Suggested fix    Rebase your series on top of targeted branch
> >   Targeted branch  master (currently at 7dd5dfc4d5)
> >
> >
> >
> >If you believe any of these test results are incorrect, please reply to the
> >mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
> >Otherwise we would appreciate you correcting the issues and submitting a new
> >version of the patchset if applicable. Please ensure you add/increment the
> >version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
> >[PATCH v3] -> ...).
> >
> >---
> >Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> >Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
> >
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: ✗ patchtest: failure for gettext: Enable generation of libasprintf in gettext 0.19

[Leonardo Sandoval]

On Tue, 2017-07-11 at 11:35 -0400, Denys Dmytriyenko wrote:
> Your patch is simply corrupted - please use git to send it, not a regular MUA.

Lev,

I just tried locally and patch can not be merged on top of master's
HEAD.

One easy way to try is using patchwork's git plugin and from the command
line:


> git pw mbox 7657 | git apply --check --verbose
Checking patch meta/recipes-core/gettext/gettext_0.19.8.1.bb...
error: while searching for:

 EXTRA_OECONF += "--without-lispdir \
                  --disable-csharp \
                 --disable-libasprintf \
                  --disable-java \
                  --disable-native-java \
                  --disable-openmp \

So, as the message suggests, update your master and rebase your branch
against the latter.


> 
> On Tue, Jul 11, 2017 at 11:10:11AM -0400, Lev Iserovich wrote:
> > Can anyone help me with undestanding this - I'm confused by this
> > patchwork failure.
> > The patch applies just fine on top of master - my patch was based on
> > top of the commit with the hash referenced by patchwork below.
> > 
> > Thanks,
> > 
> > Lev Iserovich
> > 
> > On 07/10/2017 05:31 PM, Patchwork wrote:
> > >== Series Details ==
> > >
> > >Series: gettext: Enable generation of libasprintf in gettext 0.19
> > >Revision: 1
> > >URL   : https://patchwork.openembedded.org/series/7657/
> > >State : failure
> > >
> > >== Summary ==
> > >
> > >
> > >Thank you for submitting this patch series to OpenEmbedded Core. This is
> > >an automated response. Several tests have been executed on the proposed
> > >series by patchtest resulting in the following failures:
> > >
> > >
> > >
> > >* Issue             Series does not apply on top of target branch [test_series_merge_on_head]
> > >   Suggested fix    Rebase your series on top of targeted branch
> > >   Targeted branch  master (currently at 7dd5dfc4d5)
> > >
> > >
> > >
> > >If you believe any of these test results are incorrect, please reply to the
> > >mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
> > >Otherwise we would appreciate you correcting the issues and submitting a new
> > >version of the patchset if applicable. Please ensure you add/increment the
> > >version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
> > >[PATCH v3] -> ...).
> > >
> > >---
> > >Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> > >Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
> > >
> > 
> > -- 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: ✗ patchtest: failure for gettext: Enable generation of libasprintf in gettext 0.19

[Lev Iserovich]

On 07/11/2017 11:35 AM, Denys Dmytriyenko wrote:
> Your patch is simply corrupted - please use git to send it, not a regular MUA.
>
>
Thank you, resending with git worked.

Lev