From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>,
"hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 4/6] blk-mq: use EWMA to estimate congestion threshold
Date: Wed, 12 Jul 2017 15:39:14 +0000 [thread overview]
Message-ID: <1499873952.2554.5.camel@wdc.com> (raw)
In-Reply-To: <20170712023028.GB13036@ming.t460p>
On Wed, 2017-07-12 at 10:30 +0800, Ming Lei wrote:
> On Tue, Jul 11, 2017 at 12:25:16PM -0600, Jens Axboe wrote:
> > What happens with fluid congestion boundaries, with shared tags?
>=20
> The approach in this patch should work, but the threshold may not
> be accurate in this way, one simple method is to use the average
> tag weight in EWMA, like this:
>=20
> sbitmap_weight() / hctx->tags->active_queues
Hello Ming,
That approach would result in a severe performance degradation. "active_que=
ues"
namely represents the number of queues against which I/O ever has been queu=
ed.
If e.g. 64 LUNs would be associated with a single SCSI host and all 64 LUNs=
are
responding and if the queue depth would also be 64 then the approach you
proposed will reduce the effective queue depth per LUN from 64 to 1.
Bart.=
next prev parent reply other threads:[~2017-07-12 15:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 18:20 [PATCH 0/6] blk-mq: introduce congestion control Ming Lei
2017-07-11 18:20 ` [PATCH 1/6] xen-blkfront: avoid to use start/stop queue Ming Lei
2017-07-11 18:41 ` Konrad Rzeszutek Wilk
2017-07-11 18:41 ` Konrad Rzeszutek Wilk
2017-07-12 2:52 ` Ming Lei
2017-07-12 2:52 ` Ming Lei
2017-07-11 18:41 ` Bart Van Assche
2017-07-11 18:41 ` Bart Van Assche
2017-07-12 2:59 ` Ming Lei
2017-07-12 2:59 ` Ming Lei
2017-07-12 3:05 ` Ming Lei
2017-07-12 3:05 ` Ming Lei
2017-07-11 21:24 ` Roger Pau Monné
2017-07-11 21:24 ` Roger Pau Monné
2017-07-12 3:12 ` Ming Lei
2017-07-12 3:12 ` Ming Lei
2017-07-11 18:20 ` Ming Lei
2017-07-11 18:20 ` [PATCH 2/6] SCSI: use blk_mq_run_hw_queues() in scsi_kick_queue() Ming Lei
2017-07-11 19:57 ` Bart Van Assche
2017-07-11 19:57 ` Bart Van Assche
2017-07-12 3:15 ` Ming Lei
2017-07-12 15:12 ` Bart Van Assche
2017-07-12 15:12 ` Bart Van Assche
2017-07-13 10:23 ` Ming Lei
2017-07-13 17:44 ` Bart Van Assche
2017-07-13 17:44 ` Bart Van Assche
2017-07-11 18:21 ` [PATCH 3/6] blk-mq: send the request to dispatch list if direct issue returns busy Ming Lei
2017-07-11 20:18 ` Bart Van Assche
2017-07-12 3:45 ` Ming Lei
2017-07-11 18:21 ` [PATCH 4/6] blk-mq: use EWMA to estimate congestion threshold Ming Lei
2017-07-11 18:25 ` Jens Axboe
2017-07-12 2:30 ` Ming Lei
2017-07-12 15:39 ` Bart Van Assche [this message]
2017-07-13 10:43 ` Ming Lei
2017-07-13 14:56 ` Bart Van Assche
2017-07-13 15:32 ` Ming Lei
2017-07-13 17:35 ` Bart Van Assche
2017-07-11 18:39 ` Jens Axboe
2017-07-12 3:20 ` Ming Lei
2017-07-11 21:02 ` Bart Van Assche
2017-07-12 3:43 ` Ming Lei
2017-07-11 18:21 ` [PATCH 5/6] blk-mq: introduce basic congestion control Ming Lei
2017-07-11 18:21 ` [PATCH 6/6] blk-mq: unexport APIs for start/stop queues Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499873952.2554.5.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.