From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"hch@infradead.org" <hch@infradead.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH 2/6] SCSI: use blk_mq_run_hw_queues() in scsi_kick_queue()
Date: Thu, 13 Jul 2017 17:44:41 +0000 [thread overview]
Message-ID: <1499967879.2740.8.camel@wdc.com> (raw)
In-Reply-To: <20170713102343.GA19857@ming.t460p>
On Thu, 2017-07-13 at 18:23 +0800, Ming Lei wrote:
> Please discuss the congestion control in patch 4 and 5.
Hello Ming,
Since there is a significant risk that this patch series will introduce
performance and/or functional regressions, I will wait with reviewing this
patch series further until it has been shown that there is no less risky
alternative to realize the same performance improvement. I think Jens had
already suggested a possible alternative, namely by only starting a queue
if it really has to be started.
Bart.=
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"hch@infradead.org" <hch@infradead.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [PATCH 2/6] SCSI: use blk_mq_run_hw_queues() in scsi_kick_queue()
Date: Thu, 13 Jul 2017 17:44:41 +0000 [thread overview]
Message-ID: <1499967879.2740.8.camel@wdc.com> (raw)
In-Reply-To: <20170713102343.GA19857@ming.t460p>
On Thu, 2017-07-13 at 18:23 +0800, Ming Lei wrote:
> Please discuss the congestion control in patch 4 and 5.
Hello Ming,
Since there is a significant risk that this patch series will introduce
performance and/or functional regressions, I will wait with reviewing this
patch series further until it has been shown that there is no less risky
alternative to realize the same performance improvement. I think Jens had
already suggested a possible alternative, namely by only starting a queue
if it really has to be started.
Bart.
next prev parent reply other threads:[~2017-07-13 17:44 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 18:20 [PATCH 0/6] blk-mq: introduce congestion control Ming Lei
2017-07-11 18:20 ` [PATCH 1/6] xen-blkfront: avoid to use start/stop queue Ming Lei
2017-07-11 18:20 ` Ming Lei
2017-07-11 18:41 ` Konrad Rzeszutek Wilk
2017-07-11 18:41 ` Konrad Rzeszutek Wilk
2017-07-12 2:52 ` Ming Lei
2017-07-12 2:52 ` Ming Lei
2017-07-11 18:41 ` Bart Van Assche
2017-07-11 18:41 ` Bart Van Assche
2017-07-12 2:59 ` Ming Lei
2017-07-12 2:59 ` Ming Lei
2017-07-12 3:05 ` Ming Lei
2017-07-12 3:05 ` Ming Lei
2017-07-11 21:24 ` Roger Pau Monné
2017-07-12 3:12 ` Ming Lei
2017-07-12 3:12 ` Ming Lei
2017-07-11 21:24 ` Roger Pau Monné
2017-07-11 18:20 ` [PATCH 2/6] SCSI: use blk_mq_run_hw_queues() in scsi_kick_queue() Ming Lei
2017-07-11 19:57 ` Bart Van Assche
2017-07-11 19:57 ` Bart Van Assche
2017-07-12 3:15 ` Ming Lei
2017-07-12 15:12 ` Bart Van Assche
2017-07-12 15:12 ` Bart Van Assche
2017-07-13 10:23 ` Ming Lei
2017-07-13 17:44 ` Bart Van Assche [this message]
2017-07-13 17:44 ` Bart Van Assche
2017-07-11 18:21 ` [PATCH 3/6] blk-mq: send the request to dispatch list if direct issue returns busy Ming Lei
2017-07-11 20:18 ` Bart Van Assche
2017-07-12 3:45 ` Ming Lei
2017-07-11 18:21 ` [PATCH 4/6] blk-mq: use EWMA to estimate congestion threshold Ming Lei
2017-07-11 18:25 ` Jens Axboe
2017-07-12 2:30 ` Ming Lei
2017-07-12 15:39 ` Bart Van Assche
2017-07-13 10:43 ` Ming Lei
2017-07-13 14:56 ` Bart Van Assche
2017-07-13 15:32 ` Ming Lei
2017-07-13 17:35 ` Bart Van Assche
2017-07-11 18:39 ` Jens Axboe
2017-07-12 3:20 ` Ming Lei
2017-07-11 21:02 ` Bart Van Assche
2017-07-12 3:43 ` Ming Lei
2017-07-11 18:21 ` [PATCH 5/6] blk-mq: introduce basic congestion control Ming Lei
2017-07-11 18:21 ` [PATCH 6/6] blk-mq: unexport APIs for start/stop queues Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2017-07-14 23:15 [PATCH 0/6] blk-mq: cleanup start/stop queue Ming Lei
2017-07-14 23:15 ` [PATCH 2/6] SCSI: use blk_mq_run_hw_queues() in scsi_kick_queue() Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499967879.2740.8.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.