From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "bp@alien8.de" <bp@alien8.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mchehab@s-opensource.com" <mchehab@s-opensource.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"srinivas.pandruvada@linux.intel.com"
<srinivas.pandruvada@linux.intel.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac
Date: Thu, 20 Jul 2017 19:50:03 +0000 [thread overview]
Message-ID: <1500579646.2042.37.camel@hpe.com> (raw)
In-Reply-To: <20170720043344.GC14367@nazgul.tnic>
On Thu, 2017-07-20 at 06:33 +0200, Borislav Petkov wrote:
> On Wed, Jul 19, 2017 at 04:40:25PM +0000, Kani, Toshimitsu wrote:
> > ghes_edac allows to report errors to OS management tools like
> > rasdaemon in addition to platform- specific managements.
>
> So ghes_edac *is* a poor man's driver in the sense that it doesn't do
> anything fancy but repeat like a parrot data it has gotten from the
> firmware and shoving it into the EDAC counters. At least that's the
> intention. Nothing more.
Right for ghes_edac.
> All the action stuff like error detection and recovery should be done
> by the firmware.
GHES / firmware-first still requires OS recovery actions when an error
cannot be corrected by the platform. They are handled by ghes_proc(),
and ghes_edac remains its error-reporting wrapper.
> But considering how SNAFU'd firmware is, I wouldn't expect any great
> RAS functionality there. Of course, I'd be delighted to be proven
> wrong.
Firmware has better knowledge about the platform and can provide better
RAS when implemented properly. I agree that user experiences may vary
on platforms.
Thanks,
-Toshi
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: "bp@alien8.de" <bp@alien8.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mchehab@s-opensource.com" <mchehab@s-opensource.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"srinivas.pandruvada@linux.intel.com"
<srinivas.pandruvada@linux.intel.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: [3/3] ghes_edac: add platform check to enable ghes_edac
Date: Thu, 20 Jul 2017 19:50:03 +0000 [thread overview]
Message-ID: <1500579646.2042.37.camel@hpe.com> (raw)
On Thu, 2017-07-20 at 06:33 +0200, Borislav Petkov wrote:
> On Wed, Jul 19, 2017 at 04:40:25PM +0000, Kani, Toshimitsu wrote:
> > ghes_edac allows to report errors to OS management tools like
> > rasdaemon in addition to platform- specific managements.
>
> So ghes_edac *is* a poor man's driver in the sense that it doesn't do
> anything fancy but repeat like a parrot data it has gotten from the
> firmware and shoving it into the EDAC counters. At least that's the
> intention. Nothing more.
Right for ghes_edac.
> All the action stuff like error detection and recovery should be done
> by the firmware.
GHES / firmware-first still requires OS recovery actions when an error
cannot be corrected by the platform. They are handled by ghes_proc(),
and ghes_edac remains its error-reporting wrapper.
> But considering how SNAFU'd firmware is, I wouldn't expect any great
> RAS functionality there. Of course, I'd be delighted to be proven
> wrong.
Firmware has better knowledge about the platform and can provide better
RAS when implemented properly. I agree that user experiences may vary
on platforms.
Thanks,
-Toshi
next prev parent reply other threads:[~2017-07-20 19:50 UTC|newest]
Thread overview: 167+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 21:59 [PATCH 0/3] enable ghes_edac on selected platforms Toshi Kani
2017-07-17 21:59 ` [PATCH 1/3] ACPI / blacklist: add acpi_match_oemlist() interface Toshi Kani
2017-07-17 21:59 ` [1/3] " Toshi Kani
2017-07-18 5:34 ` [PATCH 1/3] " Borislav Petkov
2017-07-18 5:34 ` [1/3] " Borislav Petkov
2017-07-18 15:48 ` [PATCH 1/3] " Kani, Toshimitsu
2017-07-18 15:48 ` [1/3] " Toshi Kani
2017-07-18 16:43 ` [PATCH 1/3] " Borislav Petkov
2017-07-18 16:43 ` [1/3] " Borislav Petkov
2017-07-18 17:24 ` [PATCH 1/3] " Kani, Toshimitsu
2017-07-18 17:24 ` [1/3] " Toshi Kani
2017-07-18 17:42 ` [PATCH 1/3] " Borislav Petkov
2017-07-18 17:42 ` [1/3] " Borislav Petkov
2017-07-18 18:49 ` [PATCH 1/3] " Kani, Toshimitsu
2017-07-18 18:49 ` [1/3] " Toshi Kani
2017-07-18 19:32 ` [PATCH 1/3] " Borislav Petkov
2017-07-18 19:32 ` [1/3] " Borislav Petkov
2017-07-18 20:17 ` [PATCH 1/3] " Kani, Toshimitsu
2017-07-18 20:17 ` [1/3] " Toshi Kani
2017-07-17 21:59 ` [PATCH 2/3] intel_pstate: convert to use acpi_match_oemlist() Toshi Kani
2017-07-17 21:59 ` [2/3] " Toshi Kani
2017-07-17 21:59 ` [PATCH 3/3] ghes_edac: add platform check to enable ghes_edac Toshi Kani
2017-07-17 21:59 ` [3/3] " Toshi Kani
2017-07-18 6:00 ` [PATCH 3/3] " Borislav Petkov
2017-07-18 6:00 ` [3/3] " Borislav Petkov
2017-07-18 8:08 ` [PATCH 3/3] " Borislav Petkov
2017-07-18 8:08 ` [3/3] " Borislav Petkov
2017-07-18 21:20 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-18 21:20 ` [3/3] " Toshi Kani
2017-07-19 5:52 ` [PATCH 3/3] " Borislav Petkov
2017-07-19 5:52 ` [3/3] " Borislav Petkov
2017-07-19 16:10 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-19 16:10 ` [3/3] " Toshi Kani
2017-07-19 16:22 ` [PATCH 3/3] " Borislav Petkov
2017-07-19 16:22 ` [3/3] " Borislav Petkov
2017-07-19 16:56 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-19 16:56 ` [3/3] " Toshi Kani
2017-07-20 4:16 ` [PATCH 3/3] " Borislav Petkov
2017-07-20 4:16 ` [3/3] " Borislav Petkov
2017-07-20 14:42 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-20 14:42 ` [3/3] " Toshi Kani
2017-07-20 15:04 ` [PATCH 3/3] " Borislav Petkov
2017-07-20 15:04 ` [3/3] " Borislav Petkov
2017-07-20 16:55 ` [PATCH 3/3] " Luck, Tony
2017-07-20 16:55 ` [3/3] " Luck, Tony
2017-07-20 17:05 ` [PATCH 3/3] " Borislav Petkov
2017-07-20 17:05 ` [3/3] " Borislav Petkov
2017-07-20 17:10 ` [PATCH 3/3] " Luck, Tony
2017-07-20 17:10 ` [3/3] " Luck, Tony
2017-07-20 18:16 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-20 18:16 ` [3/3] " Mauro Carvalho Chehab
2017-07-19 18:55 ` [PATCH 3/3] " Aristeu Rozanski
2017-07-19 18:55 ` [3/3] " Aristeu Rozanski
2017-07-19 20:13 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-19 20:13 ` [3/3] " Toshi Kani
2017-07-20 4:19 ` [PATCH 3/3] " Borislav Petkov
2017-07-20 4:19 ` [3/3] " Borislav Petkov
2017-07-18 19:58 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-18 19:58 ` [3/3] " Toshi Kani
2017-07-18 21:15 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-18 21:15 ` [3/3] " Mauro Carvalho Chehab
2017-07-19 5:58 ` [PATCH 3/3] " Borislav Petkov
2017-07-19 5:58 ` [3/3] " Borislav Petkov
2017-07-19 15:14 ` [PATCH 3/3] " Luck, Tony
2017-07-19 15:14 ` [3/3] " Luck, Tony
2017-07-19 15:57 ` [PATCH 3/3] " Borislav Petkov
2017-07-19 15:57 ` [3/3] " Borislav Petkov
2017-07-19 18:06 ` [PATCH 3/3] " Luck, Tony
2017-07-19 18:06 ` [3/3] " Luck, Tony
2017-07-19 16:02 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-19 16:02 ` [3/3] " Mauro Carvalho Chehab
2017-07-19 20:06 ` [PATCH 3/3] " Luck, Tony
2017-07-19 20:06 ` [3/3] " Luck, Tony
2017-07-20 21:15 ` [PATCH 3/3] " Luck, Tony
2017-07-20 21:15 ` [3/3] " Luck, Tony
2017-07-21 0:00 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-21 0:00 ` [3/3] " Mauro Carvalho Chehab
2017-07-21 16:53 ` [PATCH 3/3] " Luck, Tony
2017-07-21 16:53 ` [3/3] " Luck, Tony
2017-07-19 16:40 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-19 16:40 ` [3/3] " Toshi Kani
2017-07-20 4:33 ` [PATCH 3/3] " Borislav Petkov
2017-07-20 4:33 ` [3/3] " Borislav Petkov
2017-07-20 19:50 ` Kani, Toshimitsu [this message]
2017-07-20 19:50 ` Toshi Kani
2017-07-20 20:15 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-20 20:15 ` [3/3] " Mauro Carvalho Chehab
2017-07-20 21:07 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-20 21:07 ` [3/3] " Toshi Kani
2017-07-21 13:34 ` [PATCH 3/3] " Borislav Petkov
2017-07-21 13:34 ` [3/3] " Borislav Petkov
2017-07-21 13:40 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-21 13:40 ` [3/3] " Mauro Carvalho Chehab
2017-07-21 13:47 ` [PATCH 3/3] " Borislav Petkov
2017-07-21 13:47 ` [3/3] " Borislav Petkov
2017-07-21 15:08 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-21 15:08 ` [3/3] " Toshi Kani
2017-07-21 15:13 ` [PATCH 3/3] " Borislav Petkov
2017-07-21 15:13 ` [3/3] " Borislav Petkov
2017-07-21 15:34 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-21 15:34 ` [3/3] " Toshi Kani
2017-07-21 15:44 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-21 15:44 ` [3/3] " Mauro Carvalho Chehab
2017-07-21 16:40 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-21 16:40 ` [3/3] " Toshi Kani
2017-07-21 17:01 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-21 17:01 ` [3/3] " Mauro Carvalho Chehab
2017-07-21 17:21 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-21 17:21 ` [3/3] " Toshi Kani
2017-07-21 17:23 ` [PATCH 3/3] " Borislav Petkov
2017-07-21 17:23 ` [3/3] " Borislav Petkov
2017-07-21 18:38 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-21 18:38 ` [3/3] " Toshi Kani
2017-07-22 6:28 ` [PATCH 3/3] " Borislav Petkov
2017-07-22 6:28 ` [3/3] " Borislav Petkov
2017-07-24 14:49 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-24 14:49 ` [3/3] " Toshi Kani
2017-07-24 15:04 ` [PATCH 3/3] " Borislav Petkov
2017-07-24 15:04 ` [3/3] " Borislav Petkov
2017-07-24 15:25 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-24 15:25 ` [3/3] " Toshi Kani
2017-07-24 15:37 ` [PATCH 3/3] " Borislav Petkov
2017-07-24 15:37 ` [3/3] " Borislav Petkov
2017-07-24 15:56 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-24 15:56 ` [3/3] " Toshi Kani
2017-07-24 16:37 ` [PATCH 3/3] " Borislav Petkov
2017-07-24 16:37 ` [3/3] " Borislav Petkov
2017-07-24 17:44 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-24 17:44 ` [3/3] " Toshi Kani
2017-07-24 17:50 ` [PATCH 3/3] " Boris Petkov
2017-07-24 17:50 ` [3/3] " Borislav Petkov
2017-07-24 17:54 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-24 17:54 ` [3/3] " Toshi Kani
2017-07-24 18:18 ` [PATCH 3/3] " Borislav Petkov
2017-07-24 18:18 ` [3/3] " Borislav Petkov
2017-07-24 17:56 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-24 17:56 ` [3/3] " Mauro Carvalho Chehab
2017-07-24 18:12 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-24 18:12 ` [3/3] " Toshi Kani
2017-07-24 16:04 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-24 16:04 ` [3/3] " Mauro Carvalho Chehab
2017-07-24 16:44 ` [PATCH 3/3] " Borislav Petkov
2017-07-24 16:44 ` [3/3] " Borislav Petkov
2017-07-24 18:10 ` [PATCH 3/3] " Mauro Carvalho Chehab
2017-07-24 18:10 ` [3/3] " Mauro Carvalho Chehab
2017-07-24 18:30 ` [PATCH 3/3] " Borislav Petkov
2017-07-24 18:30 ` [3/3] " Borislav Petkov
2017-07-25 23:00 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-25 23:00 ` [3/3] " Toshi Kani
2017-07-21 15:53 ` [PATCH 3/3] " Borislav Petkov
2017-07-21 15:53 ` [3/3] " Borislav Petkov
2017-07-21 16:32 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-21 16:32 ` [3/3] " Toshi Kani
2017-07-19 5:55 ` [PATCH 3/3] " Borislav Petkov
2017-07-19 5:55 ` [3/3] " Borislav Petkov
2017-07-18 22:13 ` [PATCH 3/3] " Luck, Tony
2017-07-18 22:13 ` [3/3] " Luck, Tony
2017-07-19 6:01 ` [PATCH 3/3] " Borislav Petkov
2017-07-19 6:01 ` [3/3] " Borislav Petkov
2017-07-18 14:39 ` [PATCH 3/3] " Jeffrey Hugo
2017-07-18 14:39 ` [3/3] " Jeffrey Hugo
2017-07-18 15:36 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-18 15:36 ` [3/3] " Toshi Kani
2017-07-18 16:24 ` [PATCH 3/3] " Jeffrey Hugo
2017-07-18 16:24 ` [3/3] " Jeffrey Hugo
2017-07-18 16:42 ` [PATCH 3/3] " Kani, Toshimitsu
2017-07-18 16:42 ` [3/3] " Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500579646.2042.37.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=bp@alien8.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mchehab@s-opensource.com \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.