From: Trond Myklebust <trondmy@primarydata.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"davej@codemonkey.org.uk" <davej@codemonkey.org.uk>
Cc: "bfields@fieldses.org" <bfields@fieldses.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"schumaker.anna@gmail.com" <schumaker.anna@gmail.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [GIT PULL] Please pull NFS client changes for Linux 4.13
Date: Tue, 1 Aug 2017 17:58:38 +0000 [thread overview]
Message-ID: <1501610315.73115.1.camel@primarydata.com> (raw)
In-Reply-To: <20170801175031.74llpntgz3qirv3s@codemonkey.org.uk>
T24gVHVlLCAyMDE3LTA4LTAxIGF0IDEzOjUwIC0wNDAwLCBkYXZlakBjb2RlbW9ua2V5Lm9yZy51
ayB3cm90ZToNCj4gT24gVHVlLCBBdWcgMDEsIDIwMTcgYXQgMTA6MjA6MzFBTSAtMDcwMCwgTGlu
dXMgVG9ydmFsZHMgd3JvdGU6DQo+IA0KPiAgPiBTbyBJIHRoaW5rIHRoZSAncGF0aG5hbWUnIHBh
cnQgbWF5IGFjdHVhbGx5IGJlIGVudGlyZWx5IGEgcmVkDQo+IGhlcnJpbmcsDQo+ICA+IGFuZCBp
dCdzIHRoZSB1bmRlcmx5aW5nIGFjY2VzcyBpdHNlbGYgdGhhdCBqdXN0IHBpY2tzIHVwIGEgcmFu
ZG9tDQo+ICA+IHBvaW50ZXIgZnJvbSBhIHN0YWNrIHRoYXQgbm93IGNvbnRhaW5zIHNvbWV0aGlu
ZyBkaWZmZXJlbnQuIEFuZA0KPiBLQVNBTg0KPiAgPiBkaWRuJ3Qgbm90aWNlIHRoZSBzdGFsZSBz
dGFjayBhY2Nlc3MgaXRzZWxmLCBiZWNhdXNlIHRoZSBzdGFjaw0KPiBzbG90IGlzDQo+ICA+IHN0
aWxsIHZhbGlkIC0gaXQncyBqdXN0IG5vIGxvbmdlciB0aGUgb3JpZ2luYWwgJ3ZlcmlmaWVyJw0K
PiBhbGxvY2F0aW9uLg0KPiAgPiANCj4gID4gT3IgKnNvbWV0aGluZyogbGlrZSB0aGF0Lg0KPiAg
PiANCj4gID4gTm9uZSBvZiB0aGlzIGxvb2tzIGV2ZW4gcmVtb3RlbHkgbmV3LCB0aG91Z2ggLSB0
aGUgY29kZSBzZWVtcyB0bw0KPiBnbw0KPiAgPiBiYWNrIHRvIDIwMDkuIEhhdmUgeW91IGp1c3Qg
Y2hhbmdlZCB3aGF0IHlvdSdyZSB0ZXN0aW5nIHRvIHRyaWdnZXINCj4gID4gdGhlc2UgdGhpbmdz
Pw0KPiANCj4gTm8gaWRlYSB3aHkgaXQgb25seSBqdXN0IHNob3dlZCB1cCwgYnV0IGl0IGlzbid0
IDEwMCUgcmVwcm9kdWNhYmxlDQo+IGVpdGhlci4gIEEgbW9udGggb3Igc28gYWdvIEkgZGlkIGRp
c2FibGUgdGhlIFY0IGNvZGUgb24gdGhlIHNlcnZlcg0KPiBjb21wbGV0ZWx5IChhcyBJIHdhcyB1
c2luZyB2MyBldmVyeXdoZXJlIGVsc2UpLCBzbyBtYXliZSBJIHN0YXJ0ZWQNCj4gaGl0dGluZw0K
PiBhIGZhbGxiYWNrIHBhdGggc29tZXdoZXJlLiAgKnNocnVnKg0KPiANCg0KSSB3b3VsZCBvbmx5
IGV4cGVjdCB5b3UgdG9vIHNlZSBpdCBpZiB5b3UgaW50ZXJydXB0IHRoZSB3YWl0IG9uIHRoZQ0K
YXN5bmNocm9ub3VzIEVYQ0hBTkdFX0lEIGNhbGwgKHdoaWNoIHdvdWxkIGFsbG93IHRoZSBSUEMg
Y2FsbCB0bw0KY29udGludWUgd2hpbGUgdGhlIGNhbGxlciBzdGFjayBpcyB0cmFzaGVkKS4gUHJp
b3IgdG8gY29tbWl0DQo4ZDg5YmQ3MGJjOTM5LCB0aGF0IGNvZGUgcGF0aCB3YXMgZnVsbHkgc3lu
Y2hyb25vdXMsIHNvIHRoZXJlIHdhcyBubw0KaXNzdWUgd2l0aCBpbnRlcnJ1cHRpbmcgdGhlIGNh
bGwuDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIs
IFByaW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo=
WARNING: multiple messages have this Message-ID (diff)
From: Trond Myklebust <trondmy@primarydata.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"davej@codemonkey.org.uk" <davej@codemonkey.org.uk>
Cc: "bfields@fieldses.org" <bfields@fieldses.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"schumaker.anna@gmail.com" <schumaker.anna@gmail.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [GIT PULL] Please pull NFS client changes for Linux 4.13
Date: Tue, 1 Aug 2017 17:58:38 +0000 [thread overview]
Message-ID: <1501610315.73115.1.camel@primarydata.com> (raw)
In-Reply-To: <20170801175031.74llpntgz3qirv3s@codemonkey.org.uk>
On Tue, 2017-08-01 at 13:50 -0400, davej@codemonkey.org.uk wrote:
> On Tue, Aug 01, 2017 at 10:20:31AM -0700, Linus Torvalds wrote:
>
> > So I think the 'pathname' part may actually be entirely a red
> herring,
> > and it's the underlying access itself that just picks up a random
> > pointer from a stack that now contains something different. And
> KASAN
> > didn't notice the stale stack access itself, because the stack
> slot is
> > still valid - it's just no longer the original 'verifier'
> allocation.
> >
> > Or *something* like that.
> >
> > None of this looks even remotely new, though - the code seems to
> go
> > back to 2009. Have you just changed what you're testing to trigger
> > these things?
>
> No idea why it only just showed up, but it isn't 100% reproducable
> either. A month or so ago I did disable the V4 code on the server
> completely (as I was using v3 everywhere else), so maybe I started
> hitting
> a fallback path somewhere. *shrug*
>
I would only expect you too see it if you interrupt the wait on the
asynchronous EXCHANGE_ID call (which would allow the RPC call to
continue while the caller stack is trashed). Prior to commit
8d89bd70bc939, that code path was fully synchronous, so there was no
issue with interrupting the call.
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
next prev parent reply other threads:[~2017-08-01 17:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 21:16 [GIT PULL] Please pull NFS client changes for Linux 4.13 Anna Schumaker
2017-07-13 21:43 ` Linus Torvalds
2017-07-14 7:09 ` Christoph Hellwig
2017-07-14 11:33 ` Anna Schumaker
2017-07-14 14:25 ` Dave Jones
2017-07-14 16:36 ` J. Bruce Fields
2017-07-14 19:05 ` Linus Torvalds
2017-07-14 19:43 ` Andrey Ryabinin
2017-07-14 19:58 ` Linus Torvalds
2017-07-14 20:26 ` Andrey Rybainin
2017-07-14 20:38 ` Daniel Micay
2017-07-14 20:50 ` Linus Torvalds
2017-07-14 21:01 ` Daniel Micay
2017-07-14 21:05 ` Daniel Micay
2017-07-14 20:50 ` Daniel Micay
2017-07-14 23:59 ` Daniel Micay
2017-07-14 19:48 ` Dave Jones
2017-07-16 21:15 ` Dave Jones
2017-07-16 22:57 ` Trond Myklebust
2017-07-16 22:57 ` Trond Myklebust
2017-07-16 22:57 ` Trond Myklebust
2017-07-17 3:05 ` davej
2017-07-17 19:02 ` Linus Torvalds
2017-07-18 14:20 ` [GIT PULL] Please pull an nfsd bugfix for 4.13 bfields
2017-07-31 15:43 ` [GIT PULL] Please pull NFS client changes for Linux 4.13 davej
2017-08-01 5:35 ` Linus Torvalds
2017-08-01 15:51 ` davej
2017-08-01 17:20 ` Linus Torvalds
2017-08-01 17:30 ` Trond Myklebust
2017-08-01 17:30 ` Trond Myklebust
2017-08-01 17:50 ` davej
2017-08-01 17:58 ` Trond Myklebust [this message]
2017-08-01 17:58 ` Trond Myklebust
2017-08-01 17:53 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501610315.73115.1.camel@primarydata.com \
--to=trondmy@primarydata.com \
--cc=bfields@fieldses.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=schumaker.anna@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.