From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>
Cc: "pieter-paul.giesberts@broadcom.com"
<pieter-paul.giesberts@broadcom.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"arend.vanspriel@broadcom.com" <arend.vanspriel@broadcom.com>,
"hante.meuleman@broadcom.com" <hante.meuleman@broadcom.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"moritz.fischer@ettus.com" <moritz.fischer@ettus.com>,
"pjones@redhat.com" <pjones@redhat.com>,
"wagi@monom.org" <wagi@monom.org>,
"pmladek@suse.com" <pmladek@suse.com>,
"atull@kernel.org" <atull@kernel.org>,
"yi1.li@linux.intel.com" <yi1.li@linux.intel.com>,
"wright.feng@cypress.com" <wright.feng@cypress.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"luto@kernel.org" <luto@kernel.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"takahiro.akashi@linaro.org" <takahiro.akashi@linaro.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"rafal@milecki.pl" <rafal@milecki.pl>,
"Berg, Johannes" <johannes.berg@intel.com>,
"zajec5@gmail.com" <zajec5@gmail.com>,
"tytso@mit.edu" <tytso@mit.edu>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
"chi-hsien.lin@cypress.com" <chi-hsien.lin@cypress.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"franky.lin@broadcom.com" <franky.lin@broadcom.com>
Subject: Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function
Date: Thu, 3 Aug 2017 05:55:18 +0000 [thread overview]
Message-ID: <1501739717.15969.26.camel@intel.com> (raw)
In-Reply-To: <878tj1ql6z.fsf@kamboji.qca.qualcomm.com>
T24gVGh1LCAyMDE3LTA4LTAzIGF0IDA4OjIzICswMzAwLCBLYWxsZSBWYWxvIHdyb3RlOg0KPiAi
THVpcyBSLiBSb2RyaWd1ZXoiIDxtY2dyb2ZAa2VybmVsLm9yZz4gd3JpdGVzOg0KPiANCj4gPiA+
ICtpbnQgcmVxdWVzdF9maXJtd2FyZV9ub3dhaXQoc3RydWN0IG1vZHVsZSAqbW9kdWxlLCBib29s
IHVldmVudCwNCj4gPiA+ICsJCQkgICAgY29uc3QgY2hhciAqbmFtZSwgc3RydWN0IGRldmljZSAq
ZGV2aWNlLCBnZnBfdCBnZnAsDQo+ID4gPiArCQkJICAgIHZvaWQgKmNvbnRleHQsDQo+ID4gPiAr
CQkJICAgIHZvaWQgKCpjb250KShjb25zdCBzdHJ1Y3QgZmlybXdhcmUgKmZ3LCB2b2lkICpjb250
ZXh0KSkNCj4gPiA+ICt7DQo+ID4gPiArCXVuc2lnbmVkIGludCBvcHRfZmxhZ3MgPSBGV19PUFRf
RkFMTEJBQ0sgfA0KPiA+ID4gKwkJKHVldmVudCA/IEZXX09QVF9VRVZFTlQgOiBGV19PUFRfVVNF
UkhFTFBFUik7DQo+ID4gPiArDQo+ID4gPiArCXJldHVybiBfX3JlcXVlc3RfZmlybXdhcmVfbm93
YWl0KG1vZHVsZSwgb3B0X2ZsYWdzLCBuYW1lLCBkZXZpY2UsIGdmcCwNCj4gPiA+ICsJCQkJCSBj
b250ZXh0LCBjb250KTsNCj4gPiA+ICt9DQo+ID4gPiAgRVhQT1JUX1NZTUJPTChyZXF1ZXN0X2Zp
cm13YXJlX25vd2FpdCk7DQo+ID4gPiAgDQo+ID4gPiAraW50IF9fcmVxdWVzdF9maXJtd2FyZV9h
c3luYyhzdHJ1Y3QgbW9kdWxlICptb2R1bGUsIGNvbnN0IGNoYXIgKm5hbWUsDQo+ID4gPiArCQkJ
ICAgICBzdHJ1Y3QgZmlybXdhcmVfb3B0cyAqZndfb3B0cywgc3RydWN0IGRldmljZSAqZGV2LA0K
PiA+ID4gKwkJCSAgICAgdm9pZCAqY29udGV4dCwNCj4gPiA+ICsJCQkgICAgIHZvaWQgKCpjb250
KShjb25zdCBzdHJ1Y3QgZmlybXdhcmUgKmZ3LCB2b2lkICpjb250ZXh0KSkNCj4gPiA+ICt7DQo+
ID4gPiArCXVuc2lnbmVkIGludCBvcHRfZmxhZ3MgPSBGV19PUFRfVUVWRU5UOw0KPiA+IA0KPiA+
IFRoaXMgZXhwb3NlcyBhIGxvbmcgaXNzdWUuIFRoaW5rIC0tIHdoeSBkbyB3ZSB3YW50IHRoaXMg
ZW5hYmxlZCBieSBkZWZhdWx0PyBJdHMNCj4gPiBhY3R1YWxseSBiZWNhdXNlIGV2ZW4gdGhvdWdo
IHRoZSBmYWxsYmFjayBzdHVmZiBpcyBvcHRpb25hbCBhbmQgY2FuIGJlLCB0aGUgdWV2ZW50DQo+
ID4gaW50ZXJuYWwgZmxhZyAqYWxzbyogcHJvdmlkZXMgY2FjaGluZyBzdXBwb3J0IGFzIGEgc2lk
ZSBjb25zZXF1ZW5jZSBvbmx5LiBXZQ0KPiA+IGRvbid0IHdhbnQgdG8gYWRkIGEgbmV3IEFQSSB3
aXRob3V0IGZpcnN0IGNsZWFuaW5nIHVwIHRoYXQgbWVzcy4NCj4gPiANCj4gPiBUaGlzIGlzIGEg
c2xpcGVyeSBzbG9wZSBhbmQgYmVzdCB0byBjbGVhbiB0aGF0IHVwIGJlZm9yZSBhZGRpbmcgYW55
IG5ldyBBUEkuDQo+ID4gDQo+ID4gVGhhdCBhbmQgYWxzbyBHcmVnIHJlY2VudGx5IHN0YXRlZCBo
ZSB3b3VsZCBsaWtlIHRvIHNlZSBhdCBsZWFzdCAzIHVzZXJzIG9mDQo+ID4gYSBmZWF0dXJlIGJl
Zm9yZSBhZGRpbmcgaXQuIEFsdGhvdWdoIEkgdGhpbmsgdGhhdCdzIHByZXR0eSBhcmJpdHJhcnks
IGFuZA0KPiA+IGNvbnNpZGVyaW5nIHRoYXQgcmVxdWVzdF9maXJtd2FyZV9pbnRvX2J1ZigpIG9u
bHkgaGFzICpvbmUqIHVzZXIgLS0gaXRzIHdoYXQNCj4gPiBoZSB3aXNoZXMuDQo+IA0KPiBhdGgx
MGsgYXQgbGVhc3QgbmVlZHMgYSB3YXkgdG8gc2lsZW5jZSB0aGUgd2FybmluZyBmb3IgbWlzc2lu
ZyBmaXJtd2FyZQ0KPiBhbmQgSSB0aGluayBpd2x3aWZpIGFsc28uDQoNClllcywgaXdsd2lmaSBu
ZWVkcyB0byBzaWxlbmNlIHRoZSB3YXJuaW5nLiAgSXQgdGhlIGZlYXR1cmUgKG9ubHkgb25lLA0K
cmVhbGx5KSB0aGF0IEkndmUgYmVlbiB3YWl0aW5nIGZvci4NCg0KLS0NCkx1Y2Eu
WARNING: multiple messages have this Message-ID (diff)
From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>
Cc: "pieter-paul.giesberts@broadcom.com"
<pieter-paul.giesberts@broadcom.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"arend.vanspriel@broadcom.com" <arend.vanspriel@broadcom.com>,
"hante.meuleman@broadcom.com" <hante.meuleman@broadcom.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"moritz.fischer@ettus.com" <moritz.fischer@ettus.com>,
"pjones@redhat.com" <pjones@redhat.com>,
"wagi@monom.org" <wagi@monom.org>,
"pmladek@suse.com" <pmladek@suse.com>,
"atull@kernel.org" <atull@kernel.org>,
"yi1.li@linux.intel.com" <yi1.li@linux.intel.com>,
"wright.feng@cypress.com" <wright.feng@cypress.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"luto@kernel.org" <luto@kernel.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"takahiro.akashi@linaro.org" <takahiro.akashi@linaro.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"rafal@milecki.pl" <rafal@milecki.pl>,
"Berg, Johannes" <johannes.berg@intel.com>,
"zajec5@gmail.com" <zajec5@gmail.com>,
"tytso@mit.edu" <tytso@mit.edu>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
"chi-hsien.lin@cypress.com" <chi-hsien.lin@cypress.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"franky.lin@broadcom.com" <franky.lin@broadcom.com>
Subject: Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function
Date: Thu, 3 Aug 2017 05:55:18 +0000 [thread overview]
Message-ID: <1501739717.15969.26.camel@intel.com> (raw)
In-Reply-To: <878tj1ql6z.fsf@kamboji.qca.qualcomm.com>
On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote:
> "Luis R. Rodriguez" <mcgrof@kernel.org> writes:
>
> > > +int request_firmware_nowait(struct module *module, bool uevent,
> > > + const char *name, struct device *device, gfp_t gfp,
> > > + void *context,
> > > + void (*cont)(const struct firmware *fw, void *context))
> > > +{
> > > + unsigned int opt_flags = FW_OPT_FALLBACK |
> > > + (uevent ? FW_OPT_UEVENT : FW_OPT_USERHELPER);
> > > +
> > > + return __request_firmware_nowait(module, opt_flags, name, device, gfp,
> > > + context, cont);
> > > +}
> > > EXPORT_SYMBOL(request_firmware_nowait);
> > >
> > > +int __request_firmware_async(struct module *module, const char *name,
> > > + struct firmware_opts *fw_opts, struct device *dev,
> > > + void *context,
> > > + void (*cont)(const struct firmware *fw, void *context))
> > > +{
> > > + unsigned int opt_flags = FW_OPT_UEVENT;
> >
> > This exposes a long issue. Think -- why do we want this enabled by default? Its
> > actually because even though the fallback stuff is optional and can be, the uevent
> > internal flag *also* provides caching support as a side consequence only. We
> > don't want to add a new API without first cleaning up that mess.
> >
> > This is a slipery slope and best to clean that up before adding any new API.
> >
> > That and also Greg recently stated he would like to see at least 3 users of
> > a feature before adding it. Although I think that's pretty arbitrary, and
> > considering that request_firmware_into_buf() only has *one* user -- its what
> > he wishes.
>
> ath10k at least needs a way to silence the warning for missing firmware
> and I think iwlwifi also.
Yes, iwlwifi needs to silence the warning. It the feature (only one,
really) that I've been waiting for.
--
Luca.
WARNING: multiple messages have this Message-ID (diff)
From: "Coelho, Luciano" <luciano.coelho@intel.com>
To: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>
Cc: "pieter-paul.giesberts@broadcom.com"
<pieter-paul.giesberts@broadcom.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"arend.vanspriel@broadcom.com" <arend.vanspriel@broadcom.com>,
"hante.meuleman@broadcom.com" <hante.meuleman@broadcom.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"moritz.fischer@ettus.com" <moritz.fischer@ettus.com>,
"pjones@redhat.com" <pjones@redhat.com>,
"wagi@monom.org" <wagi@monom.org>,
"pmladek@suse.com" <pmladek@suse.com>,
"atull@kernel.org" <atull@kernel.org>,
"yi1.li@linux.intel.com" <yi1.li@linux.intel.com>,
"wright.feng@cypress.com" <wright.f
Subject: Re: [PATCH V5 1/2] firmware: add more flexible request_firmware_async function
Date: Thu, 3 Aug 2017 05:55:18 +0000 [thread overview]
Message-ID: <1501739717.15969.26.camel@intel.com> (raw)
In-Reply-To: <878tj1ql6z.fsf@kamboji.qca.qualcomm.com>
On Thu, 2017-08-03 at 08:23 +0300, Kalle Valo wrote:
> "Luis R. Rodriguez" <mcgrof@kernel.org> writes:
>
> > > +int request_firmware_nowait(struct module *module, bool uevent,
> > > + const char *name, struct device *device, gfp_t gfp,
> > > + void *context,
> > > + void (*cont)(const struct firmware *fw, void *context))
> > > +{
> > > + unsigned int opt_flags = FW_OPT_FALLBACK |
> > > + (uevent ? FW_OPT_UEVENT : FW_OPT_USERHELPER);
> > > +
> > > + return __request_firmware_nowait(module, opt_flags, name, device, gfp,
> > > + context, cont);
> > > +}
> > > EXPORT_SYMBOL(request_firmware_nowait);
> > >
> > > +int __request_firmware_async(struct module *module, const char *name,
> > > + struct firmware_opts *fw_opts, struct device *dev,
> > > + void *context,
> > > + void (*cont)(const struct firmware *fw, void *context))
> > > +{
> > > + unsigned int opt_flags = FW_OPT_UEVENT;
> >
> > This exposes a long issue. Think -- why do we want this enabled by default? Its
> > actually because even though the fallback stuff is optional and can be, the uevent
> > internal flag *also* provides caching support as a side consequence only. We
> > don't want to add a new API without first cleaning up that mess.
> >
> > This is a slipery slope and best to clean that up before adding any new API.
> >
> > That and also Greg recently stated he would like to see at least 3 users of
> > a feature before adding it. Although I think that's pretty arbitrary, and
> > considering that request_firmware_into_buf() only has *one* user -- its what
> > he wishes.
>
> ath10k at least needs a way to silence the warning for missing firmware
> and I think iwlwifi also.
Yes, iwlwifi needs to silence the warning. It the feature (only one,
really) that I've been waiting for.
--
Luca.
next prev parent reply other threads:[~2017-08-03 5:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 15:09 [PATCH V5 1/2] firmware: add more flexible request_firmware_async function Rafał Miłecki
2017-07-31 15:09 ` Rafał Miłecki
2017-07-31 15:09 ` [PATCH V5 2/2] brcmfmac: don't warn user about NVRAM if fallback to the platform one succeeds Rafał Miłecki
2017-07-31 15:09 ` Rafał Miłecki
2017-08-01 21:20 ` Arend van Spriel
2017-08-01 21:20 ` Arend van Spriel
2017-07-31 23:01 ` [PATCH V5 1/2] firmware: add more flexible request_firmware_async function kbuild test robot
2017-07-31 23:01 ` kbuild test robot
2017-08-02 21:30 ` Luis R. Rodriguez
2017-08-02 21:30 ` Luis R. Rodriguez
2017-08-03 5:23 ` Kalle Valo
2017-08-03 5:23 ` Kalle Valo
2017-08-03 5:55 ` Coelho, Luciano [this message]
2017-08-03 5:55 ` Coelho, Luciano
2017-08-03 5:55 ` Coelho, Luciano
2017-08-03 16:31 ` Luis R. Rodriguez
2017-08-03 16:31 ` Luis R. Rodriguez
2017-08-10 17:07 ` Luis R. Rodriguez
2017-08-10 17:07 ` Luis R. Rodriguez
2017-08-10 17:05 ` Luis R. Rodriguez
2017-08-10 17:05 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501739717.15969.26.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=alan@linux.intel.com \
--cc=arend.vanspriel@broadcom.com \
--cc=atull@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chi-hsien.lin@cypress.com \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=emmanuel.grumbach@intel.com \
--cc=franky.lin@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hante.meuleman@broadcom.com \
--cc=hdegoede@redhat.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mcgrof@kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=netdev@vger.kernel.org \
--cc=pieter-paul.giesberts@broadcom.com \
--cc=pjones@redhat.com \
--cc=pmladek@suse.com \
--cc=rafal@milecki.pl \
--cc=rjw@rjwysocki.net \
--cc=takahiro.akashi@linaro.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=wagi@monom.org \
--cc=wright.feng@cypress.com \
--cc=yi1.li@linux.intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.