All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] constify thermal_zone_of_device_ops structures
Date: Tue, 08 Aug 2017 13:43:58 +0000	[thread overview]
Message-ID: <1502199838.4296.64.camel@intel.com> (raw)
In-Reply-To: <1501965437-30730-1-git-send-email-Julia.Lawall@lip6.fr>

On Sat, 2017-08-05 at 22:37 +0200, Julia Lawall wrote:
> The thermal_zone_of_device_ops structures are only passed as the
> fourth
> argument to thermal_zone_of_sensor_register, which is declared as
> const.
> Thus the thermal_zone_of_device_ops structures themselves can be
> const.
> 
> Done with the help of Coccinelle.

I still see the same problem in other thermal drivers, which is not
covered by this patch set. Can we fix them all in one time?

thanks,
rui
> 
> ---
> 
>  drivers/thermal/broadcom/bcm2835_thermal.c |    2 +-
>  drivers/thermal/qoriq_thermal.c            |    2 +-
>  drivers/thermal/samsung/exynos_tmu.c       |    2 +-
>  drivers/thermal/zx2967_thermal.c           |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: Zhang Rui <rui.zhang@intel.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>,
	linux-arm-kernel@lists.infradead.org
Cc: bhumirks@gmail.com, kernel-janitors@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, Eduardo Valentin <edubezval@gmail.com>,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] constify thermal_zone_of_device_ops structures
Date: Tue, 08 Aug 2017 21:43:58 +0800	[thread overview]
Message-ID: <1502199838.4296.64.camel@intel.com> (raw)
In-Reply-To: <1501965437-30730-1-git-send-email-Julia.Lawall@lip6.fr>

On Sat, 2017-08-05 at 22:37 +0200, Julia Lawall wrote:
> The thermal_zone_of_device_ops structures are only passed as the
> fourth
> argument to thermal_zone_of_sensor_register, which is declared as
> const.
> Thus the thermal_zone_of_device_ops structures themselves can be
> const.
> 
> Done with the help of Coccinelle.

I still see the same problem in other thermal drivers, which is not
covered by this patch set. Can we fix them all in one time?

thanks,
rui
> 
> ---
> 
>  drivers/thermal/broadcom/bcm2835_thermal.c |    2 +-
>  drivers/thermal/qoriq_thermal.c            |    2 +-
>  drivers/thermal/samsung/exynos_tmu.c       |    2 +-
>  drivers/thermal/zx2967_thermal.c           |    2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)

WARNING: multiple messages have this Message-ID (diff)
From: rui.zhang@intel.com (Zhang Rui)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] constify thermal_zone_of_device_ops structures
Date: Tue, 08 Aug 2017 21:43:58 +0800	[thread overview]
Message-ID: <1502199838.4296.64.camel@intel.com> (raw)
In-Reply-To: <1501965437-30730-1-git-send-email-Julia.Lawall@lip6.fr>

On Sat, 2017-08-05 at 22:37 +0200, Julia Lawall wrote:
> The thermal_zone_of_device_ops structures are only passed as the
> fourth
> argument to thermal_zone_of_sensor_register, which is declared as
> const.
> Thus the thermal_zone_of_device_ops structures themselves can be
> const.
> 
> Done with the help of Coccinelle.

I still see the same problem in other thermal drivers, which is not
covered by this patch set. Can we fix them all in one time?

thanks,
rui
> 
> ---
> 
> ?drivers/thermal/broadcom/bcm2835_thermal.c |????2 +-
> ?drivers/thermal/qoriq_thermal.c????????????|????2 +-
> ?drivers/thermal/samsung/exynos_tmu.c???????|????2 +-
> ?drivers/thermal/zx2967_thermal.c???????????|????2 +-
> ?4 files changed, 4 insertions(+), 4 deletions(-)

  parent reply	other threads:[~2017-08-08 13:43 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-05 20:37 [PATCH 0/4] constify thermal_zone_of_device_ops structures Julia Lawall
2017-08-05 20:37 ` Julia Lawall
2017-08-05 20:37 ` Julia Lawall
2017-08-05 20:37 ` [PATCH 1/4] thermal: qoriq: " Julia Lawall
2017-08-05 20:37   ` Julia Lawall
2017-08-05 20:37 ` [PATCH 2/4] thermal: zx2967: " Julia Lawall
2017-08-05 20:37   ` Julia Lawall
2017-08-05 20:37 ` [PATCH 3/4] thermal: exynos: " Julia Lawall
2017-08-05 20:37   ` Julia Lawall
2017-08-05 20:37   ` Julia Lawall
2017-08-07 15:21   ` Bartlomiej Zolnierkiewicz
2017-08-07 15:21     ` Bartlomiej Zolnierkiewicz
2017-08-07 15:21     ` Bartlomiej Zolnierkiewicz
2017-08-05 20:37 ` [PATCH 4/4] thermal: bcm2835: " Julia Lawall
2017-08-05 20:37   ` Julia Lawall
2017-08-05 20:37   ` Julia Lawall
2017-08-07  6:41   ` Stefan Wahren
2017-08-07  6:41     ` Stefan Wahren
2017-08-07  6:41     ` Stefan Wahren
2017-08-08 13:43 ` Zhang Rui [this message]
2017-08-08 13:43   ` [PATCH 0/4] " Zhang Rui
2017-08-08 13:43   ` Zhang Rui
2017-08-08 13:46   ` Julia Lawall
2017-08-08 13:46     ` Julia Lawall
2017-08-08 13:46     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502199838.4296.64.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.