From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Linux PM <linux-pm@vger.kernel.org>,
Mario Limonciello <mario.limonciello@dell.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only
Date: Sat, 12 Aug 2017 17:00:22 -0700 [thread overview]
Message-ID: <1502582422.20268.53.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0iDkeCYigzY-jDyUonyDRhVuJtSmKa8qjSk0vdiPvV-EA@mail.gmail.com>
On Sun, 2017-08-13 at 00:37 +0200, Rafael J. Wysocki wrote:
> On Sat, Aug 12, 2017 at 5:59 PM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> >
> > On Sat, 2017-08-12 at 16:27 +0200, Rafael J. Wysocki wrote:
> > [...]
> >
> > >
> > > >
> > > > +
> > > > +struct lpi_constraints {
> > > > + char *name;
> > > > + int min_dstate;
> > > If you store the handle here as well, you won't need to
> > > look it up every time _check_constraints() is called.
> > The reason I didn't keep handle here, I thought handle can be stale
> > or
> > change for PnP device on plug in and out. Is this not true?
> The handles don't go away on hot remove as a rule. That may only
> happen if tables get unloaded, but basically the constraints should
> not point to anything in a table that may go away.
So we don't need to worry about this case where tables gets unloaded
and replaced? This is in a debug path, so additional overhead of path
to handle conversion may not be significant.
Thanks,
Srinivas
next prev parent reply other threads:[~2017-08-13 0:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 18:23 [PATCH v3] ACPI / Sleep: Check low power idle constraints for debug only Srinivas Pandruvada
2017-08-12 14:27 ` Rafael J. Wysocki
2017-08-12 15:59 ` Srinivas Pandruvada
2017-08-12 22:37 ` Rafael J. Wysocki
2017-08-13 0:00 ` Srinivas Pandruvada [this message]
2017-08-13 0:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502582422.20268.53.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.