[PATCH v1 1/2] hyperv: Include linux/types.h to avoid build break

[PATCH v1 1/2] hyperv: Include linux/types.h to avoid build break

[Andy Shevchenko]

The commit 2ffd9e33ce4a

    ("x86/hyper-v: Use hypercall for remote TLB flush")

introduced a new C-file where uapi/linux/hyperv.h is included first.

This makes build failed since UAPI headers are heavily dependent to special
types of variables, e.g. __u8.

  CC      arch/x86/hyperv/mmu.o
In file included from include/linux/hyperv.h:28:0,
                 from arch/x86/hyperv/mmu.c:3:
include/uapi/linux/hyperv.h:71:2: error: unknown type name ‘__u8’
  __u8 operation;
  ^~~~

Include linux/types.h to the UAPI header like many others do.

Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/uapi/linux/hyperv.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
index 7560c0aa60e3..aaf32131b556 100644
--- a/include/uapi/linux/hyperv.h
+++ b/include/uapi/linux/hyperv.h
@@ -25,6 +25,8 @@
 #ifndef _UAPI_HYPERV_H
 #define _UAPI_HYPERV_H
 
+#include <linux/types.h>
+
 /*
  * Framework version for util services.
  */
-- 
2.13.2

[PATCH v1 2/2] MAINTAINERS: Add missed file for Hyper-V

[Andy Shevchenko]

include/uapi/linux/hyperv.h is a part of Hyper-V support.

Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index acf95f158b97..ab96ea3003ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6314,6 +6314,7 @@ F:	drivers/scsi/storvsc_drv.c
 F:	drivers/uio/uio_hv_generic.c
 F:	drivers/video/fbdev/hyperv_fb.c
 F:	include/linux/hyperv.h
+F:	include/uapi/linux/hyperv.h
 F:	tools/hv/
 F:	Documentation/ABI/stable/sysfs-bus-vmbus
 
-- 
2.13.2

[tip:x86/platform] MAINTAINERS: Add missed file for Hyper-V

[tip-bot for Andy Shevchenko]

Commit-ID:  db46e14f8a3c2657b8f777d422d7dfc7e61e52e9
Gitweb:     http://git.kernel.org/tip/db46e14f8a3c2657b8f777d422d7dfc7e61e52e9
Author:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
AuthorDate: Sun, 13 Aug 2017 16:34:44 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 14 Aug 2017 12:45:39 +0200

MAINTAINERS: Add missed file for Hyper-V

include/uapi/linux/hyperv.h is a part of Hyper-V support.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: devel@linuxdriverproject.org
Link: http://lkml.kernel.org/r/20170813133444.23386-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 84d6a82..e99c748 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6270,6 +6270,7 @@ F:	drivers/scsi/storvsc_drv.c
 F:	drivers/uio/uio_hv_generic.c
 F:	drivers/video/fbdev/hyperv_fb.c
 F:	include/linux/hyperv.h
+F:	include/uapi/linux/hyperv.h
 F:	tools/hv/
 F:	Documentation/ABI/stable/sysfs-bus-vmbus
 

Re: [PATCH v1 1/2] hyperv: Include linux/types.h to avoid build break

[Andy Shevchenko]

On Sun, 2017-08-13 at 16:34 +0300, Andy Shevchenko wrote:
> The commit 2ffd9e33ce4a
> 
>     ("x86/hyper-v: Use hypercall for remote TLB flush")
> 
> introduced a new C-file where uapi/linux/hyperv.h is included first.
> 
> This makes build failed since UAPI headers are heavily dependent to
> special
> types of variables, e.g. __u8.
> 
>   CC      arch/x86/hyperv/mmu.o
> In file included from include/linux/hyperv.h:28:0,
>                  from arch/x86/hyperv/mmu.c:3:
> include/uapi/linux/hyperv.h:71:2: error: unknown type name ‘__u8’
>   __u8 operation;
>   ^~~~
> 
> Include linux/types.h to the UAPI header like many others do.
> 

Oops, it's because I have an update to this file in my local uuid
branch.

In any case this is right thing to do independently of uuid.h inclusion.

Please, ignore this patch for now, but note the second one is still
valid.

> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  include/uapi/linux/hyperv.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
> index 7560c0aa60e3..aaf32131b556 100644
> --- a/include/uapi/linux/hyperv.h
> +++ b/include/uapi/linux/hyperv.h
> @@ -25,6 +25,8 @@
>  #ifndef _UAPI_HYPERV_H
>  #define _UAPI_HYPERV_H
>  
> +#include <linux/types.h>
> +
>  /*
>   * Framework version for util services.
>   */

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy