[meta-oe][master][pyro] 1/2] libmtp: fix build issue

[meta-oe][master][pyro] 1/2] libmtp: fix build issue

[Armin Kuster]

DEBUG: Executing shell function BUILDSPEC
| error: line 109: %package -n mtp-tools: package mtp-tools already exists

Yes, there are two entries in libmtp.spec. Under packages-split, mtp-tools is empty but
libmtp-bin is not.

Removed PKG_${PN}-bin , this alignes how Debian split its packages

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb b/meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb
index b5df8e0..c05ff4e 100644
--- a/meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb
+++ b/meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb
@@ -50,9 +50,6 @@ PACKAGES =+ "libmtp-common libmtp-runtime mtp-tools"
 RDEPENDS_${PN} += "libmtp-common"
 RRECOMMENDS_${PN} += "libmtp-runtime mtp-tools"
 FILES_${PN}-dbg += "${nonarch_base_libdir}/udev/.debug/*"
-PKG_${PN}-bin = "mtp-tools"
-SUMMARY_${PN}-bin = "Tools for communicating with MTP devices"
-DESCRIPTION_${PN}-bin = "${DESCRIPTION}\nThis package contains tools for communicating with MTP devices."
 FILES_libmtp-common = "${nonarch_base_libdir}/udev/rules.d/*"
 SUMMARY_libmtp-common = "The udev rules file for MTP devices"
 FILES_libmtp-runtime = "${nonarch_base_libdir}/udev/mtp-probe"
-- 
2.7.4

[meta-oe][master][pyro] 2/2] libexecinfo: fix complie issue

[Armin Kuster]

define _GNU_SOURCES to fix compile issue:
 execinfo.c:76:5: error: unknown type name 'Dl_info'
|      Dl_info info;
|      ^~~~~~~
| execinfo.c:83:13: warning: implicit declaration of function 'dladdr' [-Wimplicit-function-declaration]
|          if (dladdr(buffer[i], &info) != 0) {

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb b/meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb
index f79b1ab..13a38ab 100644
--- a/meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb
+++ b/meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb
@@ -16,6 +16,7 @@ SRC_URI[md5sum] = "8e9e81c554c1c5d735bc877448e92b91"
 SRC_URI[sha256sum] = "c9a21913e7fdac8ef6b33250b167aa1fc0a7b8a175145e26913a4c19d8a59b1f"
 
 CFLAGS += "-fno-omit-frame-pointer"
+CFLAGS += " -D_GNU_SOURCE"
 
 do_install() {
     install -D -m 0744 ${S}/execinfo.h ${D}${includedir}/execinfo.h
-- 
2.7.4

Re: [meta-oe][master][pyro] 2/2] libexecinfo: fix complie issue

[Khem Raj]

On Sun, Aug 13, 2017 at 9:24 AM, Armin Kuster <akuster808@gmail.com> wrote:
> define _GNU_SOURCES to fix compile issue:
>  execinfo.c:76:5: error: unknown type name 'Dl_info'
> |      Dl_info info;
> |      ^~~~~~~
> | execinfo.c:83:13: warning: implicit declaration of function 'dladdr' [-Wimplicit-function-declaration]
> |          if (dladdr(buffer[i], &info) != 0) {
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb b/meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb
> index f79b1ab..13a38ab 100644
> --- a/meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb
> +++ b/meta-oe/recipes-extended/libexecinfo/libexecinfo_1.1.bb
> @@ -16,6 +16,7 @@ SRC_URI[md5sum] = "8e9e81c554c1c5d735bc877448e92b91"
>  SRC_URI[sha256sum] = "c9a21913e7fdac8ef6b33250b167aa1fc0a7b8a175145e26913a4c19d8a59b1f"
>
>  CFLAGS += "-fno-omit-frame-pointer"
> +CFLAGS += " -D_GNU_SOURCE"

Please merge it into existing assignment above. Unrelated to this
patch, this recipe should
move to oe-core.

>
>  do_install() {
>      install -D -m 0744 ${S}/execinfo.h ${D}${includedir}/execinfo.h
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe][master][pyro] 1/2] libmtp: fix build issue

[Martin Jansa]

The subject doesn't contain PATCH, that's probably the reason why both
these patches, didn't make it to patchwork, please resend.

On Sun, Aug 13, 2017 at 6:24 PM, Armin Kuster <akuster808@gmail.com> wrote:

> DEBUG: Executing shell function BUILDSPEC
> | error: line 109: %package -n mtp-tools: package mtp-tools already exists
>
> Yes, there are two entries in libmtp.spec. Under packages-split, mtp-tools
> is empty but
> libmtp-bin is not.
>
> Removed PKG_${PN}-bin , this alignes how Debian split its packages
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb
> b/meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb
> index b5df8e0..c05ff4e 100644
> --- a/meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb
> +++ b/meta-oe/recipes-connectivity/libmtp/libmtp_1.1.5.bb
> @@ -50,9 +50,6 @@ PACKAGES =+ "libmtp-common libmtp-runtime mtp-tools"
>  RDEPENDS_${PN} += "libmtp-common"
>  RRECOMMENDS_${PN} += "libmtp-runtime mtp-tools"
>  FILES_${PN}-dbg += "${nonarch_base_libdir}/udev/.debug/*"
> -PKG_${PN}-bin = "mtp-tools"
> -SUMMARY_${PN}-bin = "Tools for communicating with MTP devices"
> -DESCRIPTION_${PN}-bin = "${DESCRIPTION}\nThis package contains tools for
> communicating with MTP devices."
>  FILES_libmtp-common = "${nonarch_base_libdir}/udev/rules.d/*"
>  SUMMARY_libmtp-common = "The udev rules file for MTP devices"
>  FILES_libmtp-runtime = "${nonarch_base_libdir}/udev/mtp-probe"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>