Re: [PATCH] genericx86-common.inc: Stop autoloading uvesa module at boot

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2017-08-16 at 17:25 -0700, Alejandro Hernandez wrote:
> After commit e8b1c653946ef921b65d47e52aea0dc530ef4286, we started
> seeing
> errors like the following during boot:
> 
> uvesafb: failed to execute /sbin/v86d
> uvesafb: probe of uvesafb.0 failed with error -22
> uvesafb: vbe_init() failed with -22
> uvesafb: Getting VBE info block failed (eax=0x4f00, err=-2)
> 
> These were caused because the uvesa module was being loaded during
> boot.
> 
> Since genericx86-common.inc includes qemuboot-x86, the module also
> tries
> to be loaded on genericx86 MACHINES, this patch removes it when this
> is the
> case, getting rid of the errors.
> 
> [YOCTO #11879]
> 
> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.c
> om>
> ---
>  meta-yocto-bsp/conf/machine/include/genericx86-common.inc | 3 +++
>  1 file changed, 3 insertions(+)

No, we can't do this, sorry. I really dislike having any usage of
remove in the core code. The reason is that its near impossible to undo
a remove operation and if we need one, it suggests we really should
restructure something instead.

So please find a different way to fix this.

This commit message also doesn't really tell me why we need to stop
loading uvesa on genericx86.

Cheers,

Richard