From: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
poky@yoctoproject.org
Subject: Re: [PATCH] genericx86-common.inc: Stop autoloading uvesa module at boot
Date: Thu, 17 Aug 2017 02:48:27 -0500 [thread overview]
Message-ID: <7971a3f5-95a9-84fa-5a2c-c853e1a15714@linux.intel.com> (raw)
In-Reply-To: <1502955747.13978.184.camel@linuxfoundation.org>
Hey Richard,
On 08/17/2017 02:42 AM, Richard Purdie wrote:
> On Wed, 2017-08-16 at 17:25 -0700, Alejandro Hernandez wrote:
>> After commit e8b1c653946ef921b65d47e52aea0dc530ef4286, we started
>> seeing
>> errors like the following during boot:
>>
>> uvesafb: failed to execute /sbin/v86d
>> uvesafb: probe of uvesafb.0 failed with error -22
>> uvesafb: vbe_init() failed with -22
>> uvesafb: Getting VBE info block failed (eax=0x4f00, err=-2)
>>
>> These were caused because the uvesa module was being loaded during
>> boot.
>>
>> Since genericx86-common.inc includes qemuboot-x86, the module also
>> tries
>> to be loaded on genericx86 MACHINES, this patch removes it when this
>> is the
>> case, getting rid of the errors.
>>
>> [YOCTO #11879]
>>
>> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.c
>> om>
>> ---
>> meta-yocto-bsp/conf/machine/include/genericx86-common.inc | 3 +++
>> 1 file changed, 3 insertions(+)
> No, we can't do this, sorry. I really dislike having any usage of
> remove in the core code. The reason is that its near impossible to undo
> a remove operation and if we need one, it suggests we really should
> restructure something instead.
>
> So please find a different way to fix this.
>
> This commit message also doesn't really tell me why we need to stop
> loading uvesa on genericx86.
Alright, I'll see if I can find another way, the reason being that it
simply gets rid of the error,
I actually referenced the commit where we took uvesa out of generic but
I deleted it last minute,
my bad.
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=6af89812e8a9931ffed63768ed85367519bf7aef
>
> Cheers,
>
> Richard
prev parent reply other threads:[~2017-08-17 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 0:25 [PATCH] genericx86-common.inc: Stop autoloading uvesa module at boot Alejandro Hernandez
2017-08-17 7:42 ` Richard Purdie
2017-08-17 7:48 ` Alejandro Hernandez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7971a3f5-95a9-84fa-5a2c-c853e1a15714@linux.intel.com \
--to=alejandro.hernandez@linux.intel.com \
--cc=poky@yoctoproject.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.