[PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

[PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

[liu.ming50]

From: Ming Liu <peter.x.liu@external.atlascopco.com>

To give a example:
Before the change, in our build console, TUNE_FEATURES looks like:
...
TUNE_FEATURES     = "arm armv7a vfp  neon        cortexa8"
...

After the change:
...
TUNE_FEATURES     = "arm armv7a vfp neon cortexa8"
...

Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
---
 meta/classes/base.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 8c86977..07734ac 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -206,7 +206,7 @@ def buildcfg_vars(d):
     for var in statusvars:
         value = d.getVar(var)
         if value is not None:
-            yield '%-17s = "%s"' % (var, value)
+            yield '%-17s = "%s"' % (var, " ".join(value.split()))
 
 def buildcfg_neededvars(d):
     needed_vars = oe.data.typed_value("BUILDCFG_NEEDEDVARS", d)
-- 
2.7.4

Re: [PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

[Andre McCurdy]

On Mon, Aug 21, 2017 at 4:43 AM,  <liu.ming50@gmail.com> wrote:
> From: Ming Liu <peter.x.liu@external.atlascopco.com>
>
> To give a example:
> Before the change, in our build console, TUNE_FEATURES looks like:
> ...
> TUNE_FEATURES     = "arm armv7a vfp  neon        cortexa8"
> ...
>
> After the change:
> ...
> TUNE_FEATURES     = "arm armv7a vfp neon cortexa8"
> ...
>
> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> ---
>  meta/classes/base.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 8c86977..07734ac 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -206,7 +206,7 @@ def buildcfg_vars(d):
>      for var in statusvars:
>          value = d.getVar(var)
>          if value is not None:
> -            yield '%-17s = "%s"' % (var, value)
> +            yield '%-17s = "%s"' % (var, " ".join(value.split()))

This fix has been rejected once already:

  http://lists.openembedded.org/pipermail/openembedded-core/2016-November/129358.html

The preferred alternative was to remove all duplicated whitespace in
the BUILDCFG_VARS variables:

  http://git.openembedded.org/openembedded-core/commit/?id=5610c6397ee098dd998b7417b343494de77179f9
  http://git.openembedded.org/openembedded-core/commit/?id=971e43270173afb08f21ffac16a4157f7e611b81

>  def buildcfg_neededvars(d):
>      needed_vars = oe.data.typed_value("BUILDCFG_NEEDEDVARS", d)
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

[Ming Liu]

[-- Attachment #1: Type: text/plain, Size: 2360 bytes --]

Hi, Andre:

Arha, I did not know that when I was submitting the patch, may I know why
it's rejected at that moment? Since even with the alternative fixes, the
developers still could introduce duplicated whitespaces in their BSP layers
if they do not know the rules, since it's quite common in recipes to assign
variables with duplicated whitespcaces.

BTW: i just checked, it's been merged to master already.

//Ming Liu

2017-08-23 4:19 GMT+02:00 Andre McCurdy <armccurdy@gmail.com>:

> On Mon, Aug 21, 2017 at 4:43 AM,  <liu.ming50@gmail.com> wrote:
> > From: Ming Liu <peter.x.liu@external.atlascopco.com>
> >
> > To give a example:
> > Before the change, in our build console, TUNE_FEATURES looks like:
> > ...
> > TUNE_FEATURES     = "arm armv7a vfp  neon        cortexa8"
> > ...
> >
> > After the change:
> > ...
> > TUNE_FEATURES     = "arm armv7a vfp neon cortexa8"
> > ...
> >
> > Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> > ---
> >  meta/classes/base.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > index 8c86977..07734ac 100644
> > --- a/meta/classes/base.bbclass
> > +++ b/meta/classes/base.bbclass
> > @@ -206,7 +206,7 @@ def buildcfg_vars(d):
> >      for var in statusvars:
> >          value = d.getVar(var)
> >          if value is not None:
> > -            yield '%-17s = "%s"' % (var, value)
> > +            yield '%-17s = "%s"' % (var, " ".join(value.split()))
>
> This fix has been rejected once already:
>
>   http://lists.openembedded.org/pipermail/openembedded-core/
> 2016-November/129358.html
>
> The preferred alternative was to remove all duplicated whitespace in
> the BUILDCFG_VARS variables:
>
>   http://git.openembedded.org/openembedded-core/commit/?id=
> 5610c6397ee098dd998b7417b343494de77179f9
>   http://git.openembedded.org/openembedded-core/commit/?id=
> 971e43270173afb08f21ffac16a4157f7e611b81
>
> >  def buildcfg_neededvars(d):
> >      needed_vars = oe.data.typed_value("BUILDCFG_NEEDEDVARS", d)
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 4918 bytes --]

Re: [PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

[Richard Purdie]

On Wed, 2017-08-23 at 04:33 +0200, Ming Liu wrote:
> Hi, Andre:
> 
> Arha, I did not know that when I was submitting the patch, may I know
> why it's rejected at that moment? Since even with the alternative
> fixes, the developers still could introduce duplicated whitespaces in
> their BSP layers if they do not know the rules, since it's quite
> common in recipes to assign variables with duplicated whitespcaces.
> 
> BTW: i just checked, it's been merged to master already.

No, it hasn't.

Cheers,

Richard

Re: [PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

[Ming Liu]

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

Hi,

Yes, it's in master-next not in master branch, but wouldn't that mean it's
accepted as a proper fix, or?

//Ming Liu

2017-08-23 9:50 GMT+02:00 Richard Purdie <richard.purdie@linuxfoundation.org
>:

> On Wed, 2017-08-23 at 04:33 +0200, Ming Liu wrote:
> > Hi, Andre:
> >
> > Arha, I did not know that when I was submitting the patch, may I know
> > why it's rejected at that moment? Since even with the alternative
> > fixes, the developers still could introduce duplicated whitespaces in
> > their BSP layers if they do not know the rules, since it's quite
> > common in recipes to assign variables with duplicated whitespcaces.
> >
> > BTW: i just checked, it's been merged to master already.
>
> No, it hasn't.
>
> Cheers,
>
> Richard
>

[-- Attachment #2: Type: text/html, Size: 1228 bytes --]

Re: [PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

[Richard Purdie]

On Wed, 2017-08-23 at 09:57 +0200, Ming Liu wrote:
> Yes, it's in master-next not in master branch, but wouldn't that mean
> it's accepted as a proper fix, or?

It means it was queued for testing, I've dropped it from master-next
now as the comments from Chris still apply from last time.

Cheers,

Richard

Re: [PATCH] base.bbclass: trim duplicated whitespaces from BUILDCFG_VARS

[Ming Liu]

[-- Attachment #1: Type: text/plain, Size: 627 bytes --]

Hi, Richard:

OK, understood.

So for this kind of issues, the BSP developers should pay attention by
themselves not to introduce any duplicated whitespaces in their meta-xxx
layers?

//Ming Liu

2017-08-23 9:59 GMT+02:00 Richard Purdie <richard.purdie@linuxfoundation.org
>:

> On Wed, 2017-08-23 at 09:57 +0200, Ming Liu wrote:
> > Yes, it's in master-next not in master branch, but wouldn't that mean
> > it's accepted as a proper fix, or?
>
> It means it was queued for testing, I've dropped it from master-next
> now as the comments from Chris still apply from last time.
>
> Cheers,
>
> Richard
>

[-- Attachment #2: Type: text/html, Size: 1058 bytes --]