All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Bhumika Goyal <bhumirks@gmail.com>,
	julia.lawall@lip6.fr, marcel@holtmann.org, gustavo@padovan.org,
	johan.hedberg@gmail.com, davem@davemloft.net,
	pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de,
	stephen@networkplumber.org, alex.aring@gmail.com,
	stefan@osg.samsung.com, kuznet@ms2.inr.ac.ru,
	yoshfuji@linux-ipv6.org, santosh.shilimkar@oracle.com,
	trond.myklebust@primarydata.com, anna.schumaker@netapp.com,
	bfields@fieldses.org, linux-bluetooth@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	bridge@lists.linux-foundation.org, linux-wpan@vger.kernel.org,
	linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
	linux-nfs@vger.kernel.org
Subject: Re: [Bridge] [PATCH 7/7] SUNRPC: make kvec const
Date: Fri, 25 Aug 2017 14:49:23 -0000	[thread overview]
Message-ID: <1503672536.4722.20.camel@redhat.com> (raw)
In-Reply-To: <1503670907-23221-8-git-send-email-bhumirks@gmail.com>

On Fri, 2017-08-25 at 19:51 +0530, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  net/sunrpc/xdr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e34f4ee..a096025 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
>  }
>  EXPORT_SYMBOL_GPL(xdr_enter_page);
>  
> -static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
> +static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
>  
>  void
>  xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)

Reviewed-by: Jeff Layton <jlayton@redhat.com>

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Layton <jlayton@redhat.com>
To: Bhumika Goyal <bhumirks@gmail.com>,
	julia.lawall@lip6.fr, marcel@holtmann.org, gustavo@padovan.org,
	johan.hedberg@gmail.com, davem@davemloft.net,
	pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de,
	 stephen@networkplumber.org, alex.aring@gmail.com,
	stefan@osg.samsung.com,  kuznet@ms2.inr.ac.ru,
	yoshfuji@linux-ipv6.org, santosh.shilimkar@oracle.com,
	 trond.myklebust@primarydata.com, anna.schumaker@netapp.com,
	bfields@fieldses.org, linux-bluetooth@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	bridge@lists.linux-foundation.org, linux-wpan@vger.kernel.org,
	linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
	 linux-nfs@vger.kernel.org
Subject: Re: [PATCH 7/7] SUNRPC: make kvec const
Date: Fri, 25 Aug 2017 10:48:56 -0400	[thread overview]
Message-ID: <1503672536.4722.20.camel@redhat.com> (raw)
In-Reply-To: <1503670907-23221-8-git-send-email-bhumirks@gmail.com>

On Fri, 2017-08-25 at 19:51 +0530, Bhumika Goyal wrote:
> Make this const as it is only used during a copy operation.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  net/sunrpc/xdr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index e34f4ee..a096025 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -998,7 +998,7 @@ void xdr_enter_page(struct xdr_stream *xdr, unsigned int len)
>  }
>  EXPORT_SYMBOL_GPL(xdr_enter_page);
>  
> -static struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
> +static const struct kvec empty_iov = {.iov_base = NULL, .iov_len = 0};
>  
>  void
>  xdr_buf_from_iov(struct kvec *iov, struct xdr_buf *buf)

Reviewed-by: Jeff Layton <jlayton@redhat.com>

  reply	other threads:[~2017-08-25 14:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25 14:21 [PATCH 0/7] net: make some structures const Bhumika Goyal
2017-08-25 14:22 ` [Bridge] " Bhumika Goyal
2017-08-25 14:21 ` [PATCH 1/7] Bluetooth: 6lowpan: make header_ops const Bhumika Goyal
2017-08-25 14:22   ` [Bridge] " Bhumika Goyal
2017-08-25 14:21 ` [PATCH 2/7] bridge: make ebt_table const Bhumika Goyal
2017-08-25 14:23   ` [Bridge] " Bhumika Goyal
2017-08-28 18:30   ` David Miller
2017-08-28 18:30     ` David Miller
2017-08-25 14:21 ` [PATCH 3/7] ieee802154: 6lowpan: make header_ops const Bhumika Goyal
2017-08-25 14:23   ` [Bridge] " Bhumika Goyal
2017-08-25 14:36   ` Stefan Schmidt
2017-08-25 14:39     ` [Bridge] " Stefan Schmidt
2017-08-25 16:17   ` Marcel Holtmann
2017-08-25 16:17     ` Marcel Holtmann
2017-08-25 16:17     ` Marcel Holtmann
2017-08-25 14:21 ` [PATCH 4/7] ipv4: make net_protocol const Bhumika Goyal
2017-08-25 14:23   ` [Bridge] " Bhumika Goyal
2017-08-28 18:30   ` David Miller
2017-08-28 18:30     ` David Miller
2017-08-25 14:21 ` [PATCH 5/7] RDS: make rhashtable_params const Bhumika Goyal
2017-08-25 14:24   ` [Bridge] " Bhumika Goyal
2017-08-25 15:31   ` Santosh Shilimkar
2017-08-25 15:33     ` [Bridge] " Santosh Shilimkar
2017-08-25 15:31     ` Santosh Shilimkar
2017-08-28 18:30   ` [Bridge] " David Miller
2017-08-28 18:30     ` David Miller
2017-08-25 14:21 ` [PATCH 6/7] netfilter: nat: " Bhumika Goyal
2017-08-25 14:24   ` [Bridge] " Bhumika Goyal
2017-08-25 14:50   ` Florian Westphal
2017-08-25 14:21 ` [PATCH 7/7] SUNRPC: make kvec const Bhumika Goyal
2017-08-25 14:24   ` [Bridge] " Bhumika Goyal
2017-08-25 14:21   ` Bhumika Goyal
2017-08-25 14:48   ` Jeff Layton [this message]
2017-08-25 14:49     ` [Bridge] " Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503672536.4722.20.camel@redhat.com \
    --to=jlayton@redhat.com \
    --cc=alex.aring@gmail.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=bhumirks@gmail.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=fw@strlen.de \
    --cc=gustavo@padovan.org \
    --cc=johan.hedberg@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=santosh.shilimkar@oracle.com \
    --cc=stefan@osg.samsung.com \
    --cc=stephen@networkplumber.org \
    --cc=trond.myklebust@primarydata.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.