* [PATCH] net/mlx5: add a missing tab
@ 2017-08-01 11:01 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2017-08-01 11:01 UTC (permalink / raw)
To: Saeed Mahameed
Cc: Matan Barak, Leon Romanovsky, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
The code works as intended, but the indenting is confusing.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
index 28d8472b36f1..c410360da58d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
@@ -113,7 +113,7 @@ static int mlx5_device_enable_sriov(struct mlx5_core_dev *dev, int num_vfs)
mlx5_core_warn(dev,
"failed to restore VF %d settings, err %d\n",
vf, err);
- continue;
+ continue;
}
}
mlx5_core_dbg(dev, "successfully enabled VF* %d\n", vf);
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] net/mlx5: add a missing tab
@ 2017-08-01 11:01 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2017-08-01 11:01 UTC (permalink / raw)
To: Saeed Mahameed
Cc: Matan Barak, Leon Romanovsky, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
The code works as intended, but the indenting is confusing.
Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
index 28d8472b36f1..c410360da58d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
@@ -113,7 +113,7 @@ static int mlx5_device_enable_sriov(struct mlx5_core_dev *dev, int num_vfs)
mlx5_core_warn(dev,
"failed to restore VF %d settings, err %d\n",
vf, err);
- continue;
+ continue;
}
}
mlx5_core_dbg(dev, "successfully enabled VF* %d\n", vf);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] net/mlx5: add a missing tab
2017-08-01 11:01 ` Dan Carpenter
@ 2017-08-28 23:09 ` Doug Ledford
-1 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2017-08-28 23:09 UTC (permalink / raw)
To: Dan Carpenter, Saeed Mahameed
Cc: Matan Barak, Leon Romanovsky, linux-rdma, kernel-janitors
On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote:
> The code works as intended, but the indenting is confusing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
You didn't include netdev on this patch, and I haven't seen a note from
janitors that they took it, so I decided to send it on through. It's
minor enough it shouldn't be an issue conflicting with Dave's tree I
would think. I'll know I was wrong if I get yelled at.
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> index 28d8472b36f1..c410360da58d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> @@ -113,7 +113,7 @@ static int mlx5_device_enable_sriov(struct
> mlx5_core_dev *dev, int num_vfs)
> mlx5_core_warn(dev,
> "failed to restore VF
> %d settings, err %d\n",
> vf, err);
> - continue;
> + continue;
> }
> }
> mlx5_core_dbg(dev, "successfully enabled VF* %d\n",
> vf);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] net/mlx5: add a missing tab
@ 2017-08-28 23:09 ` Doug Ledford
0 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2017-08-28 23:09 UTC (permalink / raw)
To: Dan Carpenter, Saeed Mahameed
Cc: Matan Barak, Leon Romanovsky, linux-rdma, kernel-janitors
On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote:
> The code works as intended, but the indenting is confusing.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
You didn't include netdev on this patch, and I haven't seen a note from
janitors that they took it, so I decided to send it on through. It's
minor enough it shouldn't be an issue conflicting with Dave's tree I
would think. I'll know I was wrong if I get yelled at.
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> index 28d8472b36f1..c410360da58d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
> @@ -113,7 +113,7 @@ static int mlx5_device_enable_sriov(struct
> mlx5_core_dev *dev, int num_vfs)
> mlx5_core_warn(dev,
> "failed to restore VF
> %d settings, err %d\n",
> vf, err);
> - continue;
> + continue;
> }
> }
> mlx5_core_dbg(dev, "successfully enabled VF* %d\n",
> vf);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] net/mlx5: add a missing tab
2017-08-28 23:09 ` Doug Ledford
@ 2017-08-29 9:14 ` Dan Carpenter
-1 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2017-08-29 9:14 UTC (permalink / raw)
To: Doug Ledford
Cc: Saeed Mahameed, Matan Barak, Leon Romanovsky, linux-rdma,
kernel-janitors
On Mon, Aug 28, 2017 at 07:09:47PM -0400, Doug Ledford wrote:
> On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote:
> > The code works as intended, but the indenting is confusing.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> You didn't include netdev on this patch, and I haven't seen a note from
> janitors that they took it, so I decided to send it on through. It's
> minor enough it shouldn't be an issue conflicting with Dave's tree I
> would think. I'll know I was wrong if I get yelled at.
>
Ooo... Wow. Don't do that. You're going to get me yelled at too.
I guess I thought this went through the RDMA tree but looking at it now
it's obvioulsy net.
regards,
dan carpetner
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] net/mlx5: add a missing tab
@ 2017-08-29 9:14 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2017-08-29 9:14 UTC (permalink / raw)
To: Doug Ledford
Cc: Saeed Mahameed, Matan Barak, Leon Romanovsky, linux-rdma,
kernel-janitors
On Mon, Aug 28, 2017 at 07:09:47PM -0400, Doug Ledford wrote:
> On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote:
> > The code works as intended, but the indenting is confusing.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> You didn't include netdev on this patch, and I haven't seen a note from
> janitors that they took it, so I decided to send it on through. It's
> minor enough it shouldn't be an issue conflicting with Dave's tree I
> would think. I'll know I was wrong if I get yelled at.
>
Ooo... Wow. Don't do that. You're going to get me yelled at too.
I guess I thought this went through the RDMA tree but looking at it now
it's obvioulsy net.
regards,
dan carpetner
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] net/mlx5: add a missing tab
2017-08-29 9:14 ` Dan Carpenter
@ 2017-08-29 12:29 ` Doug Ledford
-1 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2017-08-29 12:29 UTC (permalink / raw)
To: Dan Carpenter
Cc: Saeed Mahameed, Matan Barak, Leon Romanovsky,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Tue, 2017-08-29 at 12:14 +0300, Dan Carpenter wrote:
> On Mon, Aug 28, 2017 at 07:09:47PM -0400, Doug Ledford wrote:
> > On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote:
> > > The code works as intended, but the indenting is confusing.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > You didn't include netdev on this patch, and I haven't seen a note
> > from
> > janitors that they took it, so I decided to send it on
> > through. It's
> > minor enough it shouldn't be an issue conflicting with Dave's tree
> > I
> > would think. I'll know I was wrong if I get yelled at.
> >
>
> Ooo... Wow. Don't do that. You're going to get me yelled at too.
>
> I guess I thought this went through the RDMA tree but looking at it
> now
> it's obvioulsy net.
Fortunately for us, I only pushed this to github last night, so I can
still drop this out of my branch before pushing to k.o. I'll let you
submit it to the proper place :-)
---
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] net/mlx5: add a missing tab
@ 2017-08-29 12:29 ` Doug Ledford
0 siblings, 0 replies; 8+ messages in thread
From: Doug Ledford @ 2017-08-29 12:29 UTC (permalink / raw)
To: Dan Carpenter
Cc: Saeed Mahameed, Matan Barak, Leon Romanovsky,
linux-rdma-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
On Tue, 2017-08-29 at 12:14 +0300, Dan Carpenter wrote:
> On Mon, Aug 28, 2017 at 07:09:47PM -0400, Doug Ledford wrote:
> > On Tue, 2017-08-01 at 14:01 +0300, Dan Carpenter wrote:
> > > The code works as intended, but the indenting is confusing.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> >
> > You didn't include netdev on this patch, and I haven't seen a note
> > from
> > janitors that they took it, so I decided to send it on
> > through. It's
> > minor enough it shouldn't be an issue conflicting with Dave's tree
> > I
> > would think. I'll know I was wrong if I get yelled at.
> >
>
> Ooo... Wow. Don't do that. You're going to get me yelled at too.
>
> I guess I thought this went through the RDMA tree but looking at it
> now
> it's obvioulsy net.
Fortunately for us, I only pushed this to github last night, so I can
still drop this out of my branch before pushing to k.o. I'll let you
submit it to the proper place :-)
---
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-08-29 12:29 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-01 11:01 [PATCH] net/mlx5: add a missing tab Dan Carpenter
2017-08-01 11:01 ` Dan Carpenter
2017-08-28 23:09 ` Doug Ledford
2017-08-28 23:09 ` Doug Ledford
2017-08-29 9:14 ` Dan Carpenter
2017-08-29 9:14 ` Dan Carpenter
2017-08-29 12:29 ` Doug Ledford
2017-08-29 12:29 ` Doug Ledford
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.