* [PATCH] IB/rxe: constify vm_operations_struct
@ 2017-08-28 4:30 Arvind Yadav
[not found] ` <86676f86a57d743545a0ff0ba477902ed676aa6b.1503894343.git.arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Arvind Yadav @ 2017-08-28 4:30 UTC (permalink / raw)
To: monis, dledford, sean.hefty, hal.rosenstock; +Cc: linux-kernel, linux-rdma
vm_operations_struct are not supposed to change at runtime.
vm_area_struct structure working with const vm_operations_struct.
So mark the non-const vm_operations_struct structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/infiniband/sw/rxe/rxe_mmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_mmap.c b/drivers/infiniband/sw/rxe/rxe_mmap.c
index bd812e0..d22431e 100644
--- a/drivers/infiniband/sw/rxe/rxe_mmap.c
+++ b/drivers/infiniband/sw/rxe/rxe_mmap.c
@@ -76,7 +76,7 @@ static void rxe_vma_close(struct vm_area_struct *vma)
kref_put(&ip->ref, rxe_mmap_release);
}
-static struct vm_operations_struct rxe_vm_ops = {
+static const struct vm_operations_struct rxe_vm_ops = {
.open = rxe_vma_open,
.close = rxe_vma_close,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <86676f86a57d743545a0ff0ba477902ed676aa6b.1503894343.git.arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] IB/rxe: constify vm_operations_struct 2017-08-28 4:30 [PATCH] IB/rxe: constify vm_operations_struct Arvind Yadav @ 2017-08-28 23:18 ` Doug Ledford 0 siblings, 0 replies; 3+ messages in thread From: Doug Ledford @ 2017-08-28 23:18 UTC (permalink / raw) To: Arvind Yadav, monis-VPRAkNaXOzVWk0Htik3J/w, sean.hefty-ral2JQCrhuEAvxtiuMwx3w, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-rdma-u79uwXL29TY76Z2rM5mHXA On Mon, 2017-08-28 at 10:00 +0530, Arvind Yadav wrote: > vm_operations_struct are not supposed to change at runtime. > vm_area_struct structure working with const vm_operations_struct. > So mark the non-const vm_operations_struct structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sorry, this bug had already been fixed by a previous patch. Thanks for your submission though. -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/rxe: constify vm_operations_struct @ 2017-08-28 23:18 ` Doug Ledford 0 siblings, 0 replies; 3+ messages in thread From: Doug Ledford @ 2017-08-28 23:18 UTC (permalink / raw) To: Arvind Yadav, monis, sean.hefty, hal.rosenstock; +Cc: linux-kernel, linux-rdma On Mon, 2017-08-28 at 10:00 +0530, Arvind Yadav wrote: > vm_operations_struct are not supposed to change at runtime. > vm_area_struct structure working with const vm_operations_struct. > So mark the non-const vm_operations_struct structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Sorry, this bug had already been fixed by a previous patch. Thanks for your submission though. -- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-28 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-28 4:30 [PATCH] IB/rxe: constify vm_operations_struct Arvind Yadav
[not found] ` <86676f86a57d743545a0ff0ba477902ed676aa6b.1503894343.git.arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-28 23:18 ` Doug Ledford
2017-08-28 23:18 ` Doug Ledford
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.