From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Colin King <colin.king@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Phil Elwell <phil@raspberrypi.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Eric Anholt <eric@anholt.net>,
Thor Thayer <tthayer@opensource.altera.com>,
Rafael Gago <rafael.gago@gmail.com>,
David Lechner <david@lechnology.com>,
linux-serial@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][serial-next] serial: 8250: don't dereference em485 until it has been null checked
Date: Tue, 29 Aug 2017 20:22:04 +0000 [thread overview]
Message-ID: <1504038124.25945.155.camel@linux.intel.com> (raw)
In-Reply-To: <20170829200411.wbqdsihcnhpg2gmr@mwanda>
On Tue, 2017-08-29 at 23:04 +0300, Dan Carpenter wrote:
> On Tue, Aug 29, 2017 at 05:58:15PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently, the pointer em485 is dereferenced to get p and then later
> > em485 is checked to see if it is null before calling __start_tx. In
> > the case where em485 is null, we get a null pointer dereference. Fix
> > this by moving the deference and the associated spinlock/unlocks on
> > p to the code block where em485 is known to be not null.
> >
> > Detected by CoverityScan, CID#14555001 ("Dereference before null
> > check")
> >
> > Fixes 6e0a5de2136b ("serial: 8250: Use hrtimers for rs485 delays")
>
> I don't understand which tree this commit is from. I have it fetched
> but when I do a git log on drivers/tty/serial/8250/8250_port.c then I
> don't see it. I have today's linux-next.
I see it, though I have tty-next as well.
> I'm pretty sure "t" isn't ever NULL.
(I'm pretty sure there is a false positive, though code would be cleaned
to avoid such reports)
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Colin King <colin.king@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Phil Elwell <phil@raspberrypi.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Eric Anholt <eric@anholt.net>,
Thor Thayer <tthayer@opensource.altera.com>,
Rafael Gago <rafael.gago@gmail.com>,
David Lechner <david@lechnology.com>,
linux-serial@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][serial-next] serial: 8250: don't dereference em485 until it has been null checked
Date: Tue, 29 Aug 2017 23:22:04 +0300 [thread overview]
Message-ID: <1504038124.25945.155.camel@linux.intel.com> (raw)
In-Reply-To: <20170829200411.wbqdsihcnhpg2gmr@mwanda>
On Tue, 2017-08-29 at 23:04 +0300, Dan Carpenter wrote:
> On Tue, Aug 29, 2017 at 05:58:15PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently, the pointer em485 is dereferenced to get p and then later
> > em485 is checked to see if it is null before calling __start_tx. In
> > the case where em485 is null, we get a null pointer dereference. Fix
> > this by moving the deference and the associated spinlock/unlocks on
> > p to the code block where em485 is known to be not null.
> >
> > Detected by CoverityScan, CID#14555001 ("Dereference before null
> > check")
> >
> > Fixes 6e0a5de2136b ("serial: 8250: Use hrtimers for rs485 delays")
>
> I don't understand which tree this commit is from. I have it fetched
> but when I do a git log on drivers/tty/serial/8250/8250_port.c then I
> don't see it. I have today's linux-next.
I see it, though I have tty-next as well.
> I'm pretty sure "t" isn't ever NULL.
(I'm pretty sure there is a false positive, though code would be cleaned
to avoid such reports)
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-08-29 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 16:58 [PATCH][serial-next] serial: 8250: don't dereference em485 until it has been null checked Colin King
2017-08-29 16:58 ` Colin King
2017-08-29 19:57 ` Andy Shevchenko
2017-08-29 19:57 ` Andy Shevchenko
2017-08-29 20:04 ` Dan Carpenter
2017-08-29 20:04 ` Dan Carpenter
2017-08-29 20:22 ` Andy Shevchenko [this message]
2017-08-29 20:22 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504038124.25945.155.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=david@lechnology.com \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=jslaby@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=phil@raspberrypi.org \
--cc=rafael.gago@gmail.com \
--cc=tthayer@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.