From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: devicetree@vger.kernel.org, linux-mips@linux-mips.org,
monstr@monstr.eu,
Linux PPC Mailing List <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] devicetree: Remove remaining references/tests for "chosen@0"
Date: Sun, 03 Sep 2017 22:02:34 +1000 [thread overview]
Message-ID: <1504440154.2250.1.camel@kernel.crashing.org> (raw)
In-Reply-To: <alpine.LFD.2.21.1709030637090.24875@localhost.localdomain>
On Sun, 2017-09-03 at 06:43 -0400, Robert P. J. Day wrote:
> however, given the diff stat of the change to remove every single
> reference to that node name in the current kernel source:
>
> arch/microblaze/kernel/prom.c | 3 +--
> arch/mips/generic/yamon-dt.c | 4 ----
> arch/powerpc/boot/oflib.c | 7 ++-----
> drivers/of/base.c | 2 --
> drivers/of/fdt.c | 5 +----
> 5 files changed, 4 insertions(+), 17 deletions(-)
>
> it seems inconsistent that three architectures would be testing for
> that node, but none of the rest. consistency suggests that every
> architecture should take it into account, or none should.
>
> anyway, not a big deal, i'm fine with any decision.
powerpc is the only one of the 3 who has an actual open firmware
implementation afaik.
In any case, I think you can probably remove from microblaze and
possibly mips but I'm a bit worried about the generic case and powerpc
boot.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: "Robert P. J. Day" <rpjday-L09J2beyid0N/H6P543EQg@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org,
monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org,
Linux PPC Mailing List
<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH] devicetree: Remove remaining references/tests for "chosen@0"
Date: Sun, 03 Sep 2017 22:02:34 +1000 [thread overview]
Message-ID: <1504440154.2250.1.camel@kernel.crashing.org> (raw)
In-Reply-To: <alpine.LFD.2.21.1709030637090.24875-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
On Sun, 2017-09-03 at 06:43 -0400, Robert P. J. Day wrote:
> however, given the diff stat of the change to remove every single
> reference to that node name in the current kernel source:
>
> arch/microblaze/kernel/prom.c | 3 +--
> arch/mips/generic/yamon-dt.c | 4 ----
> arch/powerpc/boot/oflib.c | 7 ++-----
> drivers/of/base.c | 2 --
> drivers/of/fdt.c | 5 +----
> 5 files changed, 4 insertions(+), 17 deletions(-)
>
> it seems inconsistent that three architectures would be testing for
> that node, but none of the rest. consistency suggests that every
> architecture should take it into account, or none should.
>
> anyway, not a big deal, i'm fine with any decision.
powerpc is the only one of the 3 who has an actual open firmware
implementation afaik.
In any case, I think you can probably remove from microblaze and
possibly mips but I'm a bit worried about the generic case and powerpc
boot.
Cheers,
Ben.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-09-03 12:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 8:43 [PATCH] devicetree: Remove remaining references/tests for "chosen@0" Robert P. J. Day
2017-09-02 8:43 ` Robert P. J. Day
2017-09-02 22:20 ` Benjamin Herrenschmidt
2017-09-02 22:20 ` Benjamin Herrenschmidt
2017-09-03 10:43 ` Robert P. J. Day
2017-09-03 10:43 ` Robert P. J. Day
2017-09-03 12:02 ` Benjamin Herrenschmidt [this message]
2017-09-03 12:02 ` Benjamin Herrenschmidt
2017-09-05 14:30 ` Rob Herring
2017-09-05 14:30 ` Rob Herring
2017-09-05 21:22 ` Robert P. J. Day
2017-09-05 21:22 ` Robert P. J. Day
2017-09-05 14:41 ` Rob Herring
2017-09-05 14:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504440154.2250.1.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=monstr@monstr.eu \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.