From: Zhang Rui <rui.zhang@intel.com>
To: Colin King <colin.king@canonical.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-pm@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] Thermal: int3406_thermal: fix unused variable warning
Date: Mon, 04 Sep 2017 03:36:41 +0000 [thread overview]
Message-ID: <1504496201.2762.2.camel@intel.com> (raw)
In-Reply-To: <20170901095809.16787-1-colin.king@canonical.com>
On Fri, 2017-09-01 at 10:58 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable index was introduced by an earlier commit and is not
> used, and hence should be removed.
>
> Cleans up warning: "unused variable 'index'"
>
> Fixes: c658894562ba ("Thermal: int3406_thermal: fix thermal sysfs
> I/F")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
thanks, I will fold this cleanup into the previous commit c658894562ba
("Thermal: int3406_thermal: fix thermal sysfs I/F").
thanks,
rui
> ---
> drivers/thermal/int340x_thermal/int3406_thermal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/int340x_thermal/int3406_thermal.c
> b/drivers/thermal/int340x_thermal/int3406_thermal.c
> index e31509ead1c9..f69ab026ba24 100644
> --- a/drivers/thermal/int340x_thermal/int3406_thermal.c
> +++ b/drivers/thermal/int340x_thermal/int3406_thermal.c
> @@ -113,7 +113,6 @@ static void int3406_thermal_get_limit(struct
> int3406_thermal_data *d)
> {
> acpi_status status;
> unsigned long long lower_limit, upper_limit;
> - int index;
>
> status = acpi_evaluate_integer(d->handle, "DDDL", NULL,
> &lower_limit);
> if (ACPI_SUCCESS(status))
WARNING: multiple messages have this Message-ID (diff)
From: Zhang Rui <rui.zhang@intel.com>
To: Colin King <colin.king@canonical.com>,
Eduardo Valentin <edubezval@gmail.com>,
linux-pm@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] Thermal: int3406_thermal: fix unused variable warning
Date: Mon, 04 Sep 2017 11:36:41 +0800 [thread overview]
Message-ID: <1504496201.2762.2.camel@intel.com> (raw)
In-Reply-To: <20170901095809.16787-1-colin.king@canonical.com>
On Fri, 2017-09-01 at 10:58 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable index was introduced by an earlier commit and is not
> used, and hence should be removed.
>
> Cleans up warning: "unused variable 'index'"
>
> Fixes: c658894562ba ("Thermal: int3406_thermal: fix thermal sysfs
> I/F")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
thanks, I will fold this cleanup into the previous commit c658894562ba
("Thermal: int3406_thermal: fix thermal sysfs I/F").
thanks,
rui
> ---
> drivers/thermal/int340x_thermal/int3406_thermal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/int340x_thermal/int3406_thermal.c
> b/drivers/thermal/int340x_thermal/int3406_thermal.c
> index e31509ead1c9..f69ab026ba24 100644
> --- a/drivers/thermal/int340x_thermal/int3406_thermal.c
> +++ b/drivers/thermal/int340x_thermal/int3406_thermal.c
> @@ -113,7 +113,6 @@ static void int3406_thermal_get_limit(struct
> int3406_thermal_data *d)
> {
> acpi_status status;
> unsigned long long lower_limit, upper_limit;
> - int index;
>
> status = acpi_evaluate_integer(d->handle, "DDDL", NULL,
> &lower_limit);
> if (ACPI_SUCCESS(status))
next prev parent reply other threads:[~2017-09-04 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 9:58 [PATCH][next] Thermal: int3406_thermal: fix unused variable warning Colin King
2017-09-01 9:58 ` Colin King
2017-09-04 3:36 ` Zhang Rui [this message]
2017-09-04 3:36 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504496201.2762.2.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=colin.king@canonical.com \
--cc=edubezval@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.