All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Minghuan Lian <Minghuan.Lian@freescale.com>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Zang Roy-R61911 <r61911@freescale.com>,
	Hu Mingkai-B21284 <B21284@freescale.com>,
	Scott Wood <scottwood@freescale.com>,
	Yoder Stuart-B08248 <stuart.yoder@freescale.com>
Subject: Re: [PATCH v6] PCI: Layerscape: Add Layerscape PCIe driver
Date: Thu, 13 Nov 2014 18:08:54 +0100	[thread overview]
Message-ID: <1504614.TjszoPYyHM@wuerfel> (raw)
In-Reply-To: <20141113163833.GA5064@google.com>

On Thursday 13 November 2014 09:38:33 Bjorn Helgaas wrote:
> On Wed, Nov 05, 2014 at 04:45:11PM +0800, Minghuan Lian wrote:
> > Add support for Freescale Layerscape PCIe controller. This driver
> > re-uses the designware core code.
> > 
> > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> 
> Applied with Arnd's ack to pci/host-layerscape for v3.19, thanks!
> 

the build bot just came back with an error:

  make.cross ARCH=xtensa 

All error/warnings:

>> drivers/pci/host/pcie-designware.c:168:52: warning: 'struct pci_sys_data' declared inside parameter list
    static inline struct pcie_port *sys_to_pcie(struct pci_sys_data *sys)
                                                       ^
>> drivers/pci/host/pcie-designware.c:168:52: warning: its scope is only this definition or declaration, which is probably not what you want
   drivers/pci/host/pcie-designware.c: In function 'sys_to_pcie':
   drivers/pci/host/pcie-designware.c:170:12: error: dereferencing pointer to incomplete type
     return sys->private_data;
               ^
   drivers/pci/host/pcie-designware.c: At top level:
>> drivers/pci/host/pcie-designware.c:397:45: warning: 'struct pci_sys_data' declared inside parameter list


The new Kconfig symbol evidently needs a 'depends on ARM'.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6] PCI: Layerscape: Add Layerscape PCIe driver
Date: Thu, 13 Nov 2014 18:08:54 +0100	[thread overview]
Message-ID: <1504614.TjszoPYyHM@wuerfel> (raw)
In-Reply-To: <20141113163833.GA5064@google.com>

On Thursday 13 November 2014 09:38:33 Bjorn Helgaas wrote:
> On Wed, Nov 05, 2014 at 04:45:11PM +0800, Minghuan Lian wrote:
> > Add support for Freescale Layerscape PCIe controller. This driver
> > re-uses the designware core code.
> > 
> > Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> 
> Applied with Arnd's ack to pci/host-layerscape for v3.19, thanks!
> 

the build bot just came back with an error:

  make.cross ARCH=xtensa 

All error/warnings:

>> drivers/pci/host/pcie-designware.c:168:52: warning: 'struct pci_sys_data' declared inside parameter list
    static inline struct pcie_port *sys_to_pcie(struct pci_sys_data *sys)
                                                       ^
>> drivers/pci/host/pcie-designware.c:168:52: warning: its scope is only this definition or declaration, which is probably not what you want
   drivers/pci/host/pcie-designware.c: In function 'sys_to_pcie':
   drivers/pci/host/pcie-designware.c:170:12: error: dereferencing pointer to incomplete type
     return sys->private_data;
               ^
   drivers/pci/host/pcie-designware.c: At top level:
>> drivers/pci/host/pcie-designware.c:397:45: warning: 'struct pci_sys_data' declared inside parameter list


The new Kconfig symbol evidently needs a 'depends on ARM'.

	Arnd

  reply	other threads:[~2014-11-13 17:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05  8:45 [PATCH v6] PCI: Layerscape: Add Layerscape PCIe driver Minghuan Lian
2014-11-05  8:45 ` Minghuan Lian
2014-11-05  9:24 ` Arnd Bergmann
2014-11-05  9:24   ` Arnd Bergmann
2014-11-13 16:38 ` Bjorn Helgaas
2014-11-13 16:38   ` Bjorn Helgaas
2014-11-13 17:08   ` Arnd Bergmann [this message]
2014-11-13 17:08     ` Arnd Bergmann
  -- strict thread matches above, loose matches on Subject: below --
2014-10-14 10:18 Minghuan Lian
2014-10-14 10:18 ` Minghuan Lian
2014-10-14 10:18 ` Minghuan Lian
2014-10-14 10:18   ` Minghuan Lian
2014-10-16 14:41 ` Kumar Gala
2014-10-16 14:41   ` Kumar Gala
2014-10-17  7:18   ` 答复: " Minghuan.Lian at freescale.com
2014-10-17  7:43     ` Kumar Gala
2014-10-17  7:43       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504614.TjszoPYyHM@wuerfel \
    --to=arnd@arndb.de \
    --cc=B21284@freescale.com \
    --cc=Minghuan.Lian@freescale.com \
    --cc=bhelgaas@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=r61911@freescale.com \
    --cc=scottwood@freescale.com \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.