From: Joe Perches <joe@perches.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH] security/keys: Adding newline after declaration
Date: Thu, 07 Sep 2017 05:54:57 +0000 [thread overview]
Message-ID: <1504763697.7546.9.camel@perches.com> (raw)
In-Reply-To: <1504762905-2424-1-git-send-email-pushkar.iit@gmail.com>
On Thu, 2017-09-07 at 11:11 +0530, Pushkar Jambhlekar wrote:
> Fixing checkpatch warning to add newline after declaration
[]
> diff --git a/security/keys/big_key.c b/security/keys/big_key.c
[]
> @@ -93,6 +93,7 @@ static int big_key_crypt(enum big_key_op op, u8 *data, size_t datalen, u8 *key)
> {
> int ret = -EINVAL;
> struct scatterlist sgio;
> +
> SKCIPHER_REQUEST_ON_STACK(req, big_key_skcipher);
checkpatch doesn't know that SKCIPHER_REQUEST_ON_STACK
is actually 2 declarations.
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] security/keys: Adding newline after declaration
Date: Wed, 06 Sep 2017 22:54:57 -0700 [thread overview]
Message-ID: <1504763697.7546.9.camel@perches.com> (raw)
In-Reply-To: <1504762905-2424-1-git-send-email-pushkar.iit@gmail.com>
On Thu, 2017-09-07 at 11:11 +0530, Pushkar Jambhlekar wrote:
> Fixing checkpatch warning to add newline after declaration
[]
> diff --git a/security/keys/big_key.c b/security/keys/big_key.c
[]
> @@ -93,6 +93,7 @@ static int big_key_crypt(enum big_key_op op, u8 *data, size_t datalen, u8 *key)
> {
> int ret = -EINVAL;
> struct scatterlist sgio;
> +
> SKCIPHER_REQUEST_ON_STACK(req, big_key_skcipher);
checkpatch doesn't know that SKCIPHER_REQUEST_ON_STACK
is actually 2 declarations.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>,
David Howells <dhowells@redhat.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security/keys: Adding newline after declaration
Date: Wed, 06 Sep 2017 22:54:57 -0700 [thread overview]
Message-ID: <1504763697.7546.9.camel@perches.com> (raw)
In-Reply-To: <1504762905-2424-1-git-send-email-pushkar.iit@gmail.com>
On Thu, 2017-09-07 at 11:11 +0530, Pushkar Jambhlekar wrote:
> Fixing checkpatch warning to add newline after declaration
[]
> diff --git a/security/keys/big_key.c b/security/keys/big_key.c
[]
> @@ -93,6 +93,7 @@ static int big_key_crypt(enum big_key_op op, u8 *data, size_t datalen, u8 *key)
> {
> int ret = -EINVAL;
> struct scatterlist sgio;
> +
> SKCIPHER_REQUEST_ON_STACK(req, big_key_skcipher);
checkpatch doesn't know that SKCIPHER_REQUEST_ON_STACK
is actually 2 declarations.
next prev parent reply other threads:[~2017-09-07 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 5:41 [PATCH] security/keys: Adding newline after declaration Pushkar Jambhlekar
2017-09-07 5:53 ` Pushkar Jambhlekar
2017-09-07 5:41 ` Pushkar Jambhlekar
2017-09-07 5:54 ` Joe Perches [this message]
2017-09-07 5:54 ` Joe Perches
2017-09-07 5:54 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504763697.7546.9.camel@perches.com \
--to=joe@perches.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.