From: "Martin J. Bligh" <mbligh-/CzTsIfkJEdBDgjK7y7TUQ@public.gmane.org>
To: Andy Grover <agrover-qb8aLOKklSjp4P8CbLYnNQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: acpi-devel-pyega4qmqnRoyOMFzWx49A@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] SMP parsing rewrite, phase 1
Date: Mon, 20 Jan 2003 20:28:20 -0800 [thread overview]
Message-ID: <1504840000.1043123300@titus> (raw)
In-Reply-To: <Pine.LNX.4.44.0301201834310.26042-100000-SNx59YkgthvyYw2uXbqB2185lzT46atW@public.gmane.org>
Would be a lot easier to read if you could seperate out the
renames from the rest of the patch that actually does things.
It all makes me slightly nervous as this stuff is really easy
to break ... and it breaks wierd machines that are hard to test
for (been there, done that ;-)).
+static u8 raw_phys_apicid[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
Looks odd. May have merged forward badly, that got renamed in 2.5.59
to bios_cpu_apicid or something.
Anyway, I'll give it a spin on my wierdo box, and see what happens.
M.
WARNING: multiple messages have this Message-ID (diff)
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Andy Grover <agrover@groveronline.com>, linux-kernel@vger.kernel.org
Cc: acpi-devel@sourceforge.net, mingo@redhat.com
Subject: Re: [PATCH] SMP parsing rewrite, phase 1
Date: Mon, 20 Jan 2003 20:28:20 -0800 [thread overview]
Message-ID: <1504840000.1043123300@titus> (raw)
In-Reply-To: <Pine.LNX.4.44.0301201834310.26042-100000@dexter.groveronline.com>
Would be a lot easier to read if you could seperate out the
renames from the rest of the patch that actually does things.
It all makes me slightly nervous as this stuff is really easy
to break ... and it breaks wierd machines that are hard to test
for (been there, done that ;-)).
+static u8 raw_phys_apicid[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
Looks odd. May have merged forward badly, that got renamed in 2.5.59
to bios_cpu_apicid or something.
Anyway, I'll give it a spin on my wierdo box, and see what happens.
M.
next prev parent reply other threads:[~2003-01-21 4:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-21 3:12 [PATCH] SMP parsing rewrite, phase 1 Andy Grover
2003-01-21 3:12 ` Andy Grover
[not found] ` <Pine.LNX.4.44.0301201834310.26042-100000-SNx59YkgthvyYw2uXbqB2185lzT46atW@public.gmane.org>
2003-01-21 4:28 ` Martin J. Bligh [this message]
2003-01-21 4:28 ` Martin J. Bligh
2003-01-21 7:12 ` Zwane Mwaikambo
2003-01-21 7:12 ` Zwane Mwaikambo
2003-01-21 20:31 ` Andrew Walrond
2003-01-21 20:31 ` Andrew Walrond
2003-01-21 20:54 ` Andrew Walrond
2003-01-21 20:54 ` Andrew Walrond
[not found] ` <3E2DAE2F.1070503-2/QedQ4M3FBAfugRpC6u6w@public.gmane.org>
2003-01-22 22:12 ` Pavel Machek
2003-01-22 22:12 ` Pavel Machek
[not found] ` <20030122221256.GB14641-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2003-01-22 22:33 ` David Woodhouse
2003-01-22 22:33 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2003-01-21 18:36 Grover, Andrew
2003-01-21 18:36 ` Grover, Andrew
[not found] ` <F760B14C9561B941B89469F59BA3A84725A12B-sBd4vmA9Se4Lll3ZsUKC9FDQ4js95KgL@public.gmane.org>
2003-01-21 19:26 ` Martin J. Bligh
2003-01-21 19:26 ` Martin J. Bligh
2003-01-21 22:31 Grover, Andrew
2003-01-21 22:31 ` Grover, Andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504840000.1043123300@titus \
--to=mbligh-/cztsifkjedbdgjk7y7tuq@public.gmane.org \
--cc=acpi-devel-pyega4qmqnRoyOMFzWx49A@public.gmane.org \
--cc=agrover-qb8aLOKklSjp4P8CbLYnNQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.