From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"tj@kernel.org" <tj@kernel.org>
Subject: Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen
Date: Fri, 8 Sep 2017 17:28:16 +0000 [thread overview]
Message-ID: <1504891695.1665.5.camel@wdc.com> (raw)
In-Reply-To: <20170908030753.GA5627@ming.t460p>
T24gRnJpLCAyMDE3LTA5LTA4IGF0IDExOjA4ICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gTG9v
a3MgSSByZXBsaWVkIG9yIGNsYXJpZmllZCBhbGwgeW91ciBxdWVzdGlvbnMvY29tbWVudHMgb24g
dGhpcw0KPiBwYXRjaHNldC4NCg0KTm8sIHlvdSBoYXZlIG5vdCBhZGRyZXNzZWQgYWxsIG15IGNv
bW1lbnRzLCB5b3Uga25vdyB0aGF0IHlvdSBoYXZlIG5vdA0KYWRkcmVzc2VkIGFsbCBteSBjb21t
ZW50cyBzbyB5b3Ugc2hvdWxkIG5vdCBoYXZlIHdyaXR0ZW4gdGhhdCB5b3UgaGF2ZQ0KYWRkcmVz
c2VkIGFsbCBteSBjb21tZW50cy4gVGhpcyBwYXRjaCBzZXJpZXMgbm90IG9ubHkgaW50cm9kdWNl
cyB1Z2x5DQpjaGFuZ2VzIGluIHRoZSByZXF1ZXN0IHF1ZXVlIGZyZWV6ZSBtZWNoYW5pc20gYnV0
IGl0IGFsc28gaW50cm9kdWNlcyBhbg0KdW5hY2NlcHRhYmxlIHJhY2UgY29uZGl0aW9uIGJldHdl
ZW4gYmxrX2dldF9yZXF1ZXN0KCkgYW5kIHJlcXVlc3QgcXVldWUNCmNsZWFudXAuDQoNCkJUVywg
eW91IGRvbid0IGhhdmUgdG8gc3BlbmQgbW9yZSB0aW1lIG9uIHRoaXMgcGF0Y2ggc2VyaWVzLiBJ
IGhhdmUNCmltcGxlbWVudGVkIGFuIGFsdGVybmF0aXZlIGFuZCBtdWNoIGNsZWFuZXIgYXBwcm9h
Y2ggdG8gZml4IFNDU0kgZGV2aWNlDQpzdXNwZW5kLiBJJ20gY3VycmVudGx5IHRlc3RpbmcgdGhh
dCBwYXRjaCBzZXJpZXMuDQoNCkJhcnQu
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "ming.lei@redhat.com" <ming.lei@redhat.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"jthumshirn@suse.de" <jthumshirn@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"tj@kernel.org" <tj@kernel.org>
Subject: Re: [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen
Date: Fri, 8 Sep 2017 17:28:16 +0000 [thread overview]
Message-ID: <1504891695.1665.5.camel@wdc.com> (raw)
In-Reply-To: <20170908030753.GA5627@ming.t460p>
On Fri, 2017-09-08 at 11:08 +0800, Ming Lei wrote:
> Looks I replied or clarified all your questions/comments on this
> patchset.
No, you have not addressed all my comments, you know that you have not
addressed all my comments so you should not have written that you have
addressed all my comments. This patch series not only introduces ugly
changes in the request queue freeze mechanism but it also introduces an
unacceptable race condition between blk_get_request() and request queue
cleanup.
BTW, you don't have to spend more time on this patch series. I have
implemented an alternative and much cleaner approach to fix SCSI device
suspend. I'm currently testing that patch series.
Bart.
next prev parent reply other threads:[~2017-09-08 17:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 13:08 [PATCH V3 0/8] block/scsi: safe SCSI quiescing Ming Lei
2017-09-02 13:08 ` [PATCH V3 1/8] blk-mq: rename blk_mq_unfreeze_queue as blk_unfreeze_queue Ming Lei
2017-09-02 13:08 ` [PATCH V3 2/8] blk-mq: rename blk_mq_freeze_queue as blk_freeze_queue Ming Lei
2017-09-02 13:08 ` [PATCH V3 3/8] blk-mq: only run hw queues for blk-mq Ming Lei
2017-09-02 13:08 ` [PATCH V3 4/8] blk-mq: rename blk_mq_freeze_queue_wait as blk_freeze_queue_wait Ming Lei
2017-09-02 13:08 ` [PATCH V3 5/8] block: tracking request allocation with q_usage_counter Ming Lei
2017-09-02 13:08 ` [PATCH V3 6/8] block: introduce preempt version of blk_[freeze|unfreeze]_queue Ming Lei
2017-09-04 15:21 ` Bart Van Assche
2017-09-04 15:21 ` Bart Van Assche
2017-09-04 16:20 ` Ming Lei
2017-09-02 13:08 ` [PATCH V3 7/8] block: allow to allocate req with REQF_PREEMPT when queue is preempt frozen Ming Lei
2017-09-02 13:12 ` Ming Lei
2017-09-04 4:13 ` Bart Van Assche
2017-09-04 4:13 ` Bart Van Assche
2017-09-04 7:16 ` Ming Lei
2017-09-04 15:40 ` Bart Van Assche
2017-09-04 15:40 ` Bart Van Assche
2017-09-04 16:08 ` Ming Lei
2017-09-04 16:18 ` Bart Van Assche
2017-09-04 16:18 ` Bart Van Assche
2017-09-04 16:28 ` Ming Lei
2017-09-05 1:40 ` Bart Van Assche
2017-09-05 1:40 ` Bart Van Assche
2017-09-05 2:23 ` Ming Lei
2017-09-08 3:08 ` Ming Lei
2017-09-08 17:28 ` Bart Van Assche [this message]
2017-09-08 17:28 ` Bart Van Assche
2017-09-09 7:21 ` Ming Lei
2017-09-02 13:08 ` [PATCH V3 8/8] SCSI: preempt freeze block queue when SCSI device is put into quiesce Ming Lei
2017-09-02 14:47 ` [PATCH V3 0/8] block/scsi: safe SCSI quiescing Oleksandr Natalenko
2017-09-02 14:47 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504891695.1665.5.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.