All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brandon Carpenter <brandon.carpenter@cypherpath.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully support the RFC
Date: Fri, 08 Sep 2017 11:11:21 -0700	[thread overview]
Message-ID: <1504894281.1214.0@smtp.gmail.com> (raw)
In-Reply-To: <c4d0a4bb-79d4-3a59-ba50-46ba696249cf@redhat.com>

My apologies. I read that document before submitting the patch, but 
there was a lot to take in. Would you like me to resend the patch 
without the references?
--
Brandon Carpenter | Software Engineer
Cypherpath, Inc.
400 Columbia Point Drive Ste 101 | Richland, Washington USA
Office: (650) 713-3060

On Fri, Sep 8, 2017 at 11:01 AM, Eric Blake <eblake@redhat.com> wrote:
> On 09/08/2017 12:37 PM, Brandon Carpenter wrote:
>>  We've been experiencing issues where the qemu websocket server 
>> closes
>>  connections from noVNC clients for no apparent reason. Debugging 
>> shows
>>  that certain web browsers are injecting ping and pong frames when 
>> the
>>  connection becomes idle. Some browsers send those frames without a
>>  payload, which also is causing closure. This patch series addresses
>>  these issues by making the websocket server more conformant to RFC
>>  6455 - The WebSocket Protocol.
> 
> meta-comment: sending v2 in-reply-to v1 makes it harder for automated
> tooling to recognize that you are sending new patches.  We prefer that
> v2 be a top-level thread.  More patch submission hints at:
> https://wiki.qemu.org/index.php/Contribute/SubmitAPatch
> 
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
> 

-- 


CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is 
for the sole use of the intended recipient(s) and may contain proprietary, 
confidential or privileged information or otherwise be protected by law. 
Any unauthorized review, use, disclosure or distribution is prohibited. If 
you are not the intended recipient, please notify the sender and destroy 
all copies and the original message.

  reply	other threads:[~2017-09-08 18:11 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24 18:15 [Qemu-devel] [PATCH] io: Always remove an old channel watch before adding a new one Brandon Carpenter
2017-07-24 18:42 ` [Qemu-devel] [PATCH] io: Improve websocket support by becoming more RFC compliant Brandon Carpenter
2017-07-25  8:38   ` Daniel P. Berrange
2017-07-25 15:59     ` Brandon Carpenter
2017-09-08 17:37   ` [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully support the RFC Brandon Carpenter
2017-09-08 18:01     ` Eric Blake
2017-09-08 18:11       ` Brandon Carpenter [this message]
2017-09-08 18:15         ` Eric Blake
2017-09-08 17:37   ` [Qemu-devel] [PATCH v2 1/6] io: Always remove an old channel watch before adding a new one Brandon Carpenter
2017-09-08 17:37   ` [Qemu-devel] [PATCH v2 2/6] io: Small updates in preparation for websocket changes Brandon Carpenter
2017-09-08 17:37   ` [Qemu-devel] [PATCH v2 3/6] io: Add support for fragmented websocket binary frames Brandon Carpenter
2017-09-08 17:37   ` [Qemu-devel] [PATCH v2 4/6] io: Allow empty websocket payload Brandon Carpenter
2017-09-08 17:38   ` [Qemu-devel] [PATCH v2 5/6] io: Ignore websocket PING and PONG frames Brandon Carpenter
2017-09-11  8:38     ` Daniel P. Berrange
2017-09-11  9:04       ` Daniel P. Berrange
2017-09-08 17:38   ` [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames Brandon Carpenter
2017-09-11  8:50     ` Daniel P. Berrange
2017-09-11 17:03       ` Brandon Carpenter
2017-09-11 17:10         ` Daniel P. Berrange
2017-09-11 19:04           ` Brandon Carpenter
2017-09-12  8:57             ` Daniel P. Berrange
2017-09-11 17:37     ` Daniel P. Berrange
2017-09-11 17:43       ` Brandon Carpenter
2017-09-12  9:01         ` Daniel P. Berrange
2017-09-12 15:29           ` Brandon Carpenter
2017-07-24 21:22 ` [Qemu-devel] [PATCH] io: Always remove an old channel watch before adding a new one Paolo Bonzini
2017-07-25  8:36 ` Daniel P. Berrange
2017-09-08 16:18   ` Brandon Carpenter
2017-09-08 16:22     ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504894281.1214.0@smtp.gmail.com \
    --to=brandon.carpenter@cypherpath.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.